Skip to content

Commit d9eb525

Browse files
author
Alvaro Muñoz
committed
Fix CWE-502 tests
1 parent b700b6a commit d9eb525

File tree

2 files changed

+6
-4
lines changed

2 files changed

+6
-4
lines changed
Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
| deserialization.js:4:20:4:34 | req.params.data | Unsafe Deserialization sink |
2-
| deserialization.js:5:23:5:37 | req.params.data | Unsafe Deserialization sink |
31
| deserialization.js:10:24:10:38 | req.params.data | Unsafe Deserialization sink |
42
| deserialization.js:11:27:11:41 | req.params.data | Unsafe Deserialization sink |
3+
| deserialization.js:12:20:12:34 | req.params.data | Unsafe Deserialization sink |
4+
| deserialization.js:13:23:13:37 | req.params.data | Unsafe Deserialization sink |
Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,11 +1,13 @@
11
// https://github.com/advanced-security/codeql-queries/blob/js/audit/codeql/javascript/ql/test/query-tests/Security/CWE-502/tst.js
22
const jsyaml = require("js-yaml");
33

4-
data = jsyaml.load(req.params.data); // NOT OK
5-
data = jsyaml.loadAll(req.params.data); // NOT OK
4+
data = jsyaml.load(req.params.data); // OK
5+
data = jsyaml.loadAll(req.params.data); // OK
66
data = jsyaml.safeLoad(req.params.data); // OK
77
data = jsyaml.safeLoadAll(req.params.data); // OK
88

99
let unsafeConfig = { schema: jsyaml.DEFAULT_FULL_SCHEMA };
1010
data = jsyaml.safeLoad(req.params.data, unsafeConfig); // NOT OK
1111
data = jsyaml.safeLoadAll(req.params.data, unsafeConfig); // NOT OK
12+
data = jsyaml.load(req.params.data, unsafeConfig); // NOT OK
13+
data = jsyaml.loadAll(req.params.data, unsafeConfig); // NOT OK

0 commit comments

Comments
 (0)