Skip to content

C#: Re-factor some of the existing tests. #70

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Oct 29, 2024
Merged

C#: Re-factor some of the existing tests. #70

merged 4 commits into from
Oct 29, 2024

Conversation

michaelnebel
Copy link
Collaborator

@michaelnebel michaelnebel commented Oct 28, 2024 •
edited
Loading

In this PR we

  • Normalize the Models as Data expected output (this should give rise to fewer test expected test output updates when models are updated, as the tests no longer refers to the builtin id).
  • Adding C# stubs for .NET 8 Runtime
  • Convert existing query tests to use stubs instead of dll's.
  • Fix compilation error and deprecation warning on an existing query.

Review on a commit by commit basis is recommended.

@michaelnebel michaelnebel marked this pull request as ready for review October 28, 2024 09:03
@michaelnebel michaelnebel merged commit f439fa6 into main Oct 29, 2024
12 checks passed
@michaelnebel michaelnebel deleted the csharp/refactortests branch October 29, 2024 07:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pwntester pwntester pwntester approved these changes

@GeekMasher GeekMasher Awaiting requested review from GeekMasher

@felickz felickz Awaiting requested review from felickz

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@michaelnebel @pwntester