Skip to content

Commit 2b165d5

Browse files
authored
Don't skip messaging tests in browsers that don't support messaging (firebase#1790)
1 parent 1e23e88 commit 2b165d5

14 files changed

+0
-43
lines changed

packages/messaging/test/constructor.test.ts

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -23,7 +23,6 @@ import { WindowController } from '../src/controllers/window-controller';
2323
import { ErrorCode } from '../src/models/errors';
2424

2525
import { makeFakeApp } from './testing-utils/make-fake-app';
26-
import { describe } from './testing-utils/messaging-test-runner';
2726

2827
describe('Firebase Messaging > new *Controller()', () => {
2928
it('should handle bad input', () => {

packages/messaging/test/controller-delete-token.test.ts

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -30,8 +30,6 @@ import { makeFakeApp } from './testing-utils/make-fake-app';
3030
import { makeFakeSubscription } from './testing-utils/make-fake-subscription';
3131
import { makeFakeSWReg } from './testing-utils/make-fake-sw-reg';
3232

33-
import { describe } from './testing-utils/messaging-test-runner';
34-
3533
let FAKE_SUBSCRIPTION: PushSubscription;
3634
let EXAMPLE_TOKEN_SAVE: any;
3735

packages/messaging/test/controller-get-token.test.ts

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -34,7 +34,6 @@ import { VapidDetailsModel } from '../src/models/vapid-details-model';
3434
import { makeFakeApp } from './testing-utils/make-fake-app';
3535
import { makeFakeSubscription } from './testing-utils/make-fake-subscription';
3636
import { makeFakeSWReg } from './testing-utils/make-fake-sw-reg';
37-
import { describe } from './testing-utils/messaging-test-runner';
3837

3938
const ONE_DAY = 24 * 60 * 60 * 1000;
4039

packages/messaging/test/controller-interface.test.ts

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -30,8 +30,6 @@ import { VapidDetailsModel } from '../src/models/vapid-details-model';
3030
import { makeFakeApp } from './testing-utils/make-fake-app';
3131
import { makeFakeSWReg } from './testing-utils/make-fake-sw-reg';
3232

33-
import { describe } from './testing-utils/messaging-test-runner';
34-
3533
const controllersToTest = [WindowController, SwController];
3634

3735
/**

packages/messaging/test/db-interface.test.ts

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -20,7 +20,6 @@ import { expect } from 'chai';
2020
import { DbInterface } from '../src/models/db-interface';
2121

2222
import { deleteDatabase } from './testing-utils/db-helper';
23-
import { describe } from './testing-utils/messaging-test-runner';
2423

2524
const VALUE = {
2625
key: 'key-value',

packages/messaging/test/get-sw-reg.test.ts

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -24,8 +24,6 @@ import { ErrorCode } from '../src/models/errors';
2424
import { makeFakeApp } from './testing-utils/make-fake-app';
2525
import { makeFakeSWReg } from './testing-utils/make-fake-sw-reg';
2626

27-
import { describe } from './testing-utils/messaging-test-runner';
28-
2927
const EXAMPLE_SENDER_ID = '1234567890';
3028

3129
const app = makeFakeApp({

packages/messaging/test/helpers.test.ts

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -21,8 +21,6 @@ import { arrayBufferToBase64 } from '../src/helpers/array-buffer-to-base64';
2121
import { base64ToArrayBuffer } from '../src/helpers/base64-to-array-buffer';
2222
import { isArrayBufferEqual } from '../src/helpers/is-array-buffer-equal';
2323

24-
import { describe } from './testing-utils/messaging-test-runner';
25-
2624
describe('Firebase Messaging > Helpers', () => {
2725
describe('Array Buffer - Base64 conversion', () => {
2826
it('returns expected value for p256dh example', () => {

packages/messaging/test/iid-model.test.ts

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -24,8 +24,6 @@ import { IidModel } from '../src/models/iid-model';
2424
import { makeFakeSubscription } from './testing-utils/make-fake-subscription';
2525
import { fetchMock } from './testing-utils/mock-fetch';
2626

27-
import { describe } from './testing-utils/messaging-test-runner';
28-
2927
const fcmSenderId = '1234567';
3028
const fcmToken = 'qwerty';
3129
const fcmPushSet = '7654321';

packages/messaging/test/index.test.ts

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -30,7 +30,6 @@ import { ErrorCode } from '../src/models/errors';
3030
import { SwController } from '../src/controllers/sw-controller';
3131
import { WindowController } from '../src/controllers/window-controller';
3232
import { makeFakeApp } from './testing-utils/make-fake-app';
33-
import { describe } from './testing-utils/messaging-test-runner';
3433

3534
describe('Firebase Messaging > registerMessaging', () => {
3635
let sinonSandbox: SinonSandbox;

packages/messaging/test/sw-controller.test.ts

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -34,8 +34,6 @@ import { base64ToArrayBuffer } from '../src/helpers/base64-to-array-buffer';
3434
import { DEFAULT_PUBLIC_VAPID_KEY } from '../src/models/fcm-details';
3535
import { VapidDetailsModel } from '../src/models/vapid-details-model';
3636

37-
import { describe } from './testing-utils/messaging-test-runner';
38-
3937
const VALID_VAPID_KEY =
4038
'BJzVfWqLoALJdgV20MYy6lrj0OfhmE16PI1qLIIYx2ZZL3FoQWJJL8L0rf7rS7tqd92j_3xN3fmejKK5Eb7yMYw';
4139

packages/messaging/test/testing-utils/messaging-test-runner.ts

Lines changed: 0 additions & 22 deletions
This file was deleted.

packages/messaging/test/token-details-model.test.ts

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -28,8 +28,6 @@ import { deleteDatabase } from './testing-utils/db-helper';
2828
import { compareDetails } from './testing-utils/detail-comparator';
2929
import { makeFakeSubscription } from './testing-utils/make-fake-subscription';
3030

31-
import { describe } from './testing-utils/messaging-test-runner';
32-
3331
const BAD_INPUTS: any[] = ['', [], {}, true, null, 123];
3432

3533
describe('Firebase Messaging > TokenDetailsModel', () => {

packages/messaging/test/vapid-details-model.test.ts

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -22,7 +22,6 @@ import { ErrorCode } from '../src/models/errors';
2222
import { VapidDetailsModel } from '../src/models/vapid-details-model';
2323

2424
import { deleteDatabase } from './testing-utils/db-helper';
25-
import { describe } from './testing-utils/messaging-test-runner';
2625

2726
const EXAMPLE_SCOPE = '/example-scope';
2827
const EXAMPLE_VAPID_STRING =

packages/messaging/test/window-controller.test.ts

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -27,8 +27,6 @@ import {
2727
import { base64ToArrayBuffer } from '../src/helpers/base64-to-array-buffer';
2828
import { DEFAULT_PUBLIC_VAPID_KEY } from '../src/models/fcm-details';
2929

30-
import { describe } from './testing-utils/messaging-test-runner';
31-
3230
const VALID_VAPID_KEY =
3331
'BJzVfWqLoALJdgV20MYy6lrj0OfhmE16PI1qLIIYx2ZZL3FoQWJJL8L0rf7rS7tqd92j_3xN3fmejKK5Eb7yMYw';
3432

0 commit comments

Comments
 (0)