Small cleanup

Author: JakeGinnivan

src/GitTools.Core/GitTools.Core.Shared/Diposable.cs

@@ -8,29 +8,22 @@
     /// </summary>
     public abstract class Disposable : IDisposable
     {
-        #region Fields
-        private static readonly ILog Log = LogProvider.GetCurrentClassLogger();
+        static readonly ILog Log = LogProvider.GetCurrentClassLogger();
 
-        private readonly object _syncRoot = new object();
+        readonly object _syncRoot = new object();
 
-        private bool _disposing;
-        #endregion
-
-        #region Constructors
+        bool _disposing;
+        
         /// <summary>
         /// Finalizes an instance of the <see cref="Disposable"/> class.
         /// </summary>
         ~Disposable()
         {
             Dispose(false);
         }
-        #endregion
-
-        #region Properties
-        private bool IsDisposed { get; set; }
-        #endregion
+        
+        bool IsDisposed { get; set; }
 
-        #region Methods
         /// <summary>
         /// Disposes this instance.
         /// </summary>
@@ -40,21 +33,6 @@ public void Dispose()
             GC.SuppressFinalize(this);
         }
 
-        /// <summary>
-        /// Checks whether the object is disposed. If so, it will throw the <see cref="ObjectDisposedException"/>.
-        /// </summary>
-        /// <exception cref="System.ObjectDisposedException">The object is disposed.</exception>
-        protected void CheckDisposed()
-        {
-            lock (_syncRoot)
-            {
-                if (IsDisposed)
-                {
-                    throw new ObjectDisposedException(GetType().FullName);
-                }
-            }
-        }
-
         /// <summary>
         /// Disposes the managed resources.
         /// </summary>
@@ -73,7 +51,7 @@ protected virtual void DisposeUnmanaged()
         /// Releases unmanaged and - optionally - managed resources.
         /// </summary>
         /// <param name="isDisposing"><c>true</c> to release both managed and unmanaged resources; <c>false</c> to release only unmanaged resources.</param>
-        private void Dispose(bool isDisposing)
+        void Dispose(bool isDisposing)
         {
             lock (_syncRoot)
             {
@@ -91,11 +69,6 @@ private void Dispose(bool isDisposing)
                             }
                             catch (Exception ex)
                             {
-                                //if (ex.IsCritical())
-                                //{
-                                //    throw;
-                                //}
-
                                 Log.ErrorException("Error while disposing managed resources of '{0}'.", ex, GetType().FullName);
                             }
                         }
@@ -106,11 +79,6 @@ private void Dispose(bool isDisposing)
                         }
                         catch (Exception ex)
                         {
-                            //if (ex.IsCritical())
-                            //{
-                            //    throw;
-                            //}
-
                             Log.ErrorException("Error while disposing unmanaged resources of '{0}'.", ex, GetType().FullName);
                         }
 
@@ -120,6 +88,5 @@ private void Dispose(bool isDisposing)
                 }
             }
         }
-        #endregion
     }
 }

src/GitTools.Core/GitTools.Core.Shared/Git/GitRepositoryFactory.cs

@@ -8,7 +8,7 @@
 
     public static class GitRepositoryFactory
     {
-        private static readonly ILog Log = LogProvider.GetCurrentClassLogger();
+        static readonly ILog Log = LogProvider.GetCurrentClassLogger();
 
         /// <summary>
         /// Creates the repository based on the repository info. If the <see cref="RepositoryInfo.Directory"/> points 
@@ -49,7 +49,6 @@ public static GitRepository CreateRepository(RepositoryInfo repositoryInfo, bool
             }
 
             // TODO: Should we do something with fetch for existing repositoriess?
-
             var repository = new Repository(repositoryDirectory);
             return new GitRepository(repository, isDynamicRepository);
         }