Modifying SemanticVersion.TryParse to consider TagPrefix as a constraint. No longer will consider any tag string containing a version as a candidate. Accordingly, default configuration no longer uses [vV] (some unit tests changed as a result) since most unit tests do no use the prefix.

Author: Chris Leigh

GitVersionCore.Tests/ConfigProviderTests.CanWriteOutEffectiveConfiguration.approved.txt

@@ -1,6 +1,6 @@
 assembly-versioning-scheme: MajorMinorPatch
 mode: ContinuousDelivery
-tag-prefix: '[vV]'
+tag-prefix: 
 continuous-delivery-fallback-tag: ci
 branches:
   master:

GitVersionCore.Tests/ConfigProviderTests.cs

@@ -120,7 +120,7 @@ public void CanReadDefaultDocument()
         config.AssemblyVersioningScheme.ShouldBe(AssemblyVersioningScheme.MajorMinorPatch);
         config.Branches["develop"].Tag.ShouldBe("unstable");
         config.Branches["release[/-]"].Tag.ShouldBe("beta");
-        config.TagPrefix.ShouldBe("[vV]");
+        config.TagPrefix.ShouldBe("");
         config.NextVersion.ShouldBe(null);
     }
 

GitVersionCore.Tests/Fixtures/RepositoryFixtureBase.cs

@@ -25,16 +25,23 @@ protected RepositoryFixtureBase(Func<string, IRepository> repoBuilder, Config co
     public void AssertFullSemver(string fullSemver, IRepository repository = null, string commitId = null)
     {
         Trace.WriteLine("---------");
+
+        var variables = GetVersion(repository, commitId);
+        variables.FullSemVer.ShouldBe(fullSemver);
+    }
+
+    public VersionVariables GetVersion(IRepository repository = null, string commitId = null)
+    {
         var gitVersionContext = new GitVersionContext(repository ?? Repository, configuration, IsForTrackedBranchOnly, commitId);
         var executeGitVersion = ExecuteGitVersion(gitVersionContext);
-        var variables = VariableProvider.GetVariablesFor(executeGitVersion, 
+        var variables = VariableProvider.GetVariablesFor(executeGitVersion,
             gitVersionContext.Configuration.AssemblyVersioningScheme,
-            gitVersionContext.Configuration.VersioningMode, 
+            gitVersionContext.Configuration.VersioningMode,
             gitVersionContext.Configuration.ContinuousDeploymentFallbackTag,
             gitVersionContext.IsCurrentCommitTagged);
         try
         {
-            variables.FullSemVer.ShouldBe(fullSemver);
+            return variables;
         }
         catch (Exception)
         {

GitVersionCore.Tests/GitVersionCore.Tests.csproj

@@ -145,7 +145,9 @@
     <Content Include="FodyWeavers.xml" />
     <Content Include="JsonVersionBuilderTests.Json.approved.txt" />
   </ItemGroup>
-  <ItemGroup />
+  <ItemGroup>
+    <Service Include="{82A7F48D-3B50-4B1E-B82E-3ADA8210C358}" />
+  </ItemGroup>
   <Import Project="$(MSBuildToolsPath)\Microsoft.CSharp.targets" />
   <PropertyGroup>
     <PostBuildEvent>

GitVersionCore.Tests/IntegrationTests/MasterScenarios.cs

@@ -1,6 +1,7 @@
 using GitVersion;
 using LibGit2Sharp;
 using NUnit.Framework;
+using Shouldly;
 
 [TestFixture]
 public class MasterScenarios
@@ -145,7 +146,7 @@ public void CanSpecifyTagPrefixes()
 
             fixture.AssertFullSemver("1.0.4+5");
         }
-    }
+    }    
 
     [Test]
     public void CanSpecifyTagPrefixesAsRegex()
@@ -159,4 +160,28 @@ public void CanSpecifyTagPrefixesAsRegex()
             fixture.AssertFullSemver("1.0.4+5");
         }
     }
+
+    [Test]
+    public void DoesIgnoreTagsNotAdheringToTagPrefix()
+    {
+        using (var fixture = new EmptyRepositoryFixture(new Config { TagPrefix = "" }))
+        {
+            const string TaggedVersion = "version-1.0.3";
+            fixture.Repository.MakeATaggedCommit(TaggedVersion);
+            fixture.Repository.MakeCommits(5);
+
+            var variables = fixture.GetVersion();
+            variables.FullSemVer.ShouldNotBe("1.0.4+5");
+        }
+
+        using (var fixture = new EmptyRepositoryFixture(new Config { TagPrefix = "" }))
+        {
+            const string TaggedVersion = "bad/1.0.3";
+            fixture.Repository.MakeATaggedCommit(TaggedVersion);
+            fixture.Repository.MakeCommits(5);
+
+            var variables = fixture.GetVersion();
+            variables.FullSemVer.ShouldNotBe("1.0.4+5");
+        }
+    }
 }

GitVersionCore/Configuration/Config.cs

@@ -11,7 +11,7 @@ public class Config
         public Config()
         {
             AssemblyVersioningScheme = AssemblyVersioningScheme.MajorMinorPatch;
-            TagPrefix = "[vV]";
+            TagPrefix = "";
             VersioningMode = GitVersion.VersioningMode.ContinuousDelivery;
             ContinuousDeploymentFallbackTag = "ci";
 

GitVersionCore/SemanticVersion.cs

@@ -8,7 +8,7 @@ public class SemanticVersion : IFormattable, IComparable<SemanticVersion>
         public static SemanticVersion Empty = new SemanticVersion();
 
         static Regex ParseSemVer = new Regex(
-            @"(?<SemVer>(?<Major>\d+)(\.(?<Minor>\d+))(\.(?<Patch>\d+))?)(\.(?<FourthPart>\d+))?(-(?<Tag>[^\+]*))?(\+(?<BuildMetaData>.*))?",
+            @"^(?<SemVer>(?<Major>\d+)(\.(?<Minor>\d+))(\.(?<Patch>\d+))?)(\.(?<FourthPart>\d+))?(-(?<Tag>[^\+]*))?(\+(?<BuildMetaData>.*))?$",
             RegexOptions.Compiled);
 
         public int Major;
@@ -147,7 +147,14 @@ public static SemanticVersion Parse(string version, string tagPrefixRegex)
 
         public static bool TryParse(string version, string tagPrefixRegex, out SemanticVersion semanticVersion)
         {
-            var match = Regex.Match(version, string.Format("({0})?(?<version>.*)", tagPrefixRegex));
+            var match = Regex.Match(version, string.Format("^({0})(?<version>.*)$", tagPrefixRegex));
+
+            if (!match.Success)
+            {
+                semanticVersion = null;
+                return false;
+            }
+            
             version = match.Groups["version"].Value;
             var parsed = ParseSemVer.Match(version);
 

GitVersionExe.Tests/GitVersionExe.Tests.csproj

@@ -98,6 +98,9 @@
     <Compile Include="PullRequestInTeamCityTest.cs" />
     <Compile Include="AssemblyInfoFileUpdateTests.cs" />
   </ItemGroup>
+  <ItemGroup>
+    <Service Include="{82A7F48D-3B50-4B1E-B82E-3ADA8210C358}" />
+  </ItemGroup>
   <Import Project="$(MSBuildToolsPath)\Microsoft.CSharp.targets" />
   <PropertyGroup>
     <PostBuildEvent>