Skip to content

Commit 1d254c3

Browse files
committed
#2268 Correct a version calculation for non-master mainline branches
1 parent 5138209 commit 1d254c3

File tree

2 files changed

+5
-5
lines changed

2 files changed

+5
-5
lines changed

src/GitVersionCore.Tests/IntegrationTests/MainlineDevelopmentMode.cs

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -135,7 +135,7 @@ public void SupportBranches()
135135
fixture.AssertFullSemver("1.0.2", config);
136136

137137
fixture.BranchTo("support/1.0", "support10");
138-
fixture.AssertFullSemver("1.0.3", config);
138+
fixture.AssertFullSemver("1.0.2", config);
139139

140140
// Move master on
141141
fixture.Checkout("master");
@@ -144,9 +144,9 @@ public void SupportBranches()
144144

145145
// Continue on support/1.0
146146
fixture.Checkout("support/1.0");
147+
fixture.MakeACommit(); // 1.0.3
147148
fixture.MakeACommit(); // 1.0.4
148-
fixture.MakeACommit(); // 1.0.5
149-
fixture.AssertFullSemver("1.0.5", config);
149+
fixture.AssertFullSemver("1.0.4", config);
150150
fixture.BranchTo("feature/foo", "foo");
151151
fixture.AssertFullSemver("1.0.5-foo.0", config);
152152
fixture.MakeACommit();
@@ -203,7 +203,7 @@ public void VerifySupportForwardMerge()
203203
fixture.MakeACommit();
204204
fixture.AssertFullSemver("1.1.2", config);
205205
fixture.Checkout("support/1.0");
206-
fixture.AssertFullSemver("1.0.4", config);
206+
fixture.AssertFullSemver("1.0.3", config);
207207

208208
fixture.BranchTo("feature/foo", "foo");
209209
fixture.MakeACommit();

src/GitVersionCore/VersionCalculation/MainlineVersionCalculator.cs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -69,7 +69,7 @@ public SemanticVersion FindMainlineModeVersion(BaseVersion baseVersion)
6969
mainlineVersion.BuildMetaData = CreateVersionBuildMetaData(mergeBase);
7070

7171
// branches other than master always get a bump for the act of branching
72-
if (context.CurrentBranch.FriendlyName != "master")
72+
if (!context.CurrentBranch.IsSameBranch(mainline))
7373
{
7474
var branchIncrement = FindMessageIncrement(null, context.CurrentCommit, mergeBase, mainlineCommitLog);
7575
log.Info($"Performing {branchIncrement} increment for current branch ");

0 commit comments

Comments
 (0)