Skip to content

Commit 28b1572

Browse files
committed
Merge pull request #867 from pascalberger/FixArgumentParsing2
Fix argument parsing
2 parents 6308f89 + 86bfac3 commit 28b1572

File tree

2 files changed

+9
-1
lines changed

2 files changed

+9
-1
lines changed

src/GitVersionExe.Tests/ArgumentParserTests.cs

Lines changed: 8 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -291,4 +291,12 @@ public void log_path_can_contain_forward_slash()
291291
var arguments = ArgumentParser.ParseArguments("-l /some/path");
292292
arguments.LogFilePath.ShouldBe("/some/path");
293293
}
294+
295+
[Test]
296+
public void boolean_argument_handling()
297+
{
298+
var arguments = ArgumentParser.ParseArguments("/nofetch /updateassemblyinfo true");
299+
arguments.NoFetch.ShouldBe(true);
300+
arguments.UpdateAssemblyInfo.ShouldBe(true);
301+
}
294302
}

src/GitVersionExe/ArgumentParser.cs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -393,7 +393,7 @@ static bool IsBooleanArgument(string switchName)
393393
"nofetch"
394394
};
395395

396-
return booleanArguments.Contains(switchName, StringComparer.OrdinalIgnoreCase);
396+
return booleanArguments.Contains(switchName.Substring(1), StringComparer.OrdinalIgnoreCase);
397397
}
398398
}
399399
}

0 commit comments

Comments
 (0)