Skip to content

Commit 2a5edf8

Browse files
committed
(GH-1057) Only run GitReleaseNotes if token exists
1 parent 4783d32 commit 2a5edf8

File tree

5 files changed

+32
-19
lines changed

5 files changed

+32
-19
lines changed

appveyor.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -8,7 +8,7 @@ configuration:
88
- Debug
99

1010
build_script:
11-
- ps: .\build.ps1 --githubToken=$env:GitHubToken
11+
- ps: .\build.ps1
1212

1313
test: off
1414
skip_tags: true

build.cake

Lines changed: 17 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -122,14 +122,22 @@ Task("Create-Release-Notes")
122122
.IsDependentOn("Build")
123123
.Does(() =>
124124
{
125-
var githubToken = Argument<string>("githubToken");
126-
var releaseNotesExitCode = StartProcess(
127-
@"tools\GitReleaseNotes\tools\gitreleasenotes.exe",
128-
new ProcessSettings { Arguments = ". /o build/releasenotes.md /repoToken " + githubToken });
129-
if (string.IsNullOrEmpty(System.IO.File.ReadAllText("./build/releasenotes.md")))
130-
System.IO.File.WriteAllText("./build/releasenotes.md", "No issues closed since last release");
131-
132-
if (releaseNotesExitCode != 0) throw new Exception("Failed to generate release notes");
125+
var githubToken = EnvironmentVariable("GitHubToken");
126+
127+
if(!string.IsNullOrWhiteSpace(githubToken))
128+
{
129+
var releaseNotesExitCode = StartProcess(
130+
@"tools\GitReleaseNotes\tools\gitreleasenotes.exe",
131+
new ProcessSettings { Arguments = ". /o build/releasenotes.md /repoToken " + githubToken });
132+
if (string.IsNullOrEmpty(System.IO.File.ReadAllText("./build/releasenotes.md")))
133+
System.IO.File.WriteAllText("./build/releasenotes.md", "No issues closed since last release");
134+
135+
if (releaseNotesExitCode != 0) throw new Exception("Failed to generate release notes");
136+
}
137+
else
138+
{
139+
Information("Create-Release-Notes is being skipped, as GitHub Token is not present.");
140+
}
133141
});
134142

135143
Task("Package")
@@ -141,7 +149,7 @@ Task("Upload-AppVeyor-Artifacts")
141149
.WithCriteria(() => AppVeyor.IsRunningOnAppVeyor)
142150
.Does(() =>
143151
{
144-
var gem = string.IsNullOrEmpty(preReleaseTag) ?
152+
var gem = string.IsNullOrEmpty(preReleaseTag) ?
145153
"gitversion-" + version + ".gem" :
146154
"gitversion-" + version + "." + preReleaseTag + ".gem";
147155

src/GitVersionCore/AssemblyInfo.cs

Lines changed: 5 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,11 +1,13 @@
1-
using System.Reflection;
1+
using System.Reflection;
22
using System.Runtime.CompilerServices;
33

44
[assembly: AssemblyTitle("GitVersionCore")]
55
[assembly: AssemblyProduct("GitVersion")]
6-
[assembly: AssemblyVersion("1.0.0")]
7-
[assembly: AssemblyFileVersion("1.0.0")]
6+
[assembly: AssemblyVersion("4.0.0.0")]
7+
[assembly: AssemblyFileVersion("4.0.0.0")]
88
[assembly: InternalsVisibleTo("GitVersionTask.Tests")]
99
[assembly: InternalsVisibleTo("GitVersion")]
1010
[assembly: InternalsVisibleTo("GitVersionCore.Tests")]
1111
[assembly: InternalsVisibleTo("GitVersionExe.Tests")]
12+
13+
[assembly: AssemblyInformationalVersion("4.0.0-GH-1057.1+1126.Branch.feature/GH-1057.Sha.4783d325521463cd6cf1b61074352da84451f25d")]

src/GitVersionExe/AssemblyInfo.cs

Lines changed: 5 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,10 +1,12 @@
1-
using System.Reflection;
1+
using System.Reflection;
22
using System.Runtime.CompilerServices;
33

44
[assembly: AssemblyTitle("GitVersion")]
55
[assembly: AssemblyProduct("GitVersion")]
6-
[assembly: AssemblyVersion("1.0.0")]
7-
[assembly: AssemblyFileVersion("1.0.0")]
6+
[assembly: AssemblyVersion("4.0.0.0")]
7+
[assembly: AssemblyFileVersion("4.0.0.0")]
88
[assembly: InternalsVisibleTo("GitVersionTask.Tests")]
99
[assembly: InternalsVisibleTo("AcceptanceTests")]
1010
[assembly: InternalsVisibleTo("GitVersionExe.Tests")]
11+
12+
[assembly: AssemblyInformationalVersion("4.0.0-GH-1057.1+1126.Branch.feature/GH-1057.Sha.4783d325521463cd6cf1b61074352da84451f25d")]

src/GitVersionTask/AssemblyInfo.cs

Lines changed: 4 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,7 @@
1-
using System.Reflection;
1+
using System.Reflection;
22

33
[assembly: AssemblyTitle("GitVersionTask")]
44
[assembly: AssemblyProduct("GitVersionTask")]
5-
[assembly: AssemblyVersion("1.0.0")]
6-
[assembly: AssemblyFileVersion("1.0.0")]
5+
[assembly: AssemblyVersion("4.0.0.0")]
6+
[assembly: AssemblyFileVersion("4.0.0.0")]
7+
[assembly: AssemblyInformationalVersion("4.0.0-GH-1057.1+1126.Branch.feature/GH-1057.Sha.4783d325521463cd6cf1b61074352da84451f25d")]

0 commit comments

Comments
 (0)