remove redundant code

Author: SimonCropp

GitVersionCore/BuildServers/AppVeyor.cs

@@ -65,7 +65,7 @@ public override string[] GenerateSetParameterMessage(string name, string value)
 
             return new[]
             {
-                string.Format("Adding Environment Variable. name='GitVersion.{0}' value='{1}']", name, value),
+                string.Format("Adding Environment Variable. name='GitVersion.{0}' value='{1}']", name, value)
             };
         }
     }

GitVersionCore/GitFlow/BranchFinders/VersionOnMasterFinder.cs

@@ -18,8 +18,6 @@ public VersionPoint Execute(GitVersionContext context, DateTimeOffset olderThan)
                         {
                             Major = shortVersion.Major,
                             Minor = shortVersion.Minor,
-                            Timestamp = commit.When(),
-                            CommitSha = commit.Sha,
                         };
                     }
                 }
@@ -31,17 +29,13 @@ public VersionPoint Execute(GitVersionContext context, DateTimeOffset olderThan)
                     {
                         Major = shortVersionFromMergeMessage.Major,
                         Minor = shortVersionFromMergeMessage.Minor,
-                        Timestamp = commit.When(),
-                        CommitSha = commit.Sha,
                     };
                 }
             }
             return new VersionPoint
             {
                 Major = 0,
                 Minor = 1,
-                Timestamp = DateTimeOffset.MinValue,
-                CommitSha = null,
             };
         }
 

GitVersionCore/GitHubFlow/OtherBranchVersionFinder.cs

@@ -18,9 +18,7 @@ public SemanticVersion FindVersion(GitVersionContext context)
             }
         }
 
-        protected SemanticVersion FindVersion(
-            GitVersionContext context,
-            string baseBranchName)
+        SemanticVersion FindVersion(GitVersionContext context, string baseBranchName)
         {
             var versionString = GetUnknownBranchSuffix(context.CurrentBranch);
             if (!versionString.Contains("."))

GitVersionCore/GitVersionFinder.cs

@@ -26,7 +26,8 @@ public static SemanticVersion GetSemanticVersion(Repository repository)
             Logger.WriteInfo("Running against branch: " + gitVersionContext.CurrentBranch.Name);
             return versionForRepositoryFinder.FindVersion(gitVersionContext);
         }
-        public static bool ShouldGitHubFlowVersioningSchemeApply(IRepository repo)
+
+        static bool ShouldGitHubFlowVersioningSchemeApply(IRepository repo)
         {
             return repo.FindBranch("develop") == null;
         }

GitVersionCore/VersionPoint.cs

@@ -1,12 +1,8 @@
 namespace GitVersion
 {
-    using System;
-
     class VersionPoint
     {
         public int Major;
         public int Minor;
-        public DateTimeOffset Timestamp;
-        public string CommitSha;
     }
 }

GitVersionTask.Tests/UpdateAssemblyInfoTests.cs

@@ -124,7 +124,7 @@ public void SetUp()
     }
 
     [TearDown]
-    public void TearDown()
+    public new void TearDown()
     {
         BuildServerList.ResetSelector();
     }