Skip to content

Commit 2d83b11

Browse files
committed
Merge pull request #295 from dtabuenc/fix-pre-release-sorting
Fix problem in sorting pre-release-tags
2 parents d76ab77 + 86db7f8 commit 2d83b11

File tree

2 files changed

+3
-1
lines changed

2 files changed

+3
-1
lines changed

GitVersionCore.Tests/SemanticVersionTests.cs

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -65,6 +65,8 @@ public void LegacySemVerTest()
6565
public void VersionSorting()
6666
{
6767
SemanticVersion.Parse("1.0.0").ShouldBeGreaterThan(SemanticVersion.Parse("1.0.0-beta"));
68+
SemanticVersion.Parse("1.0.0-beta.2").ShouldBeGreaterThan(SemanticVersion.Parse("1.0.0-beta.1"));
69+
SemanticVersion.Parse("1.0.0-beta.1").ShouldBeLessThan(SemanticVersion.Parse("1.0.0-beta.2"));
6870
}
6971

7072
[Test]

GitVersionCore/SemanticVersionPreReleaseTag.cs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -106,7 +106,7 @@ public int CompareTo(SemanticVersionPreReleaseTag other)
106106
return -1;
107107
}
108108

109-
var nameComparison = StringComparer.InvariantCultureIgnoreCase.Compare(Name, other);
109+
var nameComparison = StringComparer.InvariantCultureIgnoreCase.Compare(Name, other.Name);
110110
if (nameComparison != 0)
111111
return nameComparison;
112112

0 commit comments

Comments
 (0)