(build) changed condition for publish tasks

Author: arturcic

.azurepipelines/publish.yml

@@ -16,7 +16,6 @@ steps:
     CHOCOLATEY_API_URL: $(CHOCOLATEY_API_URL)
     RUBY_GEM_API_KEY: $(RUBY_GEM_API_KEY)
     ENABLED_PUBLISH_GEM: $(ENABLED_PUBLISH_GEM)
-    ENABLED_PUBLISH_TFS: $(ENABLED_PUBLISH_TFS)
     ENABLED_PUBLISH_NUGET: $(ENABLED_PUBLISH_NUGET)
     ENABLED_PUBLISH_CHOCOLATEY: $(ENABLED_PUBLISH_CHOCOLATEY)
     DOTNET_ROLL_FORWARD_ON_NO_CANDIDATE_FX: 2

build.cake

@@ -38,7 +38,7 @@
 #load "./build/artifacts-test.cake"
 #load "./build/docker-build.cake"
 #load "./build/publish.cake"
-#load "./build/wyam.cake"
+#load "./build/docs.cake"
 
 using Xunit;
 using System.Diagnostics;

build/artifacts-test.cake

@@ -1,16 +1,16 @@
 singleStageRun = !IsEnabled(Context, "ENABLED_MULTI_STAGE_BUILD", false);
 
 Task("Artifacts-Prepare")
-.WithCriteria<BuildParameters>((context, parameters) => !parameters.IsRunningOnMacOS,        "Artifacts-Prepare can be tested only on Windows or Linux agents.")
-    .WithCriteria<BuildParameters>((context, parameters) => parameters.IsCiSupportingDocker, "Artifacts-Prepare works only on AzurePipeline.")
+.WithCriteria<BuildParameters>((context, parameters) => !parameters.IsRunningOnMacOS, "Artifacts-Prepare can be tested only on Windows or Linux agents.")
+    .WithCriteria<BuildParameters>((context, parameters) => parameters.IsReleasingCI, "Artifacts-Prepare works only on Releasing CI.")
     .IsDependentOnWhen("Pack-Nuget", singleStageRun)
     .Does<BuildParameters>((parameters) =>
 {
 });
 
 Task("Artifacts-DotnetTool-Test")
-    .WithCriteria<BuildParameters>((context, parameters) => !parameters.IsRunningOnMacOS,    "Artifacts-DotnetTool-Test can be tested only on Windows or Linux agents.")
-    .WithCriteria<BuildParameters>((context, parameters) => parameters.IsCiSupportingDocker, "Artifacts-DotnetTool-Test works only on AzurePipeline.")
+    .WithCriteria<BuildParameters>((context, parameters) => !parameters.IsRunningOnMacOS, "Artifacts-DotnetTool-Test can be tested only on Windows or Linux agents.")
+    .WithCriteria<BuildParameters>((context, parameters) => parameters.IsReleasingCI,     "Artifacts-DotnetTool-Test works only on Releasing CI.")
     .IsDependentOn("Artifacts-Prepare")
     .Does<BuildParameters>((parameters) =>
 {
@@ -29,8 +29,8 @@ Task("Artifacts-DotnetTool-Test")
 });
 
 Task("Artifacts-MsBuild-Test")
-    .WithCriteria<BuildParameters>((context, parameters) => !parameters.IsRunningOnMacOS,    "Artifacts-MsBuild-Test can be tested only on Windows or Linux agents.")
-    .WithCriteria<BuildParameters>((context, parameters) => parameters.IsCiSupportingDocker, "Artifacts-MsBuild-Test works only on AzurePipeline.")
+    .WithCriteria<BuildParameters>((context, parameters) => !parameters.IsRunningOnMacOS, "Artifacts-MsBuild-Test can be tested only on Windows or Linux agents.")
+    .WithCriteria<BuildParameters>((context, parameters) => parameters.IsReleasingCI,     "Artifacts-MsBuild-Test works only on Releasing CI.")
     .IsDependentOn("Artifacts-Prepare")
     .Does<BuildParameters>((parameters) =>
 {
@@ -50,7 +50,7 @@ Task("Artifacts-MsBuild-Test")
 });
 
 Task("Artifacts-Test")
-    .WithCriteria<BuildParameters>((context, parameters) => !parameters.IsRunningOnMacOS,    "Artifacts-Test can be tested only on Windows or Linux agents.")
-    .WithCriteria<BuildParameters>((context, parameters) => parameters.IsCiSupportingDocker, "Artifacts-Test works only on AzurePipeline.")
+    .WithCriteria<BuildParameters>((context, parameters) => !parameters.IsRunningOnMacOS, "Artifacts-Test can be tested only on Windows or Linux agents.")
+    .WithCriteria<BuildParameters>((context, parameters) => parameters.IsReleasingCI,     "Artifacts-Test works only on Releasing CI.")
     .IsDependentOn("Artifacts-DotnetTool-Test")
     .IsDependentOn("Artifacts-MsBuild-Test");

build/docker-build.cake

@@ -1,8 +1,8 @@
 singleStageRun = !IsEnabled(Context, "ENABLED_MULTI_STAGE_BUILD", false);
 
 Task("Docker-Build")
-    .WithCriteria<BuildParameters>((context, parameters) => !parameters.IsRunningOnMacOS,    "Docker can be built only on Windows or Linux agents.")
-    .WithCriteria<BuildParameters>((context, parameters) => parameters.IsCiSupportingDocker, "Docker-Build works only on AzurePipeline.")
+    .WithCriteria<BuildParameters>((context, parameters) => !parameters.IsRunningOnMacOS, "Docker can be built only on Windows or Linux agents.")
+    .WithCriteria<BuildParameters>((context, parameters) => parameters.IsReleasingCI,     "Docker-Build works only on Releasing CI.")
     .IsDependentOnWhen("Pack-Prepare", singleStageRun)
     .Does<BuildParameters>((parameters) =>
 {
@@ -13,8 +13,8 @@ Task("Docker-Build")
 });
 
 Task("Docker-Test")
-    .WithCriteria<BuildParameters>((context, parameters) => !parameters.IsRunningOnMacOS,    "Docker can be tested only on Windows or Linux agents.")
-    .WithCriteria<BuildParameters>((context, parameters) => parameters.IsCiSupportingDocker, "Docker-Test works only on AzurePipeline.")
+    .WithCriteria<BuildParameters>((context, parameters) => !parameters.IsRunningOnMacOS, "Docker can be tested only on Windows or Linux agents.")
+    .WithCriteria<BuildParameters>((context, parameters) => parameters.IsReleasingCI,     "Docker-Test works only on Releasing CI.")
     .IsDependentOn("Docker-Build")
     .Does<BuildParameters>((parameters) =>
 {
@@ -33,7 +33,7 @@ Task("Docker-Test")
 Task("Docker-Publish")
     .WithCriteria<BuildParameters>((context, parameters) => parameters.EnabledPublishDocker, "Docker-Publish was disabled.")
     .WithCriteria<BuildParameters>((context, parameters) => !parameters.IsRunningOnMacOS,    "Docker-Publish works only on Windows and Linux agents.")
-    .WithCriteria<BuildParameters>((context, parameters) => parameters.IsCiSupportingDocker, "Docker-Publish works only on AzurePipeline.")
+    .WithCriteria<BuildParameters>((context, parameters) => parameters.IsReleasingCI,        "Docker-Publish works only on Releasing CI.")
     .WithCriteria<BuildParameters>((context, parameters) => parameters.IsStableRelease() || parameters.IsPreRelease(), "Docker-Publish works only for releases.")
     .IsDependentOn("Docker-Test")
     .Does<BuildParameters>((parameters) =>

build/wyam.cake renamed to build/docs.cake

@@ -55,8 +55,8 @@ Task("Force-Publish-Documentation")
 Task("Publish-Documentation-Internal")
     .IsDependentOn("Clean-Documentation")
     .WithCriteria(() => DirectoryExists(MakeAbsolute(Directory("docs"))), "Wyam documentation directory is missing")
-    .WithCriteria<BuildParameters>((context, parameters) => parameters.IsRunningOnWindows,       "Publish-Documentation is ran only on Windows agents.")
-    .WithCriteria<BuildParameters>((context, parameters) => parameters.IsRunningOnAzurePipeline, "Publish-Documentation is ran only on AzurePipeline.")
+    .WithCriteria<BuildParameters>((context, parameters) => parameters.IsRunningOnWindows, "Publish-Documentation is ran only on Windows agents.")
+    .WithCriteria<BuildParameters>((context, parameters) => parameters.IsReleasingCI,      "Publish-Documentation is ran only on Releasing CI.")
     .WithCriteria<BuildParameters>((context, parameters) => parameters.IsStableRelease() || parameters.IsPreRelease(), "Publish-Documentation works only for non-PR commits.")
     .Does<BuildParameters>((parameters) =>
 {

build/publish.cake

@@ -3,9 +3,9 @@ singleStageRun = !IsEnabled(Context, "ENABLED_MULTI_STAGE_BUILD", false);
 #region Publish
 
 Task("Release-Notes")
-    .WithCriteria<BuildParameters>((context, parameters) => parameters.IsRunningOnWindows,       "Release notes are generated only on Windows agents.")
-    .WithCriteria<BuildParameters>((context, parameters) => parameters.IsRunningOnAzurePipeline, "Release notes are generated only on AzurePipeline.")
-    .WithCriteria<BuildParameters>((context, parameters) => parameters.IsStableRelease(),        "Release notes are generated only for stable releases.")
+    .WithCriteria<BuildParameters>((context, parameters) => parameters.IsRunningOnWindows, "Release notes are generated only on Windows agents.")
+    .WithCriteria<BuildParameters>((context, parameters) => parameters.IsReleasingCI,      "Release notes are generated only on Releasing CI.")
+    .WithCriteria<BuildParameters>((context, parameters) => parameters.IsStableRelease(),  "Release notes are generated only for stable releases.")
     .Does<BuildParameters>((parameters) =>
 {
     var token = parameters.Credentials.GitHub.Token;
@@ -32,7 +32,6 @@ Task("Release-Notes")
     Error(exception.Dump());
 });
 
-
 Task("Publish-AppVeyor")
     .WithCriteria<BuildParameters>((context, parameters) => parameters.IsRunningOnWindows,  "Publish-AppVeyor works only on Windows agents.")
     .WithCriteria<BuildParameters>((context, parameters) => parameters.IsRunningOnAppVeyor, "Publish-AppVeyor works only on AppVeyor.")
@@ -58,9 +57,9 @@ Task("Publish-AppVeyor")
 });
 
 Task("Publish-AzurePipeline")
-    .WithCriteria<BuildParameters>((context, parameters) => parameters.IsRunningOnWindows,       "Publish-AzurePipeline works only on Windows agents.")
-    .WithCriteria<BuildParameters>((context, parameters) => parameters.IsRunningOnAzurePipeline, "Publish-AzurePipeline works only on AzurePipeline.")
-    .WithCriteria<BuildParameters>((context, parameters) => !parameters.IsPullRequest,           "Publish-AzurePipeline works only for non-PR commits.")
+    .WithCriteria<BuildParameters>((context, parameters) => parameters.IsRunningOnWindows, "Publish-AzurePipeline works only on Windows agents.")
+    .WithCriteria<BuildParameters>((context, parameters) => parameters.IsReleasingCI,      "Publish-AzurePipeline works only on Releasing CI.")
+    .WithCriteria<BuildParameters>((context, parameters) => !parameters.IsPullRequest,     "Publish-AzurePipeline works only for non-PR commits.")
     .IsDependentOnWhen("UnitTest", singleStageRun)
     .IsDependentOnWhen("Pack", singleStageRun)
     .Does<BuildParameters>((parameters) =>
@@ -82,9 +81,9 @@ Task("Publish-AzurePipeline")
 });
 
 Task("Publish-Gem-Internal")
-    .WithCriteria<BuildParameters>((context, parameters) => parameters.EnabledPublishGem,        "Publish-Gem was disabled.")
-    .WithCriteria<BuildParameters>((context, parameters) => parameters.IsRunningOnWindows,       "Publish-Gem works only on Windows agents.")
-    .WithCriteria<BuildParameters>((context, parameters) => parameters.IsRunningOnAzurePipeline, "Publish-Gem works only on AzurePipeline.")
+    .WithCriteria<BuildParameters>((context, parameters) => parameters.EnabledPublishGem,  "Publish-Gem was disabled.")
+    .WithCriteria<BuildParameters>((context, parameters) => parameters.IsRunningOnWindows, "Publish-Gem works only on Windows agents.")
+    .WithCriteria<BuildParameters>((context, parameters) => parameters.IsReleasingCI,      "Publish-Gem works only on Releasing CI.")
     .WithCriteria<BuildParameters>((context, parameters) => parameters.IsStableRelease() || parameters.IsPreRelease(), "Publish-Gem works only for releases.")
     .IsDependentOnWhen("Pack-Gem", singleStageRun)
     .Does<BuildParameters>((parameters) =>
@@ -110,9 +109,9 @@ Task("Publish-Gem-Internal")
 });
 
 Task("Publish-NuGet-Internal")
-    .WithCriteria<BuildParameters>((context, parameters) => parameters.EnabledPublishNuget,      "Publish-NuGet was disabled.")
-    .WithCriteria<BuildParameters>((context, parameters) => parameters.IsRunningOnWindows,       "Publish-NuGet works only on Windows agents.")
-    .WithCriteria<BuildParameters>((context, parameters) => parameters.IsRunningOnAzurePipeline, "Publish-NuGet works only on AzurePipeline.")
+    .WithCriteria<BuildParameters>((context, parameters) => parameters.EnabledPublishNuget, "Publish-NuGet was disabled.")
+    .WithCriteria<BuildParameters>((context, parameters) => parameters.IsRunningOnWindows,  "Publish-NuGet works only on Windows agents.")
+    .WithCriteria<BuildParameters>((context, parameters) => parameters.IsReleasingCI,       "Publish-NuGet works only on Releasing CI.")
     .WithCriteria<BuildParameters>((context, parameters) => parameters.IsStableRelease() || parameters.IsPreRelease(), "Publish-NuGet works only for releases.")
     .IsDependentOnWhen("Pack-NuGet", singleStageRun)
     .Does<BuildParameters>((parameters) =>
@@ -150,7 +149,7 @@ Task("Publish-NuGet-Internal")
 Task("Publish-Chocolatey-Internal")
     .WithCriteria<BuildParameters>((context, parameters) => parameters.EnabledPublishChocolatey, "Publish-Chocolatey was disabled.")
     .WithCriteria<BuildParameters>((context, parameters) => parameters.IsRunningOnWindows,       "Publish-Chocolatey works only on Windows agents.")
-    .WithCriteria<BuildParameters>((context, parameters) => parameters.IsRunningOnAzurePipeline, "Publish-Chocolatey works only on AzurePipeline.")
+    .WithCriteria<BuildParameters>((context, parameters) => parameters.IsReleasingCI,            "Publish-Chocolatey works only on Releasing CI.")
     .WithCriteria<BuildParameters>((context, parameters) => parameters.IsStableRelease() || parameters.IsPreRelease(), "Publish-Chocolatey works only for releases.")
     .IsDependentOnWhen("Pack-Chocolatey", singleStageRun)
     .Does<BuildParameters>((parameters) =>

build/test.cake

@@ -78,8 +78,8 @@ Task("UnitTest")
 });
 
 Task("Publish-Coverage")
-    .WithCriteria<BuildParameters>((context, parameters) => parameters.IsRunningOnWindows,       "Publish-Coverage works only on Windows agents.")
-    .WithCriteria<BuildParameters>((context, parameters) => parameters.IsRunningOnAzurePipeline, "Publish-Coverage works only on AzurePipeline.")
+    .WithCriteria<BuildParameters>((context, parameters) => parameters.IsRunningOnWindows, "Publish-Coverage works only on Windows agents.")
+    .WithCriteria<BuildParameters>((context, parameters) => parameters.IsReleasingCI,      "Publish-Coverage works only on Releasing CI.")
     .WithCriteria<BuildParameters>((context, parameters) => parameters.IsStableRelease() || parameters.IsPreRelease(), "Publish-Coverage works only for releases.")
     .IsDependentOn("UnitTest")
     .Does<BuildParameters>((parameters) =>

build/utils/parameters.cake

@@ -36,7 +36,8 @@ public class BuildParameters
     public bool IsRunningOnAppVeyor { get; private set; }
     public bool IsRunningOnTravis { get; private set; }
     public bool IsRunningOnAzurePipeline { get; private set; }
-    public bool IsCiSupportingDocker { get; private set; }
+
+    public bool IsReleasingCI { get; private set; }
 
     public bool IsMainRepo { get; private set; }
     public bool IsMainBranch { get; private set; }
@@ -94,7 +95,7 @@ public class BuildParameters
             IsRunningOnTravis        = buildSystem.IsRunningOnTravisCI,
             IsRunningOnAzurePipeline = buildSystem.IsRunningOnAzurePipelines || buildSystem.IsRunningOnAzurePipelinesHosted,
 
-            IsCiSupportingDocker = buildSystem.IsRunningOnAzurePipelines || buildSystem.IsRunningOnAzurePipelinesHosted,
+            IsReleasingCI = buildSystem.IsRunningOnAzurePipelines || buildSystem.IsRunningOnAzurePipelinesHosted,
 
             IsDockerForWindows = dockerCliPlatform == "windows",
             IsDockerForLinux   = dockerCliPlatform == "linux",