Skip to content

Commit 460fe24

Browse files
committed
Added extension methods for true and false comparison
1 parent e02dfa7 commit 460fe24

File tree

3 files changed

+44
-6
lines changed

3 files changed

+44
-6
lines changed

src/GitVersionExe/ArgumentParser.cs

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -172,11 +172,11 @@ public static Arguments ParseArguments(List<string> commandLineArguments)
172172

173173
if (IsSwitch("updateAssemblyInfo", name))
174174
{
175-
if (new[] { "1", "true" }.Contains(value, StringComparer.OrdinalIgnoreCase))
175+
if (value.IsTrue())
176176
{
177177
arguments.UpdateAssemblyInfo = true;
178178
}
179-
else if (new[] { "0", "false" }.Contains(value, StringComparer.OrdinalIgnoreCase))
179+
else if (value.IsFalse())
180180
{
181181
arguments.UpdateAssemblyInfo = false;
182182
}
@@ -230,11 +230,11 @@ public static Arguments ParseArguments(List<string> commandLineArguments)
230230

231231
if (IsSwitch("showConfig", name))
232232
{
233-
if (new[] { "1", "true" }.Contains(value, StringComparer.OrdinalIgnoreCase))
233+
if (value.IsTrue())
234234
{
235235
arguments.ShowConfig = true;
236236
}
237-
else if (new[] { "0", "false" }.Contains(value, StringComparer.OrdinalIgnoreCase))
237+
else if (value.IsFalse())
238238
{
239239
arguments.UpdateAssemblyInfo = false;
240240
}
@@ -265,11 +265,11 @@ public static Arguments ParseArguments(List<string> commandLineArguments)
265265

266266
if (IsSwitch("ensureassemblyinfo", name))
267267
{
268-
if (new[] { "1", "true" }.Contains(value, StringComparer.OrdinalIgnoreCase))
268+
if (value.IsTrue())
269269
{
270270
arguments.EnsureAssemblyInfo = true;
271271
}
272-
else if (new[] { "0", "false" }.Contains(value, StringComparer.OrdinalIgnoreCase))
272+
else if (value.IsFalse())
273273
{
274274
arguments.EnsureAssemblyInfo = false;
275275
}

src/GitVersionExe/Extensions.cs

Lines changed: 37 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,37 @@
1+
namespace GitVersion
2+
{
3+
using System;
4+
using System.Linq;
5+
6+
public static class Extensions
7+
{
8+
private static string[] trues;
9+
private static string[] falses;
10+
11+
12+
static Extensions()
13+
{
14+
trues = new[]
15+
{
16+
"1",
17+
"true"
18+
};
19+
20+
falses = new[]
21+
{
22+
"0",
23+
"false"
24+
};
25+
}
26+
27+
public static bool IsTrue(this string value)
28+
{
29+
return trues.Contains(value, StringComparer.OrdinalIgnoreCase);
30+
}
31+
32+
public static bool IsFalse(this string value)
33+
{
34+
return falses.Contains(value, StringComparer.OrdinalIgnoreCase);
35+
}
36+
}
37+
}

src/GitVersionExe/GitVersionExe.csproj

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -65,6 +65,7 @@
6565
<ItemGroup>
6666
<Compile Include="ArgumentParser.cs" />
6767
<Compile Include="Arguments.cs" />
68+
<Compile Include="Extensions.cs" />
6869
<Compile Include="HelpWriter.cs" />
6970
<Compile Include="Program.cs" />
7071
<Compile Include="AssemblyInfo.cs" />

0 commit comments

Comments
 (0)