silently skip non-commit tags

cyanite · arturcic · commit 50217820dee8 · 2019-12-10T18:06:41.000+02:00
Instead of crashing.
diff --git a/src/GitVersionCore/GitRepoMetadataProvider.cs b/src/GitVersionCore/GitRepoMetadataProvider.cs
@@ -35,7 +35,7 @@ public IEnumerable<Tuple<Tag, SemanticVersion>> GetValidVersionTags(IRepository
 
             foreach (var tag in repository.Tags)
             {
-                if (olderThan.HasValue && ((Commit)tag.PeeledTarget()).When() > olderThan.Value)
+                if (!(tag.PeeledTarget() is Commit commit) || (olderThan.HasValue && commit.When() > olderThan.Value))
                     continue;
 
                 if (SemanticVersion.TryParse(tag.FriendlyName, tagPrefixRegex, out var semver))

Original file line number	Diff line number	Diff line change
`@@ -35,7 +35,7 @@ public IEnumerable<Tuple<Tag, SemanticVersion>> GetValidVersionTags(IRepository`
`35`	`35`
`36`	`36`	`foreach (var tag in repository.Tags)`
`37`	`37`	`{`
`38`		`- if (olderThan.HasValue && ((Commit)tag.PeeledTarget()).When() > olderThan.Value)`
	`38`	`+ if (!(tag.PeeledTarget() is Commit commit) \|\| (olderThan.HasValue && commit.When() > olderThan.Value))`
`39`	`39`	`continue;`
`40`	`40`
`41`	`41`	`if (SemanticVersion.TryParse(tag.FriendlyName, tagPrefixRegex, out var semver))`