Skip to content

Commit 615d669

Browse files
author
Oren Novotny
committed
be more robust and handle empty strings the same as null
1 parent 224044d commit 615d669

File tree

1 file changed

+2
-2
lines changed

1 file changed

+2
-2
lines changed

src/GitVersionExe/AssemblyInfoFileUpdate.cs

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -26,7 +26,7 @@ public AssemblyInfoFileUpdate(Arguments args, string workingDirectory, VersionVa
2626

2727
var assemblyVersion = variables.AssemblySemVer;
2828
var assemblyVersionRegex = new Regex(@"AssemblyVersion\s*\(\s*""[^""]*""\s*\)");
29-
var assemblyVersionString = assemblyVersion != null ? string.Format("AssemblyVersion(\"{0}\")", assemblyVersion) : null;
29+
var assemblyVersionString = !string.IsNullOrWhiteSpace(assemblyVersion) ? string.Format("AssemblyVersion(\"{0}\")", assemblyVersion) : null;
3030
var assemblyInfoVersion = variables.InformationalVersion;
3131
var assemblyInfoVersionRegex = new Regex(@"AssemblyInformationalVersion\s*\(\s*""[^""]*""\s*\)");
3232
var assemblyInfoVersionString = string.Format("AssemblyInformationalVersion(\"{0}\")", assemblyInfoVersion);
@@ -48,7 +48,7 @@ public AssemblyInfoFileUpdate(Arguments args, string workingDirectory, VersionVa
4848
cleanupBackupTasks.Add(() => fileSystem.Delete(backupAssemblyInfo));
4949

5050
var fileContents = fileSystem.ReadAllText(assemblyInfoFile.FullName);
51-
if (assemblyVersion != null)
51+
if (!string.IsNullOrWhiteSpace(assemblyVersion))
5252
{
5353
fileContents = ReplaceOrAppend(assemblyVersionRegex, fileContents, assemblyVersionString, assemblyInfoFile.Extension);
5454
}

0 commit comments

Comments
 (0)