Merge branch 'master' into fix/remove-json-output-formatter

Author: arturcic

src/GitVersionCore.Tests/GitToolsTestingExtensions.cs

@@ -80,7 +80,7 @@ public static void InitializeRepo(this RemoteRepositoryFixture fixture)
         {
             var arguments = new Arguments
             {
-                Authentication = new AuthenticationInfo(),
+                Authentication = new Authentication(),
                 TargetPath = fixture.LocalRepositoryFixture.RepositoryPath
             };
             var options = Options.Create(arguments);

src/GitVersionCore/Arguments.cs

@@ -7,7 +7,7 @@ namespace GitVersion
 {
     public class Arguments
     {
-        public AuthenticationInfo Authentication;
+        public Authentication Authentication;
 
         public Config OverrideConfig;
         public bool HasOverrideConfig;

src/GitVersionCore/Authentication.cs

@@ -0,0 +1,8 @@
+namespace GitVersion
+{
+    public class Authentication
+    {
+        public string Username;
+        public string Password;
+    }
+}

src/GitVersionExe/ArgumentParser.cs

@@ -123,15 +123,15 @@ public Arguments ParseArguments(string[] commandLineArguments)
                 if (name.IsSwitch("u"))
                 {
                     EnsureArgumentValueCount(values);
-                    if (arguments.Authentication == null) arguments.Authentication = new AuthenticationInfo();
+                    if (arguments.Authentication == null) arguments.Authentication = new Authentication();
                     arguments.Authentication.Username = value;
                     continue;
                 }
 
                 if (name.IsSwitch("p"))
                 {
                     EnsureArgumentValueCount(values);
-                    if (arguments.Authentication == null) arguments.Authentication = new AuthenticationInfo();
+                    if (arguments.Authentication == null) arguments.Authentication = new Authentication();
                     arguments.Authentication.Password = value;
                     continue;
                 }
@@ -413,14 +413,14 @@ private void AddAuthentication(Arguments arguments)
             var username = environment.GetEnvironmentVariable("GITVERSION_REMOTE_USERNAME");
             if (!string.IsNullOrWhiteSpace(username))
             {
-                if (arguments.Authentication == null) arguments.Authentication = new AuthenticationInfo();
+                if (arguments.Authentication == null) arguments.Authentication = new Authentication();
                 arguments.Authentication.Username = username;
             }
 
             var password = environment.GetEnvironmentVariable("GITVERSION_REMOTE_PASSWORD");
             if (!string.IsNullOrWhiteSpace(password))
             {
-                if (arguments.Authentication == null) arguments.Authentication = new AuthenticationInfo();
+                if (arguments.Authentication == null) arguments.Authentication = new Authentication();
                 arguments.Authentication.Username = password;
             }
         }