add concept of short version

SimonCropp · SimonCropp · commit 75b0872ecf78 · 2014-09-30T13:48:48.000+10:00
diff --git a/GitVersionCore.Tests/ShortVersionParserTests.cs b/GitVersionCore.Tests/ShortVersionParserTests.cs
@@ -8,66 +8,59 @@ public class ShortVersionParserTests
     [Test]
     public void Major_minor_patch()
     {
-        int minor;
-        int major;
-        int patch;
-        ShortVersionParser.Parse("1.2.3", out major,out minor,out patch);
-        Assert.AreEqual(1, major);
-        Assert.AreEqual(2, minor);
-        Assert.AreEqual(3, patch);
+        ShortVersion shortVersion;
+        ShortVersionParser.Parse("1.2.3", out shortVersion);
+        Assert.AreEqual(1, shortVersion.Major);
+        Assert.AreEqual(2, shortVersion.Minor);
+        Assert.AreEqual(3, shortVersion.Patch);
     }
 
     [Test]
     public void Major_minor_patchTry()
     {
-        int minor;
-        int major;
-        int patch;
-        var result = ShortVersionParser.TryParse("1.2.3", out major,out minor,out patch);
+        ShortVersion shortVersion;
+        var result = ShortVersionParser.TryParse("1.2.3", out shortVersion);
         Assert.IsTrue(result);
-        Assert.AreEqual(1, major);
-        Assert.AreEqual(2, minor);
-        Assert.AreEqual(3, patch);
+        Assert.AreEqual(1, shortVersion.Major);
+        Assert.AreEqual(2, shortVersion.Minor);
+        Assert.AreEqual(3, shortVersion.Patch);
     }
 
     [Test]
     public void Major_minor_missingPatch()
     {
-        int minor;
-        int major;
-        int patch;
-        var result = ShortVersionParser.TryParse("1.2", out major, out minor, out patch);
+        ShortVersion shortVersion;
+        var result = ShortVersionParser.TryParse("1.2", out shortVersion);
 
         Assert.IsTrue(result);
-        Assert.AreEqual(1, major);
-        Assert.AreEqual(2, minor);
-        Assert.AreEqual(0, patch);
+        Assert.AreEqual(1, shortVersion.Major);
+        Assert.AreEqual(2, shortVersion.Minor);
+        Assert.AreEqual(0, shortVersion.Patch);
     }
 
     [Test]
     public void Major_minorTry()
     {
-        int minor;
-        int major;
-        var result = ShortVersionParser.TryParseMajorMinor("1.2.3", out major, out minor);
+        ShortVersion shortVersion;
+        var result = ShortVersionParser.TryParseMajorMinor("1.2.3", out shortVersion);
         Assert.IsFalse(result);
 
-        result = ShortVersionParser.TryParseMajorMinor("1.2.0-alpha1", out major, out minor);
+        result = ShortVersionParser.TryParseMajorMinor("1.2.0-alpha1", out shortVersion);
         Assert.IsFalse(result);
 
-        result = ShortVersionParser.TryParseMajorMinor("1.2.0.0", out major, out minor);
+        result = ShortVersionParser.TryParseMajorMinor("1.2.0.0", out shortVersion);
         Assert.IsFalse(result);
 
-        result = ShortVersionParser.TryParseMajorMinor("1.2.0.1", out major, out minor);
+        result = ShortVersionParser.TryParseMajorMinor("1.2.0.1", out shortVersion);
         Assert.IsFalse(result);
 
-        result = ShortVersionParser.TryParseMajorMinor("1.2", out major, out minor);
+        result = ShortVersionParser.TryParseMajorMinor("1.2", out shortVersion);
         Assert.IsTrue(result);
 
-        result = ShortVersionParser.TryParseMajorMinor("1.2.0", out major, out minor);
+        result = ShortVersionParser.TryParseMajorMinor("1.2.0", out shortVersion);
         Assert.IsTrue(result);
 
-        Assert.AreEqual(1, major);
-        Assert.AreEqual(2, minor);
+        Assert.AreEqual(1, shortVersion.Major);
+        Assert.AreEqual(2, shortVersion.Minor);
     }
 }
diff --git a/GitVersionCore/GitFlow/BranchFinders/MasterVersionFinder.cs b/GitVersionCore/GitFlow/BranchFinders/MasterVersionFinder.cs
@@ -6,14 +6,12 @@ class MasterVersionFinder
     {
         public SemanticVersion FindVersion(IRepository repository, Commit tip)
         {
-            int major;
-            int minor;
-            int patch;
             foreach (var tag in repository.TagsByDate(tip))
             {
-                if (ShortVersionParser.TryParse(tag.Name, out major, out minor, out patch))
+            ShortVersion shortVersion;
+            if (ShortVersionParser.TryParse(tag.Name, out shortVersion))
                 {
-                    return BuildVersion(repository, tip, major, minor, patch);
+                    return BuildVersion(repository, tip, shortVersion);
                 }
             }
 
@@ -22,9 +20,10 @@ public SemanticVersion FindVersion(IRepository repository, Commit tip)
             string versionString;
             if (MergeMessageParser.TryParse(tip, out versionString))
             {
-                if (ShortVersionParser.TryParse(versionString, out major, out minor, out patch))
+                ShortVersion shortVersion;
+                if (ShortVersionParser.TryParse(versionString, out shortVersion))
                 {
-                    semanticVersion = BuildVersion(repository, tip, major, minor, patch);
+                    semanticVersion = BuildVersion(repository, tip, shortVersion);
                 }
             }
 
@@ -36,14 +35,14 @@ public SemanticVersion FindVersion(IRepository repository, Commit tip)
             return semanticVersion;
         }
 
-        SemanticVersion BuildVersion(IRepository repository, Commit tip, int major, int minor, int patch)
+        SemanticVersion BuildVersion(IRepository repository, Commit tip, ShortVersion shortVersion)
         {
-            var releaseDate = ReleaseDateFinder.Execute(repository, tip.Sha, patch);
+            var releaseDate = ReleaseDateFinder.Execute(repository, tip.Sha, shortVersion.Patch);
             return new SemanticVersion
             {
-                Major = major,
-                Minor = minor,
-                Patch = patch,
+                Major = shortVersion.Major,
+                Minor = shortVersion.Minor,
+                Patch = shortVersion.Patch,
                 BuildMetaData = new SemanticVersionBuildMetaData(null, "master", releaseDate)
             };
         }
diff --git a/GitVersionCore/GitFlow/BranchFinders/SupportVersionFinder.cs b/GitVersionCore/GitFlow/BranchFinders/SupportVersionFinder.cs
@@ -6,14 +6,12 @@ class SupportVersionFinder
     {
         public SemanticVersion FindVersion(IRepository repository, Commit tip)
         {
-            int major;
-            int minor;
-            int patch;
             foreach (var tag in repository.TagsByDate(tip))
             {
-                if (ShortVersionParser.TryParse(tag.Name, out major, out minor, out patch))
+            ShortVersion shortVersion;
+            if (ShortVersionParser.TryParse(tag.Name, out shortVersion))
                 {
-                    return BuildVersion(repository, tip, major, minor, patch);
+                    return BuildVersion(repository, tip, shortVersion);
                 }
             }
 
@@ -22,9 +20,10 @@ public SemanticVersion FindVersion(IRepository repository, Commit tip)
             string versionString;
             if (MergeMessageParser.TryParse(tip, out versionString))
             {
-                if (ShortVersionParser.TryParse(versionString, out major, out minor, out patch))
+                ShortVersion shortVersion;
+                if (ShortVersionParser.TryParse(versionString, out shortVersion))
                 {
-                    semanticVersion = BuildVersion(repository, tip, major, minor, patch);
+                    semanticVersion = BuildVersion(repository, tip, shortVersion);
                 }
             }
 
@@ -38,14 +37,14 @@ public SemanticVersion FindVersion(IRepository repository, Commit tip)
             return semanticVersion;
         }
 
-        SemanticVersion BuildVersion(IRepository repository, Commit tip, int major, int minor, int patch)
+        SemanticVersion BuildVersion(IRepository repository, Commit tip, ShortVersion shortVersion)
         {
-            var releaseDate = ReleaseDateFinder.Execute(repository, tip.Sha, patch);
+            var releaseDate = ReleaseDateFinder.Execute(repository, tip.Sha, shortVersion.Patch);
             return new SemanticVersion
             {
-                Major = major,
-                Minor = minor,
-                Patch = patch,
+                Major = shortVersion.Major,
+                Minor = shortVersion.Minor,
+                Patch = shortVersion.Patch,
                 BuildMetaData = new SemanticVersionBuildMetaData(null, "support", releaseDate)
             };
         } 
diff --git a/GitVersionCore/GitHubFlow/MergedBranchesWithVersionFinder.cs b/GitVersionCore/GitHubFlow/MergedBranchesWithVersionFinder.cs
@@ -19,6 +19,15 @@ public SemanticVersion GetVersion()
 
         SemanticVersion GetVersion(GitVersionContext context)
         {
+
+            foreach (var commit in context.CurrentBranch.Commits)
+            {
+                string versionPart;
+                if (MergeMessageParser.TryParse(commit, out versionPart))
+                {
+                    
+                }
+            }
             return context.CurrentBranch.Commits.Where(c =>
                 {
                     string versionPart;
diff --git a/GitVersionCore/GitVersionCore.csproj b/GitVersionCore/GitVersionCore.csproj
@@ -65,6 +65,7 @@
     <Compile Include="BuildServers\TeamCity.cs" />
     <Compile Include="CachedVersion.cs" />
     <Compile Include="DirectoryDateFinder.cs" />
+    <Compile Include="ShortVersion.cs" />
     <Compile Include="SemanticVersionExtensions.cs" />
     <Compile Include="WarningException.cs" />
     <Compile Include="ExtensionMethods.cs" />
diff --git a/GitVersionCore/MergeMessageParser.cs b/GitVersionCore/MergeMessageParser.cs
@@ -8,7 +8,11 @@ static class MergeMessageParser
     {
         public static bool TryParse(Commit mergeCommit, out string versionPart)
         {
+            return Inner(mergeCommit, out versionPart);
+        }
 
+        static bool Inner(Commit mergeCommit, out string versionPart)
+        {
             if (mergeCommit.Parents.Count() < 2)
             {
                 versionPart = null;
@@ -55,21 +59,24 @@ public static bool TryParse(Commit mergeCommit, out string versionPart)
 
             if (message.StartsWith("Merge pull request #"))
             {
-                var split = message.Split(new[] { "/" },StringSplitOptions.RemoveEmptyEntries);
+                var split = message.Split(new[]
+                {
+                    "/"
+                }, StringSplitOptions.RemoveEmptyEntries);
                 if (split.Length != 2)
                 {
                     versionPart = null;
                     return false;
                 }
                 return split[1].TryGetSuffix(out versionPart, "-");
             }
-            
+
             if (message.StartsWith("Finish Release-")) //Match Syntevo SmartGit client's GitFlow 'release' merge commit message formatting
             {
                 versionPart = message.Replace("Finish Release-", "");
                 return true;
             }
-            
+
             if (message.StartsWith("Finish ")) //Match Syntevo SmartGit client's GitFlow 'hotfix' merge commit message formatting
             {
                 versionPart = message.Replace("Finish ", "");
diff --git a/GitVersionCore/ShortVersion.cs b/GitVersionCore/ShortVersion.cs
@@ -0,0 +1,10 @@
+namespace GitVersion
+{
+
+    class ShortVersion 
+    {
+        public int Major;
+        public int Minor;
+        public int Patch;
+    }
+}
diff --git a/GitVersionCore/ShortVersionParser.cs b/GitVersionCore/ShortVersionParser.cs
@@ -2,64 +2,61 @@ namespace GitVersion
 {
     using System;
 
-    //TODO Replace with SemVer class
-    public class ShortVersionParser
+    class ShortVersionParser
     {
-        public static void Parse(string versionString, out int major, out int minor, out int patch)
+        public static void Parse(string versionString, out ShortVersion shortVersion)
         {
-            if (!TryParse(versionString, out major, out minor, out patch))
+            if (!TryParse(versionString, out shortVersion))
             {
-                Throw(versionString);
+                throw new Exception(string.Format("Could not parse version from '{0}' expected 'major.minor.patch'", versionString));
             }
         }
 
-        public static bool TryParseMajorMinor(string versionString, out int major, out int minor)
+        public static bool TryParseMajorMinor(string versionString, out ShortVersion shortVersion)
         {
-            int patch;
-
-            if (!TryParse(versionString, out major, out minor, out patch))
+            if (!TryParse(versionString, out shortVersion))
             {
                 return false;
             }
 
             // Note: during scanning of master we only want the last major / minor, not the patch, so patch must be zero
-            return patch == 0;
+            return shortVersion.Patch == 0;
         }
 
-        public static bool TryParse(string versionString, out int major, out int minor, out int patch)
+        public static bool TryParse(string versionString, out ShortVersion shortVersion)
         {
-            major = 0;
-            minor = 0;
-            patch = 0;
+            var major = 0;
+            var minor = 0;
+            var patch = 0;
             var strings = versionString.Split('.');
             if (strings.Length < 2 || strings.Length > 3)
             {
+                shortVersion = null;
                 return false;
             }
             if (!int.TryParse(strings[0], out major))
             {
+                shortVersion = null;
                 return false;
             }
 
             if (!int.TryParse(strings[1], out minor))
             {
+                shortVersion = null;
                 return false;
             }
 
             if (strings.Length == 3)
             {
                 if (!int.TryParse(strings[2], out patch))
                 {
+                    shortVersion = null;
                     return false;
                 }
             }
 
+            shortVersion = new ShortVersion{Major = major,Minor = minor,Patch = patch};
             return true;
         }
-
-        static void Throw(string versionString)
-        {
-            throw new Exception(string.Format("Could not parse version from '{0}' expected 'major.minor.patch'", versionString));
-        }
     }
 }
diff --git a/GitVersionCore/VersionOnMasterFinder.cs b/GitVersionCore/VersionOnMasterFinder.cs

Original file line number	Diff line number	Diff line change
`@@ -6,14 +6,12 @@ class MasterVersionFinder`
`6`	`6`	`{`
`7`	`7`	`public SemanticVersion FindVersion(IRepository repository, Commit tip)`
`8`	`8`	`{`
`9`		`- int major;`
`10`		`- int minor;`
`11`		`- int patch;`
`12`	`9`	`foreach (var tag in repository.TagsByDate(tip))`
`13`	`10`	`{`
`14`		`- if (ShortVersionParser.TryParse(tag.Name, out major, out minor, out patch))`
	`11`	`+ ShortVersion shortVersion;`
	`12`	`+ if (ShortVersionParser.TryParse(tag.Name, out shortVersion))`
`15`	`13`	`{`
`16`		`- return BuildVersion(repository, tip, major, minor, patch);`
	`14`	`+ return BuildVersion(repository, tip, shortVersion);`
`17`	`15`	`}`
`18`	`16`	`}`
`19`	`17`
`@@ -22,9 +20,10 @@ public SemanticVersion FindVersion(IRepository repository, Commit tip)`
`22`	`20`	`string versionString;`
`23`	`21`	`if (MergeMessageParser.TryParse(tip, out versionString))`
`24`	`22`	`{`
`25`		`- if (ShortVersionParser.TryParse(versionString, out major, out minor, out patch))`
	`23`	`+ ShortVersion shortVersion;`
	`24`	`+ if (ShortVersionParser.TryParse(versionString, out shortVersion))`
`26`	`25`	`{`
`27`		`- semanticVersion = BuildVersion(repository, tip, major, minor, patch);`
	`26`	`+ semanticVersion = BuildVersion(repository, tip, shortVersion);`
`28`	`27`	`}`
`29`	`28`	`}`
`30`	`29`
`@@ -36,14 +35,14 @@ public SemanticVersion FindVersion(IRepository repository, Commit tip)`
`36`	`35`	`return semanticVersion;`
`37`	`36`	`}`
`38`	`37`
`39`		`- SemanticVersion BuildVersion(IRepository repository, Commit tip, int major, int minor, int patch)`
	`38`	`+ SemanticVersion BuildVersion(IRepository repository, Commit tip, ShortVersion shortVersion)`
`40`	`39`	`{`
`41`		`- var releaseDate = ReleaseDateFinder.Execute(repository, tip.Sha, patch);`
	`40`	`+ var releaseDate = ReleaseDateFinder.Execute(repository, tip.Sha, shortVersion.Patch);`
`42`	`41`	`return new SemanticVersion`
`43`	`42`	`{`
`44`		`- Major = major,`
`45`		`- Minor = minor,`
`46`		`- Patch = patch,`
	`43`	`+ Major = shortVersion.Major,`
	`44`	`+ Minor = shortVersion.Minor,`
	`45`	`+ Patch = shortVersion.Patch,`
`47`	`46`	`BuildMetaData = new SemanticVersionBuildMetaData(null, "master", releaseDate)`
`48`	`47`	`};`
`49`	`48`	`}`
Original file line number	Diff line number	Diff line change
`@@ -6,14 +6,12 @@ class SupportVersionFinder`
`6`	`6`	`{`
`7`	`7`	`public SemanticVersion FindVersion(IRepository repository, Commit tip)`
`8`	`8`	`{`
`9`		`- int major;`
`10`		`- int minor;`
`11`		`- int patch;`
`12`	`9`	`foreach (var tag in repository.TagsByDate(tip))`
`13`	`10`	`{`
`14`		`- if (ShortVersionParser.TryParse(tag.Name, out major, out minor, out patch))`
	`11`	`+ ShortVersion shortVersion;`
	`12`	`+ if (ShortVersionParser.TryParse(tag.Name, out shortVersion))`
`15`	`13`	`{`
`16`		`- return BuildVersion(repository, tip, major, minor, patch);`
	`14`	`+ return BuildVersion(repository, tip, shortVersion);`
`17`	`15`	`}`
`18`	`16`	`}`
`19`	`17`
`@@ -22,9 +20,10 @@ public SemanticVersion FindVersion(IRepository repository, Commit tip)`
`22`	`20`	`string versionString;`
`23`	`21`	`if (MergeMessageParser.TryParse(tip, out versionString))`
`24`	`22`	`{`
`25`		`- if (ShortVersionParser.TryParse(versionString, out major, out minor, out patch))`
	`23`	`+ ShortVersion shortVersion;`
	`24`	`+ if (ShortVersionParser.TryParse(versionString, out shortVersion))`
`26`	`25`	`{`
`27`		`- semanticVersion = BuildVersion(repository, tip, major, minor, patch);`
	`26`	`+ semanticVersion = BuildVersion(repository, tip, shortVersion);`
`28`	`27`	`}`
`29`	`28`	`}`
`30`	`29`
`@@ -38,14 +37,14 @@ public SemanticVersion FindVersion(IRepository repository, Commit tip)`
`38`	`37`	`return semanticVersion;`
`39`	`38`	`}`
`40`	`39`
`41`		`- SemanticVersion BuildVersion(IRepository repository, Commit tip, int major, int minor, int patch)`
	`40`	`+ SemanticVersion BuildVersion(IRepository repository, Commit tip, ShortVersion shortVersion)`
`42`	`41`	`{`
`43`		`- var releaseDate = ReleaseDateFinder.Execute(repository, tip.Sha, patch);`
	`42`	`+ var releaseDate = ReleaseDateFinder.Execute(repository, tip.Sha, shortVersion.Patch);`
`44`	`43`	`return new SemanticVersion`
`45`	`44`	`{`
`46`		`- Major = major,`
`47`		`- Minor = minor,`
`48`		`- Patch = patch,`
	`45`	`+ Major = shortVersion.Major,`
	`46`	`+ Minor = shortVersion.Minor,`
	`47`	`+ Patch = shortVersion.Patch,`
`49`	`48`	`BuildMetaData = new SemanticVersionBuildMetaData(null, "support", releaseDate)`
`50`	`49`	`};`
`51`	`50`	`}`
Original file line number	Diff line number	Diff line change
`@@ -8,7 +8,11 @@ static class MergeMessageParser`
`8`	`8`	`{`
`9`	`9`	`public static bool TryParse(Commit mergeCommit, out string versionPart)`
`10`	`10`	`{`
	`11`	`+ return Inner(mergeCommit, out versionPart);`
	`12`	`+ }`
`11`	`13`
	`14`	`+ static bool Inner(Commit mergeCommit, out string versionPart)`
	`15`	`+ {`
`12`	`16`	`if (mergeCommit.Parents.Count() < 2)`
`13`	`17`	`{`
`14`	`18`	`versionPart = null;`
`@@ -55,21 +59,24 @@ public static bool TryParse(Commit mergeCommit, out string versionPart)`
`55`	`59`
`56`	`60`	`if (message.StartsWith("Merge pull request #"))`
`57`	`61`	`{`
`58`		`- var split = message.Split(new[] { "/" },StringSplitOptions.RemoveEmptyEntries);`
	`62`	`+ var split = message.Split(new[]`
	`63`	`+ {`
	`64`	`+ "/"`
	`65`	`+ }, StringSplitOptions.RemoveEmptyEntries);`
`59`	`66`	`if (split.Length != 2)`
`60`	`67`	`{`
`61`	`68`	`versionPart = null;`
`62`	`69`	`return false;`
`63`	`70`	`}`
`64`	`71`	`return split[1].TryGetSuffix(out versionPart, "-");`
`65`	`72`	`}`
`66`		`-`
	`73`	`+`
`67`	`74`	`if (message.StartsWith("Finish Release-")) //Match Syntevo SmartGit client's GitFlow 'release' merge commit message formatting`
`68`	`75`	`{`
`69`	`76`	`versionPart = message.Replace("Finish Release-", "");`
`70`	`77`	`return true;`
`71`	`78`	`}`
`72`		`-`
	`79`	`+`
`73`	`80`	`if (message.StartsWith("Finish ")) //Match Syntevo SmartGit client's GitFlow 'hotfix' merge commit message formatting`
`74`	`81`	`{`
`75`	`82`	`versionPart = message.Replace("Finish ", "");`
Original file line number	Diff line number	Diff line change
`@@ -2,64 +2,61 @@ namespace GitVersion`
`2`	`2`	`{`
`3`	`3`	`using System;`
`4`	`4`
`5`		`- //TODO Replace with SemVer class`
`6`		`- public class ShortVersionParser`
	`5`	`+ class ShortVersionParser`
`7`	`6`	`{`
`8`		`- public static void Parse(string versionString, out int major, out int minor, out int patch)`
	`7`	`+ public static void Parse(string versionString, out ShortVersion shortVersion)`
`9`	`8`	`{`
`10`		`- if (!TryParse(versionString, out major, out minor, out patch))`
	`9`	`+ if (!TryParse(versionString, out shortVersion))`
`11`	`10`	`{`
`12`		`- Throw(versionString);`
	`11`	`+ throw new Exception(string.Format("Could not parse version from '{0}' expected 'major.minor.patch'", versionString));`
`13`	`12`	`}`
`14`	`13`	`}`
`15`	`14`
`16`		`- public static bool TryParseMajorMinor(string versionString, out int major, out int minor)`
	`15`	`+ public static bool TryParseMajorMinor(string versionString, out ShortVersion shortVersion)`
`17`	`16`	`{`
`18`		`- int patch;`
`19`		`-`
`20`		`- if (!TryParse(versionString, out major, out minor, out patch))`
	`17`	`+ if (!TryParse(versionString, out shortVersion))`
`21`	`18`	`{`
`22`	`19`	`return false;`
`23`	`20`	`}`
`24`	`21`
`25`	`22`	`// Note: during scanning of master we only want the last major / minor, not the patch, so patch must be zero`
`26`		`- return patch == 0;`
	`23`	`+ return shortVersion.Patch == 0;`
`27`	`24`	`}`
`28`	`25`
`29`		`- public static bool TryParse(string versionString, out int major, out int minor, out int patch)`
	`26`	`+ public static bool TryParse(string versionString, out ShortVersion shortVersion)`
`30`	`27`	`{`
`31`		`- major = 0;`
`32`		`- minor = 0;`
`33`		`- patch = 0;`
	`28`	`+ var major = 0;`
	`29`	`+ var minor = 0;`
	`30`	`+ var patch = 0;`
`34`	`31`	`var strings = versionString.Split('.');`
`35`	`32`	`if (strings.Length < 2 \|\| strings.Length > 3)`
`36`	`33`	`{`
	`34`	`+ shortVersion = null;`
`37`	`35`	`return false;`
`38`	`36`	`}`
`39`	`37`	`if (!int.TryParse(strings[0], out major))`
`40`	`38`	`{`
	`39`	`+ shortVersion = null;`
`41`	`40`	`return false;`
`42`	`41`	`}`
`43`	`42`
`44`	`43`	`if (!int.TryParse(strings[1], out minor))`
`45`	`44`	`{`
	`45`	`+ shortVersion = null;`
`46`	`46`	`return false;`
`47`	`47`	`}`
`48`	`48`
`49`	`49`	`if (strings.Length == 3)`
`50`	`50`	`{`
`51`	`51`	`if (!int.TryParse(strings[2], out patch))`
`52`	`52`	`{`
	`53`	`+ shortVersion = null;`
`53`	`54`	`return false;`
`54`	`55`	`}`
`55`	`56`	`}`
`56`	`57`
	`58`	`+ shortVersion = new ShortVersion{Major = major,Minor = minor,Patch = patch};`
`57`	`59`	`return true;`
`58`	`60`	`}`
`59`		`-`
`60`		`- static void Throw(string versionString)`
`61`		`- {`
`62`		`- throw new Exception(string.Format("Could not parse version from '{0}' expected 'major.minor.patch'", versionString));`
`63`		`- }`
`64`	`61`	`}`
`65`	`62`	`}`