Ensure TemplateManager always ignores file extension case

bording · bording · commit 9e5b32777b79 · 2017-10-07T17:02:00.000-04:00
diff --git a/src/GitVersionCore/TemplateManager.cs b/src/GitVersionCore/TemplateManager.cs
@@ -19,8 +19,8 @@ class TemplateManager
 
         public TemplateManager(TemplateType templateType)
         {
-            templates = GetEmbeddedTemplates(templateType, "Templates").ToDictionary(k => Path.GetExtension(k), v => v);
-            addFormats = GetEmbeddedTemplates(templateType, "AddFormats").ToDictionary(k => Path.GetExtension(k), v => v);
+            templates = GetEmbeddedTemplates(templateType, "Templates").ToDictionary(k => Path.GetExtension(k), v => v, StringComparer.OrdinalIgnoreCase);
+            addFormats = GetEmbeddedTemplates(templateType, "AddFormats").ToDictionary(k => Path.GetExtension(k), v => v, StringComparer.OrdinalIgnoreCase);
         }
 
         public string GetTemplateFor(string fileExtension)
@@ -56,7 +56,7 @@ public bool IsSupported(string fileExtension)
                 throw new ArgumentNullException(nameof(fileExtension));
             }
 
-            return addFormats.Keys.Contains(fileExtension, StringComparer.OrdinalIgnoreCase);
+            return templates.ContainsKey(fileExtension);
         }
 
         static IEnumerable<string> GetEmbeddedTemplates(TemplateType templateType, string templateCategory)

Original file line number	Diff line number	Diff line change
`@@ -19,8 +19,8 @@ class TemplateManager`
`19`	`19`
`20`	`20`	`public TemplateManager(TemplateType templateType)`
`21`	`21`	`{`
`22`		`- templates = GetEmbeddedTemplates(templateType, "Templates").ToDictionary(k => Path.GetExtension(k), v => v);`
`23`		`- addFormats = GetEmbeddedTemplates(templateType, "AddFormats").ToDictionary(k => Path.GetExtension(k), v => v);`
	`22`	`+ templates = GetEmbeddedTemplates(templateType, "Templates").ToDictionary(k => Path.GetExtension(k), v => v, StringComparer.OrdinalIgnoreCase);`
	`23`	`+ addFormats = GetEmbeddedTemplates(templateType, "AddFormats").ToDictionary(k => Path.GetExtension(k), v => v, StringComparer.OrdinalIgnoreCase);`
`24`	`24`	`}`
`25`	`25`
`26`	`26`	`public string GetTemplateFor(string fileExtension)`
`@@ -56,7 +56,7 @@ public bool IsSupported(string fileExtension)`
`56`	`56`	`throw new ArgumentNullException(nameof(fileExtension));`
`57`	`57`	`}`
`58`	`58`
`59`		`- return addFormats.Keys.Contains(fileExtension, StringComparer.OrdinalIgnoreCase);`
	`59`	`+ return templates.ContainsKey(fileExtension);`
`60`	`60`	`}`
`61`	`61`
`62`	`62`	`static IEnumerable<string> GetEmbeddedTemplates(TemplateType templateType, string templateCategory)`