Introduce Boolean properties to know if a logger level is enabled

It is inspired from Common.Logging ILog.IsDebugEnabled
See https://github.com/net-commons/common-logging/blob/master/src/Common.Logging.Core/Logging/ILog.cs#L637
If avoid doing an unnecessary String.Format()

Author: tomap

src/GitVersionCore.Tests/ModuleInitializer.cs

@@ -11,7 +11,7 @@ public static class ModuleInitializer
     /// </summary>
     public static void Initialize()
     {
-        Logger.SetLoggers(
+        Logger.SetLoggers(VerbosityLevel.Debug,
             s => Console.WriteLine(s),
             s => Console.WriteLine(s),
             s => Console.WriteLine(s),

src/GitVersionCore/Logger.cs

@@ -14,13 +14,19 @@ static Logger()
             Reset();
         }
 
+        public static bool IsDebugEnabled;
+        public static bool IsInfoEnabled;
+        public static bool IsWarningEnabled;
+        public static bool IsErrorEnabled;
+
         public static Action<string> WriteDebug { get; private set; }
         public static Action<string> WriteInfo { get; private set; }
         public static Action<string> WriteWarning { get; private set; }
         public static Action<string> WriteError { get; private set; }
 
         public static IDisposable IndentLog(string operationDescription)
         {
+            if (!IsInfoEnabled) return new ActionDisposable(() => { });
             var start = DateTime.Now;
             WriteInfo("Begin: " + operationDescription);
             indent = indent + "  ";
@@ -41,17 +47,47 @@ static Action<string> ObscurePassword(Action<string> info)
             return logAction;
         }
 
-        public static void SetLoggers(Action<string> debug, Action<string> info, Action<string> warn, Action<string> error)
+        public static void SetLoggers(VerbosityLevel verbosity, Action<string> debug, Action<string> info, Action<string> warn, Action<string> error)
         {
-            if (debug == null) throw new ArgumentNullException("debug");
-            if (info == null) throw new ArgumentNullException("info");
-            if (warn == null) throw new ArgumentNullException("warn");
-            if (error == null) throw new ArgumentNullException("error");
-
-            WriteDebug = LogMessage(ObscurePassword(debug), "DEBUG");
-            WriteInfo = LogMessage(ObscurePassword(info), "INFO");
-            WriteWarning = LogMessage(ObscurePassword(warn), "WARN");
-            WriteError = LogMessage(ObscurePassword(error), "ERROR");
+            if (verbosity >= VerbosityLevel.Debug)
+            {
+                if (debug == null) throw new ArgumentNullException("debug");
+                IsDebugEnabled = true;
+                WriteDebug = LogMessage(ObscurePassword(debug), "DEBUG");
+            }
+            else {
+                WriteDebug = (m) => { };
+            }
+            if (verbosity >= VerbosityLevel.Info)
+            {
+                if (info == null) throw new ArgumentNullException("Info");
+                IsInfoEnabled = true;
+                WriteInfo = LogMessage(ObscurePassword(info), "INFO");
+            }
+            else
+            {
+                WriteInfo = (m) => { };
+            }
+            if (verbosity >= VerbosityLevel.Warn)
+            {
+                if (warn == null) throw new ArgumentNullException("Warn");
+                IsWarningEnabled = true;
+                WriteWarning = LogMessage(ObscurePassword(warn), "WARN");
+            }
+            else
+            {
+                WriteWarning = (m) => { };
+            }
+            if (verbosity >= VerbosityLevel.Error)
+            {
+                if (error == null) throw new ArgumentNullException("Error");
+                IsErrorEnabled = true;
+                WriteError = LogMessage(ObscurePassword(error), "ERROR");
+            }
+            else
+            {
+                WriteError = (m) => { };
+            }
         }
 
         public static IDisposable AddLoggersTemporarily(Action<string> debug, Action<string> info, Action<string> warn, Action<string> error)
@@ -60,7 +96,7 @@ public static IDisposable AddLoggersTemporarily(Action<string> debug, Action<str
             var currentInfo = WriteInfo;
             var currentWarn = WriteWarning;
             var currentError = WriteError;
-            SetLoggers(s =>
+            SetLoggers(VerbosityLevel.Debug, s =>
             {
                 debug(s);
                 currentDebug(s);

src/GitVersionExe/Program.cs

@@ -81,7 +81,7 @@ static int VerifyArgumentsAndRun()
                 }
                 else
                 {
-                    Logger.WriteInfo("Working directory: " + arguments.TargetPath);
+                    if (Logger.IsInfoEnabled) Logger.WriteInfo("Working directory: " + arguments.TargetPath);
                 }
                 VerifyConfiguration(arguments, fileSystem);
 
@@ -179,11 +179,11 @@ static void ConfigureLogging(Arguments arguments)
                 }
             }
 
-            Logger.SetLoggers(
-                s => writeActions.ForEach(a => { if (arguments.Verbosity >= VerbosityLevel.Debug) a(s); }),
-                s => writeActions.ForEach(a => { if (arguments.Verbosity >= VerbosityLevel.Info) a(s); }),
-                s => writeActions.ForEach(a => { if (arguments.Verbosity >= VerbosityLevel.Warn) a(s); }),
-                s => writeActions.ForEach(a => { if (arguments.Verbosity >= VerbosityLevel.Error) a(s); }));
+            Logger.SetLoggers(arguments.Verbosity, 
+                s => writeActions.ForEach(a => { a(s); }),
+                s => writeActions.ForEach(a => { a(s); }),
+                s => writeActions.ForEach(a => { a(s); }),
+                s => writeActions.ForEach(a => { a(s); }));
 
             if (exception != null)
                 Logger.WriteError(string.Format("Failed to configure logging for '{0}': {1}", arguments.LogFilePath, exception.Message));

src/GitVersionTask.Tests/ModuleInitializer.cs

@@ -10,7 +10,7 @@ public static class ModuleInitializer
     /// </summary>
     public static void Initialize()
     {
-        Logger.SetLoggers(
+        Logger.SetLoggers(VerbosityLevel.Debug,
             s => System.Console.WriteLine(s),
             s => System.Console.WriteLine(s),
             s => System.Console.WriteLine(s),

src/GitVersionTask/AssemblyInfoBuilder/UpdateAssemblyInfo.cs

@@ -20,7 +20,7 @@ public UpdateAssemblyInfo()
             {
             };
             logger = new TaskLogger(this);
-            Logger.SetLoggers(this.LogDebug, this.LogInfo, this.LogWarning, s => this.LogError(s));
+            Logger.SetLoggers(VerbosityLevel.Debug, this.LogDebug, this.LogInfo, this.LogWarning, s => this.LogError(s));
         }
 
         [Required]

src/GitVersionTask/GetVersion.cs

@@ -13,7 +13,7 @@ public class GetVersion : GitVersionTaskBase
         public GetVersion()
         {
             logger = new TaskLogger(this);
-            Logger.SetLoggers(this.LogDebug, this.LogInfo, this.LogWarning, s => this.LogError(s));
+            Logger.SetLoggers(VerbosityLevel.Debug, this.LogDebug, this.LogInfo, this.LogWarning, s => this.LogError(s));
         }
 
         [Required]

src/GitVersionTask/WriteVersionInfoToBuildLog.cs

@@ -15,7 +15,7 @@ public class WriteVersionInfoToBuildLog : GitVersionTaskBase
         public WriteVersionInfoToBuildLog()
         {
             logger = new TaskLogger(this);
-            Logger.SetLoggers(this.LogDebug, this.LogInfo, this.LogWarning, s => this.LogError(s));
+            Logger.SetLoggers(VerbosityLevel.Debug, this.LogDebug, this.LogInfo, this.LogWarning, s => this.LogError(s));
         }
 
         [Required]