Skip to content

Commit b327f75

Browse files
committed
Merge pull request #459 from JakeGinnivan/FurtherDocFixes
Fixing comments from previous PR review
2 parents 27f953e + d64f3b5 commit b327f75

10 files changed

+12
-17
lines changed

Docs/configurationOptions.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1 +1 @@
1-
# Confiuration options
1+
# Configuration options

Docs/index.md

Lines changed: 1 addition & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -4,11 +4,6 @@ GitVersion is a tool to help you achieve Semantic Versioning on your project.
44
This influences many of the decisions GitVersion has made, please read and understand this page as it will help you start using GitVersion effectively!
55

66
## Assumptions/Rules
7-
### You tag releases when you release, not before
8-
GitVersion assumes that tags are used to *tag a release* and not used to build a release.
9-
10-
This means that the version is calculated pre-emptively, if you currently tag, build then release that tag then GitVersion will probably not work for you.
11-
127
### Tags override other rules
138
If a commit is tagged, then GitVersion will *always* use that version over any calculated versions. This is so if you rebuild a tag then the same version will be produced.
149

@@ -39,6 +34,6 @@ We recognise that a single formatted version number does not work for all cases.
3934
You can just run `GitVersion.exe` in your repository to see what variables are available (by default a json object is returned).
4035

4136
## Exe or MSBuild Task
42-
There are two ways to consume GitVersion, the first is by running GitVersion.exe. The second is an MSBUild task. The MSBuild task is really easy to get up and running, simply install GitVersionTask from NuGet and it will integrate into your project and write out variables to your build server if it's running on one. The exe offers more options and works for not just .net projects.
37+
There are two ways to consume GitVersion, the first is by running GitVersion.exe. The second is an MSBuild task. The MSBuild task is really easy to get up and running, simply install GitVersionTask from NuGet and it will integrate into your project and write out variables to your build server if it's running on one. The exe offers more options and works for not just .net projects.
4338

4439
Read more about [using GitVersion](./usage.md)

Docs/versionSources.md

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -17,7 +17,7 @@ GitVersion will find all tags on the current branch and return the highest one.
1717
Will increment: true
1818

1919
### Version in branch name
20-
If the branch has a version in it, then that version will be returned
20+
If the branch has a version in it, then that version will be returned.
2121

2222
Will increment: false
2323

@@ -27,7 +27,7 @@ If a branch with a version number in it is merged into the current branch, that
2727
Will increment: false
2828

2929
### GitVersionConfig.yaml
30-
If the next-version property is specified in the config file, it will be used as a version source.
30+
If the `next-version` property is specified in the config file, it will be used as a version source.
3131

3232
Will increment: false
3333

GitVersionCore/Configuration/Wizard/EditConfigStep.cs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -30,7 +30,7 @@ protected override string GetPrompt(Config config)
3030
{
3131
return string.Format(@"Which would you like to change?
3232
33-
0) Save changes
33+
0) Save changes and exit
3434
1) Exit without saving
3535
2) Branch specific configuration
3636
3) Branch Increment mode (per commit/after tag) (Current: {0})

GitVersionCore/Configuration/Wizard/PickBranchingStrategy1Step.cs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -27,7 +27,7 @@ protected override string GetPrompt(Config config)
2727
{
2828
return @"GitVersion can try to recommend you a branching strategy based on a few questions.
2929
30-
Do you need to maintain mutliple versions of your application simultanously in production? (y/n)";
30+
Do you need to maintain multiple versions of your application simultaneously in production? (y/n)";
3131
}
3232

3333
protected override string DefaultResult

GitVersionCore/Configuration/Wizard/PickBranchingStrategy2Step.cs

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -13,9 +13,9 @@ protected override StepResult HandleResult(string result, Queue<ConfigInitWizard
1313
Console.WriteLine("GitFlow is likely a good fit, the 'develop' branch can be used " +
1414
"for active development while stabilising the next release.");
1515
Console.WriteLine();
16-
Console.WriteLine("GitHubFlow is designed for a lightwieght workflow where master is always " +
16+
Console.WriteLine("GitHubFlow is designed for a lightweight workflow where master is always " +
1717
"good to deploy to production and feature branches are used to stabilise " +
18-
"features, once stable they can be released in the next release");
18+
"features, once stable they are merged to master and made available in the next release");
1919
steps.Enqueue(new PickBranchingStrategyStep());
2020
return StepResult.Ok();
2121
case "n":

GitVersionCore/Configuration/Wizard/PickBranchingStrategy3Step.cs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -13,7 +13,7 @@ protected override StepResult HandleResult(string result, Queue<ConfigInitWizard
1313
Console.WriteLine("GitFlow could be a better fit than GitHubFlow for you.");
1414
Console.WriteLine();
1515
Console.WriteLine("GitVersion increments the SemVer for each commit on the develop branch by default, " +
16-
"this means all packages build from develop can be published to a single NuGet feed.");
16+
"this means all packages built from develop can be published to a single NuGet feed.");
1717
break;
1818
case "n":
1919
Console.WriteLine("We recommend the GitHubFlow branching strategy, it sounds like you will " +

GitVersionCore/Configuration/Wizard/SetBranchIncrementMode.cs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -35,7 +35,7 @@ protected override StepResult HandleResult(string result, Queue<ConfigInitWizard
3535

3636
protected override string GetPrompt(Config config)
3737
{
38-
return string.Format(@"What do you want the increment mode for {0} to be
38+
return string.Format(@"What do you want the increment mode for {0} to be?
3939
4040
0) Back
4141
1) Follow SemVer and only increment when a release has been tagged (continuous delivery mode)

GitVersionCore/Configuration/Wizard/SetBranchTag.cs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -9,8 +9,8 @@ public class SetBranchTag : ConfigInitWizardStep
99

1010
public SetBranchTag(string name, BranchConfig branchConfig)
1111
{
12-
this.branchConfig = branchConfig;
1312
this.name = name;
13+
this.branchConfig = branchConfig;
1414
}
1515

1616
protected override StepResult HandleResult(string result, Queue<ConfigInitWizardStep> steps, Config config)

GitVersionCore/Configuration/Wizard/SimpleOrTutorialStep.cs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -20,7 +20,7 @@ protected override StepResult HandleResult(string result, Queue<ConfigInitWizard
2020

2121
protected override string GetPrompt(Config config)
2222
{
23-
return "Would you like to run an extended init (more like a tutorial) (y/n)";
23+
return "Would you like to run an extended init? (more like a tutorial) (y/n)";
2424
}
2525

2626
protected override string DefaultResult

0 commit comments

Comments
 (0)