Skip to content

Commit b6df4bf

Browse files
committed
ArgumentParser cleanup
1 parent 00fc08d commit b6df4bf

File tree

2 files changed

+35
-23
lines changed

2 files changed

+35
-23
lines changed

src/GitVersionExe/GitVersionApplication.cs

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -106,8 +106,6 @@ private int VerifyArgumentsAndRun(Arguments arguments)
106106
return 0;
107107
}
108108

109-
110-
111109
var execCommand = new ExecCommand();
112110

113111
execCommand.Execute(arguments, fileSystem, environment, log, configFileLocator);

src/GitVersionExe/Program.cs

Lines changed: 35 additions & 21 deletions
Original file line numberDiff line numberDiff line change
@@ -8,35 +8,34 @@
88

99
namespace GitVersion
1010
{
11-
class Program
11+
internal class Program
1212
{
13-
static void Main(string[] args)
13+
private static void Main(string[] args)
1414
{
15-
var fileSystem = new FileSystem();
16-
var environment = new Environment();
17-
var argumentParser = new ArgumentParser();
15+
var arguments = ParseArguments(args);
1816

19-
int exitCode;
20-
try
17+
var exitCode = 1;
18+
if (arguments != null)
2119
{
22-
var arguments = argumentParser.ParseArguments(args);
23-
var log = new Log
20+
var fileSystem = new FileSystem();
21+
var environment = new Environment();
22+
23+
try
2424
{
25-
Verbosity = arguments.Verbosity
26-
};
25+
var log = new Log { Verbosity = arguments.Verbosity };
2726

28-
var configFileLocator = string.IsNullOrWhiteSpace(arguments.ConfigFile)
29-
? (IConfigFileLocator) new DefaultConfigFileLocator(fileSystem, log)
30-
: new NamedConfigFileLocator(arguments.ConfigFile, fileSystem, log);
27+
var configFileLocator = string.IsNullOrWhiteSpace(arguments.ConfigFile)
28+
? (IConfigFileLocator) new DefaultConfigFileLocator(fileSystem, log)
29+
: new NamedConfigFileLocator(arguments.ConfigFile, fileSystem, log);
3130

32-
var app = new GitVersionApplication(fileSystem, environment, log, configFileLocator);
31+
var app = new GitVersionApplication(fileSystem, environment, log, configFileLocator);
3332

34-
exitCode = app.Run(arguments);
35-
}
36-
catch (Exception exception)
37-
{
38-
Console.Error.WriteLine(exception.Message);
39-
exitCode = 1;
33+
exitCode = app.Run(arguments);
34+
}
35+
catch (Exception exception)
36+
{
37+
Console.Error.WriteLine(exception.Message);
38+
}
4039
}
4140

4241
if (Debugger.IsAttached)
@@ -46,5 +45,20 @@ static void Main(string[] args)
4645

4746
System.Environment.Exit(exitCode);
4847
}
48+
49+
private static Arguments ParseArguments(string[] args)
50+
{
51+
var argumentParser = new ArgumentParser();
52+
Arguments arguments = null;
53+
try
54+
{
55+
arguments = argumentParser.ParseArguments(args);
56+
}
57+
catch (Exception exception)
58+
{
59+
Console.Error.WriteLine(exception.Message);
60+
}
61+
return arguments;
62+
}
4963
}
5064
}

0 commit comments

Comments
 (0)