Skip to content

Commit bbe60f5

Browse files
committed
Put config files into namespaces
1 parent 17666bd commit bbe60f5

File tree

6 files changed

+27
-17
lines changed

6 files changed

+27
-17
lines changed

GitVersionCore.Tests/ConfigReaderTests.cs

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,6 @@
11
using System.IO;
2+
using GitVersion;
3+
using GitVersion.Configuration;
24
using NUnit.Framework;
35

46
[TestFixture]
Lines changed: 7 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,9 @@
1-
public enum AssemblyVersioningScheme
1+
namespace GitVersion
22
{
3-
MajorMinorPatch,
4-
MajorMinor,
5-
Major,
3+
public enum AssemblyVersioningScheme
4+
{
5+
MajorMinorPatch,
6+
MajorMinor,
7+
Major,
8+
}
69
}
Lines changed: 5 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,7 @@
1-
public class Config
1+
namespace GitVersion.Configuration
22
{
3-
public AssemblyVersioningScheme AssemblyVersioningScheme { get; set; }
3+
public class Config
4+
{
5+
public AssemblyVersioningScheme AssemblyVersioningScheme { get; set; }
6+
}
47
}

GitVersionCore/Configuration/ConfigReader.cs

Lines changed: 10 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -2,16 +2,19 @@
22
using YamlDotNet.Serialization;
33
using YamlDotNet.Serialization.NamingConventions;
44

5-
public class ConfigReader
5+
namespace GitVersion.Configuration
66
{
7-
public static Config Read(TextReader reader)
7+
public class ConfigReader
88
{
9-
var deserializer = new Deserializer(null, new CamelCaseNamingConvention());
10-
var deserialize = deserializer.Deserialize<Config>(reader);
11-
if (deserialize == null)
9+
public static Config Read(TextReader reader)
1210
{
13-
return new Config();
11+
var deserializer = new Deserializer(null, new CamelCaseNamingConvention());
12+
var deserialize = deserializer.Deserialize<Config>(reader);
13+
if (deserialize == null)
14+
{
15+
return new Config();
16+
}
17+
return deserialize;
1418
}
15-
return deserialize;
1619
}
1720
}

GitVersionTask.Tests/GitVersionTask.Tests.csproj

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -243,9 +243,7 @@
243243
<ItemGroup>
244244
<Service Include="{82A7F48D-3B50-4B1E-B82E-3ADA8210C358}" />
245245
</ItemGroup>
246-
<ItemGroup>
247-
<Folder Include="OutputVariables\" />
248-
</ItemGroup>
246+
<ItemGroup />
249247
<Import Project="$(MSBuildToolsPath)\Microsoft.CSharp.targets" />
250248
<PropertyGroup>
251249
<PostBuildEvent>

GitVersionTask/AssemblyInfoBuilder/UpdateAssemblyInfo.cs

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -3,6 +3,7 @@
33
using System;
44
using System.IO;
55
using GitVersion;
6+
using GitVersion.Configuration;
67
using Microsoft.Build.Framework;
78
using Microsoft.Build.Utilities;
89
using Logger = GitVersion.Logger;
@@ -85,7 +86,7 @@ AssemblyVersioningScheme GetAssemblyVersioningScheme()
8586
return ConfigReader.Read(reader).AssemblyVersioningScheme;
8687
}
8788
}
88-
return global::AssemblyVersioningScheme.MajorMinorPatch;
89+
return GitVersion.AssemblyVersioningScheme.MajorMinorPatch;
8990
}
9091

9192
AssemblyVersioningScheme versioningScheme;

0 commit comments

Comments
 (0)