Skip to content

Commit c22e1ec

Browse files
committed
Revert "Merge pull request #1591 from asbjornu/feature/tfs-merge-messages"
This reverts commit a0a6cc4, reversing changes made to 371a896. # Conflicts: # src/GitVersionCore/MergeMessage.cs
1 parent 47f7b48 commit c22e1ec

File tree

3 files changed

+1
-62
lines changed

3 files changed

+1
-62
lines changed

src/GitVersionCore.Tests/MergeMessageTests.cs

Lines changed: 0 additions & 57 deletions
Original file line numberDiff line numberDiff line change
@@ -209,63 +209,6 @@ public void ParsesRemoteTrackingMergeMessage(
209209
sut.Version.ShouldBe(expectedVersion);
210210
}
211211

212-
private static readonly object[] ParsesTfsEnglishUSMergeMessages =
213-
{
214-
new object[] { "Merge feature/one to master", "feature/one", "master", null },
215-
new object[] { "Merge v://10.10.10.10 to master", "v://10.10.10.10", "master", null },
216-
new object[] { "Merge feature/one to v://10.10.10.10", "feature/one", "v://10.10.10.10", null },
217-
new object[] { "Merge V4.0.0 to master", "V4.0.0", "master", new SemanticVersion(4) },
218-
new object[] { "Merge feature/4.1/one to master", "feature/4.1/one", "master", new SemanticVersion(4, 1) }
219-
};
220-
221-
[TestCaseSource(nameof(ParsesTfsEnglishUSMergeMessages))]
222-
public void ParsesTfsEnglishUSMessage(
223-
string message,
224-
string expectedMergedBranch,
225-
string expectedTargetBranch,
226-
SemanticVersion expectedVersion)
227-
{
228-
// Act
229-
var sut = new MergeMessage(message, _config);
230-
231-
// Assert
232-
sut.MatchDefinition.ShouldBe("TfsMergeMessageEnglishUS");
233-
sut.TargetBranch.ShouldBe(expectedTargetBranch);
234-
sut.MergedBranch.ShouldBe(expectedMergedBranch);
235-
sut.IsMergedPullRequest.ShouldBeFalse();
236-
sut.PullRequestNumber.ShouldBeNull();
237-
sut.Version.ShouldBe(expectedVersion);
238-
}
239-
240-
private static readonly object[] ParsesTfsGermanDEMergeMessages =
241-
{
242-
new object[] { "Zusammengeführter PR \"1234\": feature/one mit master mergen", "feature/one", "master", null, 1234 },
243-
new object[] { "Zusammengeführter PR \"1234\": v://10.10.10.10 mit master mergen", "v://10.10.10.10", "master", null, 1234 },
244-
new object[] { "Zusammengeführter PR \"1234\": feature/one mit v://10.10.10.10 mergen", "feature/one", "v://10.10.10.10", null, 1234 },
245-
new object[] { "Zusammengeführter PR \"1234\": V4.0.0 mit master mergen", "V4.0.0", "master", new SemanticVersion(4), 1234 },
246-
new object[] { "Zusammengeführter PR \"1234\": feature/4.1/one mit master mergen", "feature/4.1/one", "master", new SemanticVersion(4, 1), 1234 }
247-
};
248-
249-
[TestCaseSource(nameof(ParsesTfsGermanDEMergeMessages))]
250-
public void ParseTfsGermanDEMessage(
251-
string message,
252-
string expectedMergedBranch,
253-
string expectedTargetBranch,
254-
SemanticVersion expectedVersion,
255-
int? expectedPullRequestNumber)
256-
{
257-
// Act
258-
var sut = new MergeMessage(message, _config);
259-
260-
// Assert
261-
sut.MatchDefinition.ShouldBe("TfsMergeMessageGermanDE");
262-
sut.TargetBranch.ShouldBe(expectedTargetBranch);
263-
sut.MergedBranch.ShouldBe(expectedMergedBranch);
264-
sut.IsMergedPullRequest.ShouldBeTrue();
265-
sut.PullRequestNumber.ShouldBe(expectedPullRequestNumber);
266-
sut.Version.ShouldBe(expectedVersion);
267-
}
268-
269212
private static readonly object[] InvalidMergeMessages =
270213
{
271214
new object[] { "Merge pull request # from feature/one", "", null, null, null },

src/GitVersionCore.Tests/VersionCalculation/Strategies/MergeMessageBaseVersionStrategyTests.cs

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -47,8 +47,6 @@ public void ShouldNotAllowIncrementOfVersion()
4747
[TestCase("Merge branch 'Release-v2.2'", true, "2.2.0")]
4848
[TestCase("Merge remote-tracking branch 'origin/release/0.8.0' into develop/master", true, "0.8.0")]
4949
[TestCase("Merge remote-tracking branch 'refs/remotes/origin/release/2.0.0'", true, "2.0.0")]
50-
[TestCase("Merge release/5.1.0 to master", true, "5.1.0")] // Team Foundation Server 2017 default merge message (en-US)
51-
[TestCase("Zusammengeführter PR \"9\": release/5.1.0 mit master mergen", true, "5.1.0")] // Team Foundation Server 2017 default merge message (de-DE)
5250
public void TakesVersionFromMergeOfReleaseBranch(string message, bool isMergeCommit, string expectedVersion)
5351
{
5452
var parents = GetParents(isMergeCommit);

src/GitVersionCore/MergeMessage.cs

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -13,9 +13,7 @@ public class MergeMessage
1313
Pattern("SmartGit", @"^Finish (?<SourceBranch>[^\s]*)(?: into (?<TargetBranch>[^\s]*))*"),
1414
Pattern("BitBucketPull", @"^Merge pull request #(?<PullRequestNumber>\d+) (from|in) (?<Source>.*) from (?<SourceBranch>[^\s]*) to (?<TargetBranch>[^\s]*)"),
1515
Pattern("GitHubPull", @"^Merge pull request #(?<PullRequestNumber>\d+) (from|in) (?:(?<SourceBranch>[^\s]*))(?: into (?<TargetBranch>[^\s]*))*"),
16-
Pattern("RemoteTracking", @"^Merge remote-tracking branch '(?<SourceBranch>[^\s]*)'(?: into (?<TargetBranch>[^\s]*))*"),
17-
Pattern("TfsMergeMessageEnglishUS", @"^Merge (?<SourceBranch>[^\s]*) to (?<TargetBranch>[^\s]*)"),
18-
Pattern("TfsMergeMessageGermanDE",@"^Zusammengeführter PR ""(?<PullRequestNumber>\d+)""\: (?<SourceBranch>.*) mit (?<TargetBranch>.*) mergen")
16+
Pattern("RemoteTracking", @"^Merge remote-tracking branch '(?<SourceBranch>[^\s]*)'(?: into (?<TargetBranch>[^\s]*))*")
1917
};
2018

2119
public MergeMessage(string mergeMessage, Config config)

0 commit comments

Comments
 (0)