Skip to content

Commit d6b55a3

Browse files
committed
(build) fix the release notes task
1 parent bc2f557 commit d6b55a3

File tree

2 files changed

+7
-24
lines changed

2 files changed

+7
-24
lines changed

build/release.cake

Lines changed: 6 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -10,17 +10,20 @@ Task("Release-Notes")
1010
throw new InvalidOperationException("Could not resolve Github token.");
1111
}
1212

13+
var zipFiles = GetFiles(parameters.Paths.Directories.ArtifactsRoot.Combine("native") + "/*.tar.gz").Select(x => x.ToString());
14+
var assets = string.Join(",", zipFiles);
15+
16+
Information("zip count: " + zipFiles.Count());
17+
1318
var repoOwner = BuildParameters.MainRepoOwner;
1419
var repository = BuildParameters.MainRepoName;
1520
GitReleaseManagerCreate(token, repoOwner, repository, new GitReleaseManagerCreateSettings {
1621
Milestone = parameters.Version.Milestone,
1722
Name = parameters.Version.Milestone,
18-
Prerelease = true,
23+
Prerelease = false,
1924
TargetCommitish = "master"
2025
});
2126

22-
var zipFiles = GetFiles(parameters.Paths.Directories.ArtifactsRoot + "/*.tar.gz").Select(x => x.ToString());
23-
var assets = string.Join(",", zipFiles);
2427
GitReleaseManagerAddAssets(token, repoOwner, repository, parameters.Version.Milestone, assets);
2528
GitReleaseManagerClose(token, repoOwner, repository, parameters.Version.Milestone);
2629

build/utils/utils.cake

Lines changed: 1 addition & 21 deletions
Original file line numberDiff line numberDiff line change
@@ -108,7 +108,7 @@ GitVersion GetVersion(BuildParameters parameters)
108108
var gitversionFilePath = $"artifacts/gitversion.json";
109109
var gitversionFile = GetFiles(gitversionFilePath).FirstOrDefault();
110110
GitVersion gitVersion = null;
111-
if (gitversionFile == null)
111+
if (gitversionFile == null || parameters.IsLocalBuild)
112112
{
113113
Build(parameters);
114114

@@ -173,26 +173,6 @@ FilePath GetGitVersionToolLocation(BuildParameters parameters)
173173
return GetFiles($"src/GitVersionExe/bin/{parameters.Configuration}/{parameters.CoreFxVersion31}/gitversion.dll").SingleOrDefault();
174174
}
175175

176-
void PublishGitVersionToArtifacts(BuildParameters parameters)
177-
{
178-
var frameworks = new[] { parameters.CoreFxVersion21, parameters.CoreFxVersion31, parameters.FullFxVersion472 };
179-
180-
// publish Framework-dependent deployment
181-
foreach(var framework in frameworks)
182-
{
183-
var settings = new DotNetCorePublishSettings
184-
{
185-
Framework = framework,
186-
NoRestore = false,
187-
Configuration = parameters.Configuration,
188-
OutputDirectory = parameters.Paths.Directories.ArtifactsBin.Combine(framework),
189-
MSBuildSettings = parameters.MSBuildSettings,
190-
};
191-
192-
DotNetCorePublish("./src/GitVersionExe/GitVersionExe.csproj", settings);
193-
}
194-
}
195-
196176
void Build(BuildParameters parameters)
197177
{
198178
var sln = "./src/GitVersion.sln";

0 commit comments

Comments
 (0)