Correctly resolve dotnet format warning

chris-codeflow · chris-codeflow · commit de8cbcfa6f30 · 2021-10-14T22:48:25.000+01:00
diff --git a/src/GitVersion.Core/VersionCalculation/SemanticVersioning/SemanticVersionPreReleaseTag.cs b/src/GitVersion.Core/VersionCalculation/SemanticVersioning/SemanticVersionPreReleaseTag.cs
@@ -141,7 +141,7 @@ public string ToString(string format, IFormatProvider formatProvider)
 
         return format switch
         {
-            "t" => (Number.HasValue ? Name.IsNullOrEmpty() ? $"{Number}" : $"{Name}.{Number}" : Name!),
+            "t" => (Number.HasValue ? Name.IsNullOrEmpty() ? $"{Number}" : $"{Name}.{Number}" : Name ?? string.Empty),
             "l" => (Number.HasValue ? FormatLegacy(GetLegacyName(), Number.Value.ToString()) : FormatLegacy(GetLegacyName())),
             _ => throw new FormatException($"Unknown format '{format}'.")
         };

Original file line number	Diff line number	Diff line change
`@@ -141,7 +141,7 @@ public string ToString(string format, IFormatProvider formatProvider)`
`141`	`141`
`142`	`142`	`return format switch`
`143`	`143`	`{`
`144`		`- "t" => (Number.HasValue ? Name.IsNullOrEmpty() ? $"{Number}" : $"{Name}.{Number}" : Name!),`
	`144`	`+ "t" => (Number.HasValue ? Name.IsNullOrEmpty() ? $"{Number}" : $"{Name}.{Number}" : Name ?? string.Empty),`
`145`	`145`	`"l" => (Number.HasValue ? FormatLegacy(GetLegacyName(), Number.Value.ToString()) : FormatLegacy(GetLegacyName())),`
`146`	`146`	`_ => throw new FormatException($"Unknown format '{format}'.")`
`147`	`147`	`};`