Skip to content

Commit e38cdbe

Browse files
committed
Use case insensitive comparison for config filenames
1 parent d9360bc commit e38cdbe

File tree

2 files changed

+13
-1
lines changed

2 files changed

+13
-1
lines changed

src/GitVersion.Configuration.Tests/Configuration/ConfigurationFileLocatorTests.cs

Lines changed: 12 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -73,6 +73,18 @@ public void NoWarnOnGitVersionYmlFile(string configurationFile)
7373
Should.NotThrow(() => this.configurationProvider.ProvideForDirectory(this.repoPath));
7474
}
7575

76+
[TestCase(ConfigurationFileLocator.DefaultFileName)]
77+
[TestCase(ConfigurationFileLocator.DefaultAlternativeFileName)]
78+
[TestCase(ConfigurationFileLocator.DefaultFileNameDotted)]
79+
[TestCase(ConfigurationFileLocator.DefaultAlternativeFileNameDotted)]
80+
public void NoWarnOnLowercasedGitVersionYmlFile(string configurationFile)
81+
{
82+
var lowercasedConfigurationFile = configurationFile.ToLower();
83+
using var _ = this.fileSystem.SetupConfigFile(path: this.repoPath, fileName: lowercasedConfigurationFile);
84+
85+
Should.NotThrow(() => this.configurationProvider.ProvideForDirectory(this.repoPath));
86+
}
87+
7688
[Test]
7789
public void NoWarnOnNoGitVersionYmlFile() => Should.NotThrow(() => this.configurationProvider.ProvideForDirectory(this.repoPath));
7890
}

src/GitVersion.Configuration/ConfigurationFileLocator.cs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -74,7 +74,7 @@ private void WarnAboutAmbiguousConfigFileSelection(string? workingDirectory, str
7474

7575
if (!hasConfigInProjectRootDirectory && !hasConfigInWorkingDirectory)
7676
{
77-
if (!SupportedConfigFileNames.Any(entry => entry.Equals(this.ConfigurationFile)))
77+
if (!SupportedConfigFileNames.Any(entry => entry.Equals(this.ConfigurationFile, StringComparison.OrdinalIgnoreCase)))
7878
{
7979
workingConfigFile = PathHelper.Combine(workingDirectory, this.ConfigurationFile);
8080
projectRootConfigFile = PathHelper.Combine(projectRootDirectory, this.ConfigurationFile);

0 commit comments

Comments
 (0)