Merge pull request #1073 from GitTools/feature/dynamic

#953 Fix dynamic repositories

Author: GeertvanHorrik

src/GitVersionCore.Tests/DynamicRepositoryTests.cs

@@ -0,0 +1,49 @@
+using System.IO;
+using GitVersion;
+using NUnit.Framework;
+
+[TestFixture]
+public class DynamicRepositoryTests
+{
+    string workDirectory;
+
+
+    [SetUp]
+    public void CreateTemporaryRepository()
+    {
+        // Note: we can't use guid because paths will be too long
+        workDirectory = Path.Combine(Path.GetTempPath(), "DynRepoTests");
+    }
+
+
+    //[TearDown]
+    //public void Cleanup()
+    //{
+    //    Directory.Delete(workDirectory, true);
+    //}
+
+    [TestCase("GV_master_1", "https://github.com/GitTools/GitVersion", "master", "4783d325521463cd6cf1b61074352da84451f25d", "4.0.0+1126")]
+    [TestCase("GV_master_2", "https://github.com/GitTools/GitVersion", "master", "3bdcd899530b4e9b37d13639f317da04a749e728", "4.0.0+1132")]
+    public void FindsVersionInDynamicRepo(string name, string url, string targetBranch, string commitId, string expectedFullSemVer)
+    {
+        var root = Path.Combine(workDirectory, name);
+        var dynamicDirectory = Path.Combine(root, "dynamic");
+        var workingDirectory = Path.Combine(root, "working");
+
+        // Clear upfront
+        if (Directory.Exists(root))
+        {
+            Directory.Delete(root, true);
+        }
+
+        Directory.CreateDirectory(dynamicDirectory);
+        Directory.CreateDirectory(workingDirectory);
+
+        var executeCore = new ExecuteCore(new TestFileSystem());
+
+        var versionVariables = executeCore.ExecuteGitVersion(url, dynamicDirectory, null, targetBranch,
+            false, workingDirectory, commitId);
+
+        Assert.AreEqual(expectedFullSemVer, versionVariables.FullSemVer);
+    }
+}

src/GitVersionCore.Tests/GitVersionCore.Tests.csproj

@@ -120,6 +120,7 @@
     <Compile Include="BuildServers\VsoAgentTests.cs" />
     <Compile Include="BuildServers\TeamCityTests.cs" />
     <Compile Include="Configuration\IgnoreConfigTests.cs" />
+    <Compile Include="DynamicRepositoryTests.cs" />
     <Compile Include="GitToolsTestingExtensions.cs" />
     <Compile Include="DocumentationTests.cs" />
     <Compile Include="ConfigProviderTests.cs" />

src/GitVersionCore/GitPreparer.cs

@@ -166,15 +166,19 @@ static string CreateDynamicRepository(string targetPath, AuthenticationInfo auth
         static void CloneRepository(string repositoryUrl, string gitDirectory, AuthenticationInfo authentication)
         {
             Credentials credentials = null;
-            if (!string.IsNullOrWhiteSpace(authentication.Username) && !string.IsNullOrWhiteSpace(authentication.Password))
-            {
-                Logger.WriteInfo(string.Format("Setting up credentials using name '{0}'", authentication.Username));
 
-                credentials = new UsernamePasswordCredentials
+            if (authentication != null)
+            {
+                if (!string.IsNullOrWhiteSpace(authentication.Username) && !string.IsNullOrWhiteSpace(authentication.Password))
                 {
-                    Username = authentication.Username,
-                    Password = authentication.Password
-                };
+                    Logger.WriteInfo(string.Format("Setting up credentials using name '{0}'", authentication.Username));
+
+                    credentials = new UsernamePasswordCredentials
+                    {
+                        Username = authentication.Username,
+                        Password = authentication.Password
+                    };
+                }
             }
 
             Logger.WriteInfo(string.Format("Retrieving git info from url '{0}'", repositoryUrl));