Skip to content

Commit e998847

Browse files
KiLLeRRaTarturcic
authored andcommitted
Added new EscapedBranchName variable
1 parent 46ae39f commit e998847

17 files changed

+23
-2
lines changed

docs/input/docs/more-info/variables.md

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -29,6 +29,7 @@ Running `GitVersion.exe` in your repo will show you what is available. For the
2929
"FullSemVer":"3.0.0-beta.1+1",
3030
"InformationalVersion":"3.0.0-beta.1+1.Branch.release/3.0.0.Sha.28c853159a46b5a87e6cc9c4f6e940c59d6bc68a",
3131
"BranchName":"release/3.0.0",
32+
"EscapedBranchName":"release-3.0.0",
3233
"Sha":"28c853159a46b5a87e6cc9c4f6e940c59d6bc68a",
3334
"ShortSha":"28c8531",
3435
"NuGetVersionV2":"3.0.0-beta0001",

src/GitVersionCore.Tests/Approved/JsonVersionBuilderTests.Json.approved.txt

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -19,6 +19,7 @@
1919
"FullSemVer":"1.2.0-unstable.4+5",
2020
"InformationalVersion":"1.2.0-unstable.4+5.Branch.feature1.Sha.commitSha",
2121
"BranchName":"feature1",
22+
"EscapedBranchName":"feature1",
2223
"Sha":"commitSha",
2324
"ShortSha":"commitShortSha",
2425
"NuGetVersionV2":"1.2.0-unstable0004",

src/GitVersionCore.Tests/Approved/VariableProviderTests.ProvidesVariablesInContinuousDeliveryModeForFeatureBranch.approved.txt

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -19,6 +19,7 @@
1919
"FullSemVer":"1.2.3+5",
2020
"InformationalVersion":"1.2.3+5.Branch.feature-123.Sha.commitSha",
2121
"BranchName":"feature/123",
22+
"EscapedBranchName":"feature-123",
2223
"Sha":"commitSha",
2324
"ShortSha":"commitShortSha",
2425
"NuGetVersionV2":"1.2.3",

src/GitVersionCore.Tests/Approved/VariableProviderTests.ProvidesVariablesInContinuousDeliveryModeForFeatureBranchWithCustomAssemblyInformationalFormat.approved.txt

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -19,6 +19,7 @@
1919
"FullSemVer":"1.2.3+5",
2020
"InformationalVersion":"1.2.3+5.Branch.feature-123.Sha.commitShortSha",
2121
"BranchName":"feature/123",
22+
"EscapedBranchName":"feature-123",
2223
"Sha":"commitSha",
2324
"ShortSha":"commitShortSha",
2425
"NuGetVersionV2":"1.2.3",

src/GitVersionCore.Tests/Approved/VariableProviderTests.ProvidesVariablesInContinuousDeliveryModeForPreRelease.approved.txt

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -19,6 +19,7 @@
1919
"FullSemVer":"1.2.3-unstable.4+5",
2020
"InformationalVersion":"1.2.3-unstable.4+5.Branch.develop.Sha.commitSha",
2121
"BranchName":"develop",
22+
"EscapedBranchName":"develop",
2223
"Sha":"commitSha",
2324
"ShortSha":"commitShortSha",
2425
"NuGetVersionV2":"1.2.3-unstable0004",

src/GitVersionCore.Tests/Approved/VariableProviderTests.ProvidesVariablesInContinuousDeliveryModeForPreReleaseWithPadding.approved.txt

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -19,6 +19,7 @@
1919
"FullSemVer":"1.2.3-unstable.4+5",
2020
"InformationalVersion":"1.2.3-unstable.4+5.Branch.develop.Sha.commitSha",
2121
"BranchName":"develop",
22+
"EscapedBranchName":"develop",
2223
"Sha":"commitSha",
2324
"ShortSha":"commitShortSha",
2425
"NuGetVersionV2":"1.2.3-unstable00004",

src/GitVersionCore.Tests/Approved/VariableProviderTests.ProvidesVariablesInContinuousDeliveryModeForStable.approved.txt

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -19,6 +19,7 @@
1919
"FullSemVer":"1.2.3+5",
2020
"InformationalVersion":"1.2.3+5.Branch.develop.Sha.commitSha",
2121
"BranchName":"develop",
22+
"EscapedBranchName":"develop",
2223
"Sha":"commitSha",
2324
"ShortSha":"commitShortSha",
2425
"NuGetVersionV2":"1.2.3",

src/GitVersionCore.Tests/Approved/VariableProviderTests.ProvidesVariablesInContinuousDeploymentModeForPreRelease.approved.txt

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -19,6 +19,7 @@
1919
"FullSemVer":"1.2.3-unstable.8",
2020
"InformationalVersion":"1.2.3-unstable.8+Branch.develop.Sha.commitSha",
2121
"BranchName":"develop",
22+
"EscapedBranchName":"develop",
2223
"Sha":"commitSha",
2324
"ShortSha":"commitShortSha",
2425
"NuGetVersionV2":"1.2.3-unstable0008",

src/GitVersionCore.Tests/Approved/VariableProviderTests.ProvidesVariablesInContinuousDeploymentModeForStable.approved.txt

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -19,6 +19,7 @@
1919
"FullSemVer":"1.2.3-ci.5",
2020
"InformationalVersion":"1.2.3-ci.5+Branch.develop.Sha.commitSha",
2121
"BranchName":"develop",
22+
"EscapedBranchName":"develop",
2223
"Sha":"commitSha",
2324
"ShortSha":"commitShortSha",
2425
"NuGetVersionV2":"1.2.3-ci0005",

src/GitVersionCore.Tests/Approved/VariableProviderTests.ProvidesVariablesInContinuousDeploymentModeForStableWhenCurrentCommitIsTagged.approved.txt

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -19,6 +19,7 @@
1919
"FullSemVer":"1.2.3+5",
2020
"InformationalVersion":"1.2.3+5.Sha.commitSha",
2121
"BranchName":"",
22+
"EscapedBranchName":"",
2223
"Sha":"commitSha",
2324
"ShortSha":"commitShortSha",
2425
"NuGetVersionV2":"1.2.3",

src/GitVersionCore.Tests/Approved/WixFileTests.UpdateWixVersionFile.approved.txt

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
<?xml version="1.0" encoding="utf-8"?>
1+
<?xml version="1.0" encoding="utf-8"?>
22
<Include xmlns="http://schemas.microsoft.com/wix/2006/wi">
33
<?define AssemblySemFileVer="1.2.3.0"?>
44
<?define AssemblySemVer="1.2.3.0"?>
@@ -8,6 +8,7 @@
88
<?define CommitDate="2019-02-20"?>
99
<?define CommitsSinceVersionSource="5"?>
1010
<?define CommitsSinceVersionSourcePadded="0005"?>
11+
<?define EscapedBranchName="develop"?>
1112
<?define FullBuildMetaData="5.Branch.develop.Sha.commitSha"?>
1213
<?define FullSemVer="1.2.3+5"?>
1314
<?define InformationalVersion="1.2.3+5.Branch.develop.Sha.commitSha"?>

src/GitVersionCore.Tests/Approved/cs/GitVersionInformationGeneratorTests.ShouldCreateFile.approved.txt

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -31,6 +31,7 @@ static class GitVersionInformation
3131
public static string FullSemVer = "1.2.3-unstable.4+5";
3232
public static string InformationalVersion = "1.2.3-unstable.4+5.Branch.feature1.Sha.commitSha";
3333
public static string BranchName = "feature1";
34+
public static string EscapedBranchName = "feature1";
3435
public static string Sha = "commitSha";
3536
public static string ShortSha = "commitShortSha";
3637
public static string NuGetVersionV2 = "1.2.3-unstable0004";

src/GitVersionCore.Tests/Approved/fs/GitVersionInformationGeneratorTests.ShouldCreateFile.approved.txt

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -31,6 +31,7 @@ module GitVersionInformation
3131
let FullSemVer = "1.2.3-unstable.4+5"
3232
let InformationalVersion = "1.2.3-unstable.4+5.Branch.feature1.Sha.commitSha"
3333
let BranchName = "feature1"
34+
let EscapedBranchName = "feature1"
3435
let Sha = "commitSha"
3536
let ShortSha = "commitShortSha"
3637
let NuGetVersionV2 = "1.2.3-unstable0004"

src/GitVersionCore.Tests/Approved/vb/GitVersionInformationGeneratorTests.ShouldCreateFile.approved.txt

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -32,6 +32,7 @@ NotInheritable Class GitVersionInformation
3232
Public Shared FullSemVer As String = "1.2.3-unstable.4+5"
3333
Public Shared InformationalVersion As String = "1.2.3-unstable.4+5.Branch.feature1.Sha.commitSha"
3434
Public Shared BranchName As String = "feature1"
35+
Public Shared EscapedBranchName As String = "feature1"
3536
Public Shared Sha As String = "commitSha"
3637
Public Shared ShortSha As String = "commitShortSha"
3738
Public Shared NuGetVersionV2 As String = "1.2.3-unstable0004"

src/GitVersionCore.Tests/GitVersionExecutorTests.cs

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -125,6 +125,7 @@ public void CacheFileExistsOnDisk()
125125
FullSemVer: 4.10.3-test.19
126126
InformationalVersion: 4.10.3-test.19+Branch.feature/test.Sha.dd2a29aff0c948e1bdf3dabbe13e1576e70d5f9f
127127
BranchName: feature/test
128+
EscapedBranchName: feature-test
128129
Sha: dd2a29aff0c948e1bdf3dabbe13e1576e70d5f9f
129130
ShortSha: dd2a29af
130131
NuGetVersionV2: 4.10.3-test0019
@@ -185,6 +186,7 @@ public void CacheFileExistsOnDiskWhenOverrideConfigIsSpecifiedVersionShouldBeDyn
185186
FullSemVer: 4.10.3-test.19
186187
InformationalVersion: 4.10.3-test.19+Branch.feature/test.Sha.dd2a29aff0c948e1bdf3dabbe13e1576e70d5f9f
187188
BranchName: feature/test
189+
EscapedBranchName: feature-test
188190
Sha: dd2a29aff0c948e1bdf3dabbe13e1576e70d5f9f
189191
ShortSha: dd2a29af
190192
NuGetVersionV2: 4.10.3-test0019
@@ -268,6 +270,7 @@ public void ConfigChangeInvalidatesCache()
268270
FullSemVer: 4.10.3-test.19
269271
InformationalVersion: 4.10.3-test.19+Branch.feature/test.Sha.dd2a29aff0c948e1bdf3dabbe13e1576e70d5f9f
270272
BranchName: feature/test
273+
EscapedBranchName: feature-test
271274
Sha: dd2a29aff0c948e1bdf3dabbe13e1576e70d5f9f
272275
ShortSha: dd2a29af
273276
NuGetVersionV2: 4.10.3-test0019
@@ -328,6 +331,7 @@ public void NoCacheBypassesCache()
328331
FullSemVer: 4.10.3-test.19
329332
InformationalVersion: 4.10.3-test.19+Branch.feature/test.Sha.dd2a29aff0c948e1bdf3dabbe13e1576e70d5f9f
330333
BranchName: feature/test
334+
EscapedBranchName: feature-test
331335
Sha: dd2a29aff0c948e1bdf3dabbe13e1576e70d5f9f
332336
ShortSha: dd2a29af
333337
NuGetVersionV2: 4.10.3-test0019

src/GitVersionCore/SemanticVersioning/SemanticVersionFormatValues.cs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -54,7 +54,7 @@ public SemanticVersionFormatValues(SemanticVersion semver, EffectiveConfiguratio
5454

5555
public string BranchName => semver.BuildMetaData.Branch;
5656

57-
public string EscapedBranchName => semver.BuildMetaData.Branch.RegexReplace("[^a-zA-Z0-9-]", "-");
57+
public string EscapedBranchName => semver.BuildMetaData.Branch?.RegexReplace("[^a-zA-Z0-9-]", "-");
5858

5959
public string Sha => semver.BuildMetaData.Sha;
6060

src/GitVersionTask.MsBuild/Tasks/GetVersion.cs

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -64,6 +64,9 @@ public class GetVersion : GitVersionTaskBase
6464
[Output]
6565
public string BranchName { get; set; }
6666

67+
[Output]
68+
public string EscapedBranchName { get; set; }
69+
6770
[Output]
6871
public string Sha { get; set; }
6972

0 commit comments

Comments
 (0)