Should not increment version when current commit is tagged

Author: JakeGinnivan

GitVersionCore.Tests/VersionCalculation/Strategies/LastTagBaseVersionStrategyTests.cs

@@ -8,16 +8,30 @@
     public class LastTagBaseVersionStrategyTests
     {
         [Test]
-        public void ShouldAllowVersionIncremenet()
+        public void ShouldAllowVersionIncrement()
         {
             var context = new GitVersionContextBuilder()
                 .WithTaggedMaster()
+                .AddCommit()
                 .Build();
             var sut = new LastTagBaseVersionStrategy();
 
             var baseVersion = sut.GetVersion(context);
 
             baseVersion.ShouldIncrement.ShouldBe(true);
         }
+
+        [Test]
+        public void ShouldNotAllowVersionIncrementWhenTagComesFromCurrentCommit()
+        {
+            var context = new GitVersionContextBuilder()
+                .WithTaggedMaster()
+                .Build();
+            var sut = new LastTagBaseVersionStrategy();
+
+            var baseVersion = sut.GetVersion(context);
+
+            baseVersion.ShouldIncrement.ShouldBe(false);
+        }
     }
 }

GitVersionCore/VersionCalculation/BaseVersionCalculators/LastTagBaseVersionStrategy.cs

@@ -6,7 +6,10 @@ public override BaseVersion GetVersion(GitVersionContext context)
         {
             VersionTaggedCommit version;
             if (new LastTaggedReleaseFinder(context).GetVersion(out version))
-                return new BaseVersion(true, version.SemVer, version.Commit);
+            {
+                var shouldIncrement = version.Commit != context.CurrentCommit;
+                return new BaseVersion(shouldIncrement, version.SemVer, version.Commit);
+            }
 
             return null;
         }

GitVersionCore/VersionCalculation/MetaDataCalculator.cs

@@ -14,8 +14,10 @@ public SemanticVersionBuildMetaData Create(Commit baseVersionSource, GitVersionC
                 SortBy = CommitSortStrategies.Topological | CommitSortStrategies.Time
             };
 
+            var commitsSinceTag = context.Repository.Commits.QueryBy(qf).Count();
+
             return new SemanticVersionBuildMetaData(
-                context.Repository.Commits.QueryBy(qf).Count(),
+                commitsSinceTag,
                 context.CurrentBranch.Name,
                 context.CurrentCommit.Sha,
                 context.CurrentCommit.When());

GitVersionCore/VersionCalculation/NewNextVersionCalculator.cs

@@ -57,8 +57,11 @@ static void IncrementVersion(GitVersionContext context, BaseVersion baseVersion)
             }
             else
             {
-                baseVersion.SemanticVersion.PreReleaseTag.Number = baseVersion.SemanticVersion.PreReleaseTag.Number ?? 0;
-                baseVersion.SemanticVersion.PreReleaseTag.Number++;
+                if (baseVersion.SemanticVersion.PreReleaseTag.Number != null)
+                {
+                    baseVersion.SemanticVersion.PreReleaseTag.Number = baseVersion.SemanticVersion.PreReleaseTag.Number;
+                    baseVersion.SemanticVersion.PreReleaseTag.Number++;
+                }
             }
         }
     }