Skip to content

Commit f18f189

Browse files
committed
Merge pull request #377 from anobleperson/release/3.0.0
Fixes #375 - Made known merge branch version number extraction case insensitive
2 parents 43db528 + ae81188 commit f18f189

File tree

2 files changed

+12
-22
lines changed

2 files changed

+12
-22
lines changed

GitVersionCore.Tests/VersionCalculation/Strategies/MergeMessageBaseVersionStrategyTests.cs

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -35,8 +35,12 @@ public void ShouldNotAllowIncrementOfVersion()
3535
[TestCase("Merge branch 'release-10.10.50'", true, "10.10.50")]
3636
[TestCase("Merge branch 's'", true, null)] // Must start with a number
3737
[TestCase("Merge branch 'release-0.2.0'", true, "0.2.0")]
38+
[TestCase("Merge branch 'Release-0.2.0'", true, "0.2.0")]
39+
[TestCase("Merge branch 'Release/0.2.0'", true, "0.2.0")]
3840
[TestCase("Merge branch 'hotfix-4.6.6' into support-4.6", true, "4.6.6")]
3941
[TestCase("Merge branch 'hotfix-10.10.50'", true, "10.10.50")]
42+
[TestCase("Merge branch 'Hotfix-10.10.50'", true, "10.10.50")]
43+
[TestCase("Merge branch 'Hotfix/10.10.50'", true, "10.10.50")]
4044
[TestCase("Merge branch 'hotfix-0.1.5'", true, "0.1.5")]
4145
[TestCase("Merge branch 'hotfix-4.2.2' into support-4.2", true, "4.2.2")]
4246
[TestCase("Merge branch 'hotfix-0.1.5'\n\nRelates to: TicketId", true, "0.1.5")]

GitVersionCore/VersionCalculation/BaseVersionCalculators/MergeMessageBaseVersionStrategy.cs

Lines changed: 8 additions & 22 deletions
Original file line numberDiff line numberDiff line change
@@ -50,31 +50,17 @@ static bool Inner(Commit mergeCommit, out string versionPart)
5050

5151
var message = mergeCommit.Message.TrimToFirstLine();
5252

53+
var knownMergePrefixes = new[] { "Merge branch 'hotfix-", "Merge branch 'hotfix/", "Merge branch 'release-", "Merge branch 'release/" };
5354

54-
if (message.StartsWith("Merge branch 'hotfix-"))
55+
foreach (var prefix in knownMergePrefixes)
5556
{
56-
var suffix = message.Replace("Merge branch 'hotfix-", "");
57-
return TryGetPrefix(suffix, out versionPart, "'");
58-
}
59-
60-
if (message.StartsWith("Merge branch 'hotfix/"))
61-
{
62-
var suffix = message.Replace("Merge branch 'hotfix/", "");
63-
return TryGetPrefix(suffix, out versionPart, "'");
64-
}
65-
66-
if (message.StartsWith("Merge branch 'release-"))
67-
{
68-
var suffix = message.Replace("Merge branch 'release-", "");
69-
return TryGetPrefix(suffix, out versionPart, "'");
70-
}
71-
72-
if (message.StartsWith("Merge branch 'release/"))
73-
{
74-
var suffix = message.Replace("Merge branch 'release/", "");
75-
return TryGetPrefix(suffix, out versionPart, "'");
57+
if (message.StartsWith(prefix))
58+
{
59+
var suffix = message.Substring(prefix.Length);
60+
return TryGetPrefix(suffix, out versionPart, "'");
61+
}
7662
}
77-
63+
7864
if (message.StartsWith("Merge branch '"))
7965
{
8066
var suffix = message.Replace("Merge branch '", "");

0 commit comments

Comments
 (0)