Warn on obsolete branch configuration settings

Author: maxraab

src/GitVersionCore/Configuration/LegacyBranchConfig.cs

@@ -0,0 +1,16 @@
+namespace GitVersion
+{
+    using YamlDotNet.Serialization;
+
+    /// <summary>
+    /// Obsolete properties are added to this, so we can check to see if they are used and provide good error messages for migration
+    /// </summary>
+    public class LegacyBranchConfig
+    {
+        [YamlMember(Alias = "is-develop")]
+        public string IsDevelop
+        {
+            get; set;
+        }
+    }
+}

src/GitVersionCore/Configuration/LegacyConfig.cs

@@ -1,18 +1,56 @@
 namespace GitVersion
 {
+    using System.Collections.Generic;
+    using System.Linq;
     using YamlDotNet.Serialization;
 
     /// <summary>
     /// Obsolete properties are added to this, so we can check to see if they are used and provide good error messages for migration
     /// </summary>
     public class LegacyConfig
     {
+        private Dictionary<string, LegacyBranchConfig> branches = new Dictionary<string, LegacyBranchConfig>();
+
         public string assemblyVersioningScheme { get; set; }
 
         [YamlMember(Alias = "develop-branch-tag")]
         public string DevelopBranchTag { get; set; }
 
         [YamlMember(Alias = "release-branch-tag")]
         public string ReleaseBranchTag { get; set; }
+
+        [YamlMember(Alias = "branches")]
+        public Dictionary<string, LegacyBranchConfig> Branches
+        {
+            get
+            {
+                return branches;
+            }
+            set
+            {
+                value.ToList().ForEach(_ =>
+                {
+                    if (!branches.ContainsKey(_.Key))
+                        branches.Add(_.Key, new LegacyBranchConfig());
+
+                    branches[_.Key] = MergeObjects(branches[_.Key], _.Value);
+                });
+            }
+        }
+
+        private T MergeObjects<T>(T target, T source)
+        {
+            typeof(T).GetProperties()
+                .Where(prop => prop.CanRead && prop.CanWrite)
+                .Select(_ => new
+                {
+                    prop = _,
+                    value = _.GetValue(source, null)
+                })
+                .Where(_ => _.value != null)
+                .ToList()
+                .ForEach(_ => _.prop.SetValue(target, _.value, null));
+            return target;
+        }
     }
-}
+}

src/GitVersionCore/Configuration/LegacyConfigNotifier.cs

@@ -26,6 +26,9 @@ public static void Notify(StringReader reader)
             if (legacyConfig.ReleaseBranchTag != null)
                 issues.Add("release-branch-tag has been replaced by branch specific configuration. See http://gitversion.readthedocs.org/en/latest/configuration/#branch-configuration");
 
+            if (legacyConfig.Branches != null && legacyConfig.Branches.Any(branches => branches.Value.IsDevelop != null))
+                issues.Add("'is-develop' is deprecated, use 'track-release-branches' instead. See http://gitversion.readthedocs.org/en/latest/configuration/#branch-configuration");
+
             if (issues.Any())
                 throw new OldConfigurationException("GitVersion configuration file contains old configuration, please fix the following errors:\r\n" + string.Join("\r\n", issues));
         }

src/GitVersionCore/GitVersionCore.csproj

@@ -97,6 +97,7 @@
     <Compile Include="Configuration\ConfigSerialiser.cs" />
     <Compile Include="Configuration\ConfigurationProvider.cs" />
     <Compile Include="Configuration\IncrementStrategy.cs" />
+    <Compile Include="Configuration\LegacyBranchConfig.cs" />
     <Compile Include="Configuration\LegacyConfig.cs" />
     <Compile Include="Configuration\LegacyConfigNotifier.cs" />
     <Compile Include="Configuration\OldConfigurationException.cs" />