Skip to content

Commit fc2bb64

Browse files
committed
#2268 Correct a version calculation for non-master mainline branches
1 parent ba7992f commit fc2bb64

File tree

2 files changed

+5
-5
lines changed

2 files changed

+5
-5
lines changed

src/GitVersionCore.Tests/IntegrationTests/MainlineDevelopmentMode.cs

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -117,7 +117,7 @@ public void SupportBranches()
117117
fixture.AssertFullSemver("1.0.2", config);
118118

119119
fixture.BranchTo("support/1.0", "support10");
120-
fixture.AssertFullSemver("1.0.3", config);
120+
fixture.AssertFullSemver("1.0.2", config);
121121

122122
// Move master on
123123
fixture.Checkout("master");
@@ -126,9 +126,9 @@ public void SupportBranches()
126126

127127
// Continue on support/1.0
128128
fixture.Checkout("support/1.0");
129+
fixture.MakeACommit(); // 1.0.3
129130
fixture.MakeACommit(); // 1.0.4
130-
fixture.MakeACommit(); // 1.0.5
131-
fixture.AssertFullSemver("1.0.5", config);
131+
fixture.AssertFullSemver("1.0.4", config);
132132
fixture.BranchTo("feature/foo", "foo");
133133
fixture.AssertFullSemver("1.0.5-foo.0", config);
134134
fixture.MakeACommit();
@@ -185,7 +185,7 @@ public void VerifySupportForwardMerge()
185185
fixture.MakeACommit();
186186
fixture.AssertFullSemver("1.1.2", config);
187187
fixture.Checkout("support/1.0");
188-
fixture.AssertFullSemver("1.0.4", config);
188+
fixture.AssertFullSemver("1.0.3", config);
189189

190190
fixture.BranchTo("feature/foo", "foo");
191191
fixture.MakeACommit();

src/GitVersionCore/VersionCalculation/MainlineVersionCalculator.cs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -69,7 +69,7 @@ public SemanticVersion FindMainlineModeVersion(BaseVersion baseVersion)
6969
mainlineVersion.BuildMetaData = CreateVersionBuildMetaData(mergeBase);
7070

7171
// branches other than master always get a bump for the act of branching
72-
if (context.CurrentBranch.FriendlyName != "master")
72+
if (!context.CurrentBranch.IsSameBranch(mainline))
7373
{
7474
var branchIncrement = FindMessageIncrement(null, context.CurrentCommit, mergeBase, mainlineCommitLog);
7575
log.Info($"Performing {branchIncrement} increment for current branch ");

0 commit comments

Comments
 (0)