ShortVersionParser should ignore start 'V'

Author: SimonCropp

GitVersionCore.Tests/ShortVersionParserTests.cs

@@ -13,6 +13,22 @@ public void Major_minor_patch()
         Assert.AreEqual(2, shortVersion.Minor);
         Assert.AreEqual(3, shortVersion.Patch);
     }
+    [Test]
+    public void With_V()
+    {
+        var shortVersion = ShortVersionParser.Parse("V1.2.3");
+        Assert.AreEqual(1, shortVersion.Major);
+        Assert.AreEqual(2, shortVersion.Minor);
+        Assert.AreEqual(3, shortVersion.Patch);
+    }
+    [Test]
+    public void With_v()
+    {
+        var shortVersion = ShortVersionParser.Parse("v1.2.3");
+        Assert.AreEqual(1, shortVersion.Major);
+        Assert.AreEqual(2, shortVersion.Minor);
+        Assert.AreEqual(3, shortVersion.Patch);
+    }
 
     [Test]
     public void Major_minor_patchTry()

GitVersionCore/ShortVersionParser.cs

@@ -27,6 +27,7 @@ public static bool TryParseMajorMinor(string versionString, out ShortVersion sho
 
         public static bool TryParse(string versionString, out ShortVersion shortVersion)
         {
+            versionString = versionString.TrimStart('v', 'V');
             int major;
             int minor;
             var patch = 0;

GitVersionTask/AssemblyInfoBuilder/AssemblyVersionsGenerator.cs

@@ -1,6 +1,5 @@
-
-    using System;
-    using GitVersion;
+using System;
+using GitVersion;
 
 public static class AssemblyVersionsGenerator
 {