refactor

Author: Byron

gix-refspec/Cargo.toml

@@ -13,7 +13,7 @@ rust-version = "1.65"
 doctest = false
 
 [dependencies]
-gix-revision = { version = "^0.20.0", path = "../gix-revision" }
+gix-revision = { version = "^0.20.0", path = "../gix-revision", default-features = false }
 gix-validate = { version = "^0.8.0", path = "../gix-validate" }
 gix-hash = { version = "^0.12.0", path = "../gix-hash" }
 

gix-refspec/src/parse.rs

@@ -173,16 +173,8 @@ pub(crate) mod function {
                         .map_err(Error::from)
                         .or_else(|err| {
                             if allow_revspecs {
-                                match gix_revision::spec::parse(spec, &mut super::revparse::Noop) {
-                                    Ok(_) => {
-                                        if spec.iter().any(u8::is_ascii_whitespace) {
-                                            Err(err)
-                                        } else {
-                                            Ok(spec)
-                                        }
-                                    }
-                                    Err(err) => Err(err.into()),
-                                }
+                                gix_revision::spec::parse(spec, &mut super::revparse::Noop)?;
+                                Ok(spec)
                             } else {
                                 Err(err)
                             }

gix-refspec/tests/parse/invalid.rs

@@ -15,6 +15,14 @@ fn empty_component() {
     ));
 }
 
+#[test]
+fn whitespace() {
+    assert!(matches!(
+        try_parse("refs/heads/test:refs/remotes/ /test", Operation::Fetch).unwrap_err(),
+        Error::ReferenceName(gix_validate::reference::name::Error::Tag(_))
+    ));
+}
+
 #[test]
 fn complex_patterns_with_more_than_one_asterisk() {
     for op in [Operation::Fetch, Operation::Push] {