Provide all information generated by the handshake into the refmap result (#450)

Author: Byron

git-repository/src/config/cache/incubate.rs

@@ -2,7 +2,6 @@ use super::{util, Error};
 
 /// A utility to deal with the cyclic dependency between the ref store and the configuration. The ref-store needs the
 /// object hash kind, and the configuration needs the current branch name to resolve conditional includes with `onbranch`.
-#[allow(dead_code)]
 pub(crate) struct StageOne {
     pub git_dir_config: git_config::File<'static>,
     pub buf: Vec<u8>,

git-repository/src/open.rs

@@ -90,7 +90,6 @@ impl Default for Options {
 }
 
 #[derive(Default, Clone)]
-#[allow(dead_code)]
 pub(crate) struct EnvironmentOverrides {
     /// An override of the worktree typically from the environment, and overrides even worktree dirs set as parameter.
     ///

git-repository/src/remote/connection/list_refs.rs

@@ -136,7 +136,12 @@ pub mod to_map {
                     local: m.rhs.map(|c| c.into_owned()),
                 })
                 .collect();
-            Ok(fetch::RefMap { mappings, fixes })
+            Ok(fetch::RefMap {
+                mappings,
+                fixes,
+                remote_refs: remote.refs,
+                handshake: remote.outcome,
+            })
         }
     }
 }

git-repository/src/remote/connection/mod.rs

@@ -1,7 +1,6 @@
 use crate::Remote;
 
 pub(crate) struct HandshakeWithRefs {
-    #[allow(dead_code)]
     outcome: git_protocol::fetch::handshake::Outcome,
     refs: Vec<git_protocol::fetch::Ref>,
 }

git-repository/src/remote/mod.rs

@@ -37,6 +37,12 @@ pub mod fetch {
         pub mappings: Vec<Mapping>,
         /// Information about the fixes applied to the `mapping` due to validation and sanitization.
         pub fixes: Vec<git_refspec::match_group::validate::Fix>,
+        /// All refs advertised by the remote.
+        pub remote_refs: Vec<git_protocol::fetch::Ref>,
+        /// Additional information provided by the server as part of the handshake.
+        ///
+        /// Note that the `refs` field is always `None` as the refs are placed in `remote_refs`.
+        pub handshake: git_protocol::fetch::handshake::Outcome,
     }
 
     /// Either an object id that the remote has or the matched remote ref itself.

git-repository/src/remote/url/scheme_permission.rs

@@ -1,5 +1,3 @@
-#![allow(dead_code, unused_variables)]
-
 use std::{borrow::Cow, collections::BTreeMap, convert::TryFrom};
 
 use crate::bstr::{BStr, BString, ByteSlice};