feat: use git-sec::Identity type (#386)

It's shared across crates.

Author: Byron

git-credentials/Cargo.toml

@@ -12,11 +12,12 @@ doctest = false
 
 [features]
 ## Data structures implement `serde::Serialize` and `serde::Deserialize`.
-serde1 = ["serde", "bstr/serde1"]
+serde1 = ["serde", "bstr/serde1", "git-sec/serde1"]
 
 # See more keys and their definitions at https://doc.rust-lang.org/cargo/reference/manifest.html
 
 [dependencies]
+git-sec = { version = "^0.1.0", path = "../git-sec" }
 quick-error = "2.0.0"
 serde = { version = "1.0.114", optional = true, default-features = false, features = ["derive"] }
 bstr = { version = "0.2.13", default-features = false, features = ["std"]}

git-credentials/src/helper.rs

@@ -3,14 +3,13 @@ use std::{
     process::{Command, Stdio},
 };
 
-use crate::Identity;
 use quick_error::quick_error;
 
-/// The result used in [`helper()`].
+/// The result used in [`action()`].
 pub type Result = std::result::Result<Option<Outcome>, Error>;
 
 quick_error! {
-    /// The error used in the [credentials helper][helper()].
+    /// The error used in the [credentials helper][action()].
     #[derive(Debug)]
     #[allow(missing_docs)]
     pub enum Error {
@@ -28,7 +27,7 @@ quick_error! {
     }
 }
 
-/// The action to perform by the credentials [`helper()`].
+/// The action to perform by the credentials [`action()`].
 #[derive(Clone, Debug)]
 pub enum Action<'a> {
     /// Provide credentials using the given repository URL (as &str) as context.
@@ -69,11 +68,11 @@ impl NextAction {
     }
 }
 
-/// The outcome of [`helper()`].
+/// The outcome of [`action()`].
 pub struct Outcome {
     /// The obtained identity.
-    pub identity: Identity,
-    /// A handle to the action to perform next using another call to [`helper()`].
+    pub identity: git_sec::Identity,
+    /// A handle to the action to perform next using another call to [`action()`].
     pub next: NextAction,
 }
 
@@ -91,7 +90,7 @@ fn git_program() -> &'static str {
 ///
 /// Usually the first call is performed with [`Action::Fill`] to obtain an identity, which subsequently can be used.
 /// On successful usage, use [`NextAction::approve()`], otherwise [`NextAction::reject()`].
-pub fn helper(action: Action<'_>) -> Result {
+pub fn action(action: Action<'_>) -> Result {
     let mut cmd = Command::new(git_program());
     cmd.arg("credential")
         .arg(action.as_str())
@@ -128,7 +127,7 @@ pub fn helper(action: Action<'_>) -> Result {
                 .map(|(_, n)| n.to_owned())
         };
         Ok(Some(Outcome {
-            identity: Identity::Account {
+            identity: git_sec::Identity::Account {
                 username: find("username")?,
                 password: find("password")?,
             },

git-credentials/src/lib.rs

@@ -2,18 +2,6 @@
 #![deny(missing_docs, rust_2018_idioms)]
 //! Interact with git credentials in various ways and launch helper programs.
 
-#[derive(PartialEq, Eq, Debug, Hash, Ord, PartialOrd, Clone)]
-#[cfg_attr(feature = "serde1", derive(serde::Serialize, serde::Deserialize))]
-/// An identity for use when authenticating the transport layer.
-pub enum Identity {
-    /// An account based identity
-    Account {
-        /// The user's name
-        username: String,
-        /// The user's password
-        password: String,
-    },
-}
-
 ///
 pub mod helper;
+pub use helper::action as helper;