Skip to content

Commit 756991b

Browse files
felipecgitster
authored andcommitted
doc: remove custom callouts format
The code to render callouts for manpages comes from 17 years ago: 776e994 (Properly render asciidoc "callouts" in git man pages., 2006-04-28), and it was needed back then, but DocBook Stylesheets added support for that in 2008 [1], since 1.74.0 it hasn't been necessary. What's worse: the format of the upstream callouts is much nicer than our hacked version. Compare this: $ git diff (1) $ git diff --cached (2) $ git diff HEAD (3) 1. Changes in the working tree not yet staged for the next commit. 2. Changes between the index and your last commit; what you would be committing if you run git commit without -a option. 3. Changes in the working tree since your last commit; what you would be committing if you run git commit -a To this: $ git diff (1) $ git diff --cached (2) $ git diff HEAD (3) 1. Changes in the working tree not yet staged for the next commit. 2. Changes between the index and your last commit; what you would be committing if you run git commit without -a option. 3. Changes in the working tree since your last commit; what you would be committing if you run git commit -a Let's drop our unnecessary inferior custom format and use the official one. [1] https://sourceforge.net/p/docbook/code/7842/ Signed-off-by: Felipe Contreras <[email protected]> Signed-off-by: Junio C Hamano <[email protected]>
1 parent f85cd43 commit 756991b

File tree

1 file changed

+0
-15
lines changed

1 file changed

+0
-15
lines changed

Documentation/manpage-normal.xsl

Lines changed: 0 additions & 15 deletions
Original file line numberDiff line numberDiff line change
@@ -8,19 +8,4 @@
88
<xsl:param name="man.output.quietly" select="1"/>
99
<xsl:param name="refentry.meta.get.quietly" select="1"/>
1010

11-
<!-- convert asciidoc callouts to man page format -->
12-
<xsl:template match="co">
13-
<xsl:value-of select="concat('\fB(',substring-after(@id,'-'),')\fR')"/>
14-
</xsl:template>
15-
<xsl:template match="calloutlist">
16-
<xsl:text>.sp&#10;</xsl:text>
17-
<xsl:apply-templates/>
18-
<xsl:text>&#10;</xsl:text>
19-
</xsl:template>
20-
<xsl:template match="callout">
21-
<xsl:value-of select="concat('\fB',substring-after(@arearefs,'-'),'. \fR')"/>
22-
<xsl:apply-templates/>
23-
<xsl:text>.br&#10;</xsl:text>
24-
</xsl:template>
25-
2611
</xsl:stylesheet>

0 commit comments

Comments
 (0)