Skip to content

Commit 7cb26a1

Browse files
Linus Arvergitster
authored andcommitted
commit: ignore_non_trailer computes number of bytes to ignore
ignore_non_trailer() returns the _number of bytes_ that should be ignored from the end of the log message. It does not by itself "ignore" anything. Rename this function to remove the leading "ignore" verb, to sound more like a quantity than an action. Signed-off-by: Linus Arver <[email protected]> Signed-off-by: Junio C Hamano <[email protected]>
1 parent bcb6cae commit 7cb26a1

File tree

5 files changed

+6
-6
lines changed

5 files changed

+6
-6
lines changed

builtin/commit.c

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -900,7 +900,7 @@ static int prepare_to_commit(const char *index_file, const char *prefix,
900900
strbuf_stripspace(&sb, '\0');
901901

902902
if (signoff)
903-
append_signoff(&sb, ignore_non_trailer(sb.buf, sb.len), 0);
903+
append_signoff(&sb, ignored_log_message_bytes(sb.buf, sb.len), 0);
904904

905905
if (fwrite(sb.buf, 1, sb.len, s->fp) < sb.len)
906906
die_errno(_("could not write commit template"));

builtin/merge.c

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -870,7 +870,7 @@ static void prepare_to_commit(struct commit_list *remoteheads)
870870
_(no_scissors_editor_comment), comment_line_char);
871871
}
872872
if (signoff)
873-
append_signoff(&msg, ignore_non_trailer(msg.buf, msg.len), 0);
873+
append_signoff(&msg, ignored_log_message_bytes(msg.buf, msg.len), 0);
874874
write_merge_heads(remoteheads);
875875
write_file_buf(git_path_merge_msg(the_repository), msg.buf, msg.len);
876876
if (run_commit_hook(0 < option_edit, get_index_file(), NULL,

commit.c

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1769,7 +1769,7 @@ const char *find_commit_header(const char *msg, const char *key, size_t *out_len
17691769
* Returns the number of bytes from the tail to ignore, to be fed as
17701770
* the second parameter to append_signoff().
17711771
*/
1772-
size_t ignore_non_trailer(const char *buf, size_t len)
1772+
size_t ignored_log_message_bytes(const char *buf, size_t len)
17731773
{
17741774
size_t boc = 0;
17751775
size_t bol = 0;

commit.h

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -294,8 +294,8 @@ const char *find_header_mem(const char *msg, size_t len,
294294
const char *find_commit_header(const char *msg, const char *key,
295295
size_t *out_len);
296296

297-
/* Find the end of the log message, the right place for a new trailer. */
298-
size_t ignore_non_trailer(const char *buf, size_t len);
297+
/* Find the number of bytes to ignore from the end of a log message. */
298+
size_t ignored_log_message_bytes(const char *buf, size_t len);
299299

300300
typedef int (*each_mergetag_fn)(struct commit *commit, struct commit_extra_header *extra,
301301
void *cb_data);

trailer.c

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -928,7 +928,7 @@ static size_t find_trailer_start(const char *buf, size_t len)
928928
/* Return the position of the end of the trailers. */
929929
static size_t find_trailer_end(const char *buf, size_t len)
930930
{
931-
return len - ignore_non_trailer(buf, len);
931+
return len - ignored_log_message_bytes(buf, len);
932932
}
933933

934934
static int ends_with_blank_line(const char *buf, size_t len)

0 commit comments

Comments
 (0)