assure we run with the correct clippy version or else: ICE

Author: Byron

.github/workflows/ci.yml

@@ -51,7 +51,7 @@ jobs:
     - name: test
       env:
         CI: true
-      run: make tests
+      run: make tests-ci
 
   test-fast:
     strategy:
@@ -121,7 +121,7 @@ jobs:
           toolchain: 1.65 # clippy is broken for us in 1.66
           components: clippy,rustfmt
       - name: Run cargo clippy
-        run: cargo clippy --all --tests
+        run: make clippy
       - name: Run cargo fmt
         run: cargo fmt --all -- --check
       - name: Run cargo diet

Makefile

@@ -40,6 +40,8 @@ nix-shell-macos: ## Enter a nix-shell able to build on macos
 
 tests: clippy check doc unit-tests journey-tests-pure journey-tests-small journey-tests-async journey-tests journey-tests-smart-release ## run all tests, including journey tests, try building docs
 
+tests-ci: check doc unit-tests journey-tests-pure journey-tests-small journey-tests-async journey-tests journey-tests-smart-release ## run all tests, without clippy, including journey tests, try building docs
+
 audit: ## run various auditing tools to assure we are legal and safe
 	cargo deny check advisories bans licenses sources