fix!: change Graph::try_lookup_or_insert_default() to *::get_or_insert_default() and Graph::try_lookup_or_insert_commit() to *::get_or_insert_commit()

Author: Byron

gix-revwalk/src/graph/mod.rs

@@ -30,7 +30,7 @@ mod errors {
     }
 
     ///
-    pub mod try_lookup_or_insert_default {
+    pub mod get_or_insert_default {
         use crate::graph::commit::to_owned;
 
         /// The error returned by [`try_lookup_or_insert_default()`](crate::Graph::try_lookup_or_insert_default()).
@@ -44,7 +44,7 @@ mod errors {
         }
     }
 }
-pub use errors::{insert_parents, try_lookup_or_insert_default};
+pub use errors::{get_or_insert_default, insert_parents};
 use gix_date::SecondsSinceUnixEpoch;
 
 /// The generation away from the HEAD of graph, useful to limit algorithms by topological depth as well.
@@ -68,7 +68,7 @@ impl<'find, 'cache, T: Default> Graph<'find, 'cache, T> {
         &mut self,
         id: gix_hash::ObjectId,
         update_data: impl FnOnce(&mut T),
-    ) -> Result<Option<LazyCommit<'_, 'cache>>, try_lookup_or_insert_default::Error> {
+    ) -> Result<Option<LazyCommit<'_, 'cache>>, get_or_insert_default::Error> {
         self.try_lookup_or_insert_default(id, T::default, update_data)
     }
 }
@@ -232,12 +232,12 @@ impl<'find, 'cache, T> Graph<'find, 'cache, Commit<T>> {
     /// `update_data(data)` gets run either on existing or on new data.
     ///
     /// Note that none of the data updates happen if `id` didn't exist.
-    pub fn try_lookup_or_insert_commit_default(
+    pub fn get_or_insert_commit_default(
         &mut self,
         id: gix_hash::ObjectId,
         new_data: impl FnOnce() -> T,
         update_data: impl FnOnce(&mut T),
-    ) -> Result<Option<&mut Commit<T>>, try_lookup_or_insert_default::Error> {
+    ) -> Result<Option<&mut Commit<T>>, get_or_insert_default::Error> {
         match self.map.entry(id) {
             gix_hashtable::hash_map::Entry::Vacant(entry) => {
                 let res = try_lookup(&id, &*self.find, self.cache, &mut self.buf)?;
@@ -272,12 +272,12 @@ impl<'find, 'cache, T: Default> Graph<'find, 'cache, Commit<T>> {
     ///
     /// If only commit data is desired without the need for attaching custom data, use
     /// [`try_lookup(id).to_owned()`][Graph::try_lookup()] instead.
-    pub fn try_lookup_or_insert_commit(
+    pub fn get_or_insert_commit(
         &mut self,
         id: gix_hash::ObjectId,
         update_data: impl FnOnce(&mut T),
-    ) -> Result<Option<&mut Commit<T>>, try_lookup_or_insert_default::Error> {
-        self.try_lookup_or_insert_commit_default(id, T::default, update_data)
+    ) -> Result<Option<&mut Commit<T>>, get_or_insert_default::Error> {
+        self.get_or_insert_commit_default(id, T::default, update_data)
     }
 
     /// Lookup `id` in the graph, but insert it if it's not yet present by looking it up without failing if the commit doesn't exist.
@@ -289,7 +289,7 @@ impl<'find, 'cache, T: Default> Graph<'find, 'cache, Commit<T>> {
         &mut self,
         id: gix_hash::ObjectId,
         update_commit: impl FnOnce(&mut Commit<T>, bool),
-    ) -> Result<Option<&mut Commit<T>>, try_lookup_or_insert_default::Error> {
+    ) -> Result<Option<&mut Commit<T>>, get_or_insert_default::Error> {
         match self.map.entry(id) {
             gix_hashtable::hash_map::Entry::Vacant(entry) => {
                 let res = try_lookup(&id, &*self.find, self.cache, &mut self.buf)?;
@@ -326,7 +326,7 @@ impl<'find, 'cache, T> Graph<'find, 'cache, T> {
         id: gix_hash::ObjectId,
         default: impl FnOnce() -> T,
         update_data: impl FnOnce(&mut T),
-    ) -> Result<Option<LazyCommit<'_, 'cache>>, try_lookup_or_insert_default::Error> {
+    ) -> Result<Option<LazyCommit<'_, 'cache>>, get_or_insert_default::Error> {
         let res = try_lookup(&id, &*self.find, self.cache, &mut self.buf)?;
         Ok(res.map(|commit| {
             match self.map.entry(id) {