feat!: Use &dyn gix_object::Find where possible.

As otherwise, one cannot use `&dyn ` at all in this case as it's
unsized.`

Additionally, rename top-level `pub use gix_glob` to `glob` to be
in-line with other public exports of this kind.

Author: Byron

gix-worktree/src/lib.rs

@@ -10,7 +10,8 @@
 #![cfg_attr(docsrs, feature(doc_cfg, doc_auto_cfg))]
 #![deny(missing_docs, rust_2018_idioms, unsafe_code)]
 use bstr::BString;
-pub use gix_glob;
+/// A way to access the [`Case`](glob::pattern::Case) enum which used throughout this API.
+pub use gix_glob as glob;
 
 /// A cache for efficiently executing operations on directories and files which are encountered in sorted order.
 /// That way, these operations can be re-used for subsequent invocations in the same directory.

gix-worktree/src/stack/mod.rs

@@ -108,22 +108,19 @@ impl Stack {
     /// `objects` maybe used to lookup objects from an [id mapping][crate::stack::State::id_mappings_from_index()], with mappnigs
     ///
     /// Provide access to cached information for that `relative` path via the returned platform.
-    pub fn at_path<Find>(
+    pub fn at_path(
         &mut self,
         relative: impl AsRef<Path>,
         is_dir: Option<bool>,
-        objects: Find,
-    ) -> std::io::Result<Platform<'_>>
-    where
-        Find: gix_object::Find,
-    {
+        objects: &dyn gix_object::Find,
+    ) -> std::io::Result<Platform<'_>> {
         self.statistics.platforms += 1;
         let mut delegate = StackDelegate {
             state: &mut self.state,
             buf: &mut self.buf,
             is_dir: is_dir.unwrap_or(false),
             id_mappings: &self.id_mappings,
-            objects: &objects,
+            objects,
             case: self.case,
             statistics: &mut self.statistics,
         };
@@ -142,15 +139,12 @@ impl Stack {
     /// ### Panics
     ///
     /// on illformed UTF8 in `relative`
-    pub fn at_entry<'r, Find>(
+    pub fn at_entry<'r>(
         &mut self,
         relative: impl Into<&'r BStr>,
         is_dir: Option<bool>,
-        objects: Find,
-    ) -> std::io::Result<Platform<'_>>
-    where
-        Find: gix_object::Find,
-    {
+        objects: &dyn gix_object::Find,
+    ) -> std::io::Result<Platform<'_>> {
         let relative = relative.into();
         let relative_path = gix_path::from_bstr(relative);
 

gix-worktree/tests/worktree/stack/attributes.rs

@@ -29,7 +29,7 @@ fn baseline() -> crate::Result {
     let mut actual = cache.attribute_matches();
     let input = std::fs::read(base.join("baseline"))?;
     for (rela_path, expected) in (baseline::Expectations { lines: input.lines() }) {
-        let entry = cache.at_entry(rela_path, None, gix_object::find::Never)?;
+        let entry = cache.at_entry(rela_path, None, &gix_object::find::Never)?;
         let has_match = entry.matching_attributes(&mut actual);
 
         assert_eq!(
@@ -50,7 +50,7 @@ fn baseline() -> crate::Result {
     let mut actual = cache.selected_attribute_matches(["info", "test"]);
     let input = std::fs::read(base.join("baseline.selected"))?;
     for (rela_path, expected) in (baseline::Expectations { lines: input.lines() }) {
-        let entry = cache.at_entry(rela_path, None, gix_object::find::Never)?;
+        let entry = cache.at_entry(rela_path, None, &gix_object::find::Never)?;
         let has_match = entry.matching_attributes(&mut actual);
 
         assert_eq!(

gix-worktree/tests/worktree/stack/create_directory.rs

@@ -15,7 +15,7 @@ fn root_is_assumed_to_exist_and_files_in_root_do_not_create_directory() -> crate
     );
     assert_eq!(cache.statistics().delegate.num_mkdir_calls, 0);
 
-    let path = cache.at_path("hello", Some(false), gix_object::find::Never)?.path();
+    let path = cache.at_path("hello", Some(false), &gix_object::find::Never)?.path();
     assert!(!path.parent().unwrap().exists(), "prefix itself is never created");
     assert_eq!(cache.statistics().delegate.num_mkdir_calls, 0);
     Ok(())
@@ -33,7 +33,7 @@ fn directory_paths_are_created_in_full() {
         ("link", None),
     ] {
         let path = cache
-            .at_path(Path::new("dir").join(name), *is_dir, gix_object::find::Never)
+            .at_path(Path::new("dir").join(name), *is_dir, &gix_object::find::Never)
             .unwrap()
             .path();
         assert!(path.parent().unwrap().is_dir(), "dir exists");
@@ -47,7 +47,7 @@ fn existing_directories_are_fine() -> crate::Result {
     let (mut cache, tmp) = new_cache();
     std::fs::create_dir(tmp.path().join("dir"))?;
 
-    let path = cache.at_path("dir/file", Some(false), gix_object::find::Never)?.path();
+    let path = cache.at_path("dir/file", Some(false), &gix_object::find::Never)?.path();
     assert!(path.parent().unwrap().is_dir(), "directory is still present");
     assert!(!path.exists(), "it won't create the file");
     assert_eq!(cache.statistics().delegate.num_mkdir_calls, 1);
@@ -72,7 +72,7 @@ fn symlinks_or_files_in_path_are_forbidden_or_unlinked_when_forced() -> crate::R
         let relative_path = format!("{dirname}/file");
         assert_eq!(
             cache
-                .at_path(&relative_path, Some(false), gix_object::find::Never)
+                .at_path(&relative_path, Some(false), &gix_object::find::Never)
                 .unwrap_err()
                 .kind(),
             std::io::ErrorKind::AlreadyExists
@@ -93,7 +93,7 @@ fn symlinks_or_files_in_path_are_forbidden_or_unlinked_when_forced() -> crate::R
         }
         let relative_path = format!("{dirname}/file");
         let path = cache
-            .at_path(&relative_path, Some(false), gix_object::find::Never)?
+            .at_path(&relative_path, Some(false), &gix_object::find::Never)?
             .path();
         assert!(path.parent().unwrap().is_dir(), "directory was forcefully created");
         assert!(!path.exists());

gix-worktree/tests/worktree/stack/ignore.rs

@@ -65,7 +65,7 @@ fn exclude_by_dir_is_handled_just_like_git() {
         let relative_path = gix_path::from_byte_slice(relative_entry);
         let is_dir = dir.join(relative_path).metadata().ok().map(|m| m.is_dir());
 
-        let platform = cache.at_entry(relative_entry, is_dir, FindError).unwrap();
+        let platform = cache.at_entry(relative_entry, is_dir, &FindError).unwrap();
         let match_ = platform.matching_exclude_pattern().expect("match all values");
         let _is_excluded = platform.is_excluded();
         assert_eq!(