case-insensitive tests for baseline path matching (#301)

also: prepare for OS specific tests, even though right now there should
be none.

Author: Byron

git-glob/tests/fixtures/make_baseline.sh

@@ -7,11 +7,11 @@ git config commit.gpgsign false
 git config core.autocrlf false
 git config core.ignorecase false
 
-while read -r pattern nomatch; do
-  echo "$pattern" "$nomatch"
+while read -r pattern value; do
+  echo "$pattern" "$value"
   echo "$pattern" > .gitignore
-  git check-ignore -vn "$nomatch" 2>&1 || :
-done <<EOF >>git-baseline.nmatch
+  echo "$value" | git check-ignore -vn --stdin 2>&1 || :
+done <<EOF >git-baseline.nmatch
 */\ XXX/\
 */\\ XXX/\
 /*foo bar/foo
@@ -68,11 +68,15 @@ foo/** foo
 abc[/]def abc/def
 EOF
 
-while read -r pattern match; do
-  echo "$pattern" "$match"
+while read -r pattern value; do
+  echo "$pattern" "$value"
   echo "$pattern" > .gitignore
-  git check-ignore -vn "$match" 2>&1 || :
-done <<EOF >>git-baseline.match
+  echo "$value" | git check-ignore -vn --stdin 2>&1 || :
+done <<EOF >git-baseline.match
+\a  a
+\\\[a-z] \a
+\\\? \a
+\\\* \\
 /*foo.txt barfoo.txt
 *foo.txt bar/foo.txt
 *.c mozilla-sha1/sha1.c
@@ -141,38 +145,25 @@ abc/def abc/def
 EOF
 
 git config core.ignorecase true
-while read -r pattern match; do
-  echo "$pattern" "$match"
+while read -r pattern value; do
+  echo "$pattern" "$value"
   echo "$pattern" > .gitignore
-  git check-ignore -vn "$match" 2>&1 || :
-done <<EOF >>git-baseline.match-icase
+  echo "$value" | git check-ignore -vn --stdin 2>&1 || :
+done <<EOF >git-baseline.match-icase
 aBcDeFg  aBcDeFg
 aBcDeFg  abcdefg
 aBcDeFg  ABCDEFG
 aBcDeFg  AbCdEfG
 EOF
 
 # nmatches OS specific
-# windows
-#    "abc?def" "abc\\def"
 # unix
 #    "abc\\def" "abc/def"
 
 
-# matches OS specific
-
-# unix only
-# "\\a"  "a"
-#"abc\\def"  "abc/def"
-#"abc?def"  "abc/def"
-# \[a-z] \a
-# \? \a
-# \* \\
-
 # windows only
-# "abc[/]def" "abc/def"
-# "abc\\def"  "abc/def"
-#"abc?def"  "abc\\def"
+# abc[/]def "abc/def"
+# abc\def  "abc/def"
 
 # empty string is not a valid path-spec
 #** " "

git-glob/tests/matching/mod.rs

@@ -46,9 +46,22 @@ fn compare_baseline_with_ours() {
     let dir = git_testtools::scripted_fixture_repo_read_only("make_baseline.sh").unwrap();
     let (mut total_matches, mut total_correct, mut panics) = (0, 0, 0);
     let mut mismatches = Vec::new();
-    for (input_file, expected_matches) in &[("git-baseline.match", true), ("git-baseline.nmatch", false)] {
+    for (input_file, mut expected_matches, case, invert_expectation_on_other_os) in &[
+        ("git-baseline.match", true, pattern::Case::Sensitive, false),
+        ("git-baseline.nmatch", false, pattern::Case::Sensitive, false),
+        ("git-baseline.match-icase", true, pattern::Case::Fold, false),
+        // (
+        //     "git-baseline-unix.match",
+        //     true,
+        //     pattern::Case::Sensitive,
+        //     if cfg!(unix) { false } else { true },
+        // ),
+    ] {
         let input = std::fs::read(dir.join(*input_file)).unwrap();
         let mut seen = BTreeSet::default();
+        if *invert_expectation_on_other_os {
+            expected_matches = !expected_matches;
+        }
 
         for m @ GitMatch {
             pattern,
@@ -58,13 +71,18 @@ fn compare_baseline_with_ours() {
         {
             total_matches += 1;
             assert!(seen.insert(m), "duplicate match entry: {:?}", m);
+            assert_eq!(
+                is_match, expected_matches,
+                "baseline for matches must be {} - check baseline and git version: {:?}",
+                expected_matches, m
+            );
             match std::panic::catch_unwind(|| {
                 let pattern = pat(pattern);
                 pattern.matches_repo_relative_path(
                     value,
                     basename_start_pos(value),
                     false, // TODO: does it make sense to pretend it is a dir and see what happens?
-                    pattern::Case::Sensitive,
+                    *case,
                 )
             }) {
                 Ok(actual_match) => {