Skip to content

feat: ✨ add is_silent to process_script() #427

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed

Conversation

KANAjetzt
Copy link
Member

This allows the Dev Tool to process scripts without errors.

@KANAjetzt KANAjetzt added the 4.x label Nov 14, 2024
@KANAjetzt KANAjetzt added this to the 4.x - 7.0.0 milestone Nov 14, 2024
@KANAjetzt KANAjetzt requested a review from Qubus0 November 14, 2024 15:50
@KANAjetzt KANAjetzt self-assigned this Nov 14, 2024
Copy link
Collaborator

@Qubus0 Qubus0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

not the prettiest but does work

@Qubus0
Copy link
Collaborator

Qubus0 commented Nov 14, 2024

hm wait i had another quick think, maybe we can just add a verbose version to call alternatively. should also technically help performance a miniscule amount

func process_script_verbose(path: String) -> String:
	var start_time := Time.get_ticks_msec()
	ModLoaderLog.debug("Start processing script at path: %s" % path, LOG_NAME)
	var processed := process_script(path)
	ModLoaderLog.debug("Finished processing script at path: %s in %s ms" % [path, Time.get_ticks_msec() - start_time], LOG_NAME)
	return processed

@KANAjetzt
Copy link
Member Author

closed in favor of

@KANAjetzt KANAjetzt closed this Nov 14, 2024
@KANAjetzt KANAjetzt deleted the feat_silent_process_script branch November 29, 2024 11:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants