Skip to content

Commit 1a60125

Browse files
authored
removed extra old code (#285)
1 parent 3f68184 commit 1a60125

File tree

3 files changed

+0
-33
lines changed

3 files changed

+0
-33
lines changed

dataproc/snippets/src/main/java/Quickstart.java

Lines changed: 0 additions & 29 deletions
Original file line numberDiff line numberDiff line change
@@ -55,27 +55,6 @@
5555

5656
public class Quickstart {
5757

58-
public static Job waitForJobCompletion(
59-
JobControllerClient jobControllerClient, String projectId, String region, String jobId) {
60-
while (true) {
61-
// Poll the service periodically until the Job is in a finished state.
62-
Job jobInfo = jobControllerClient.getJob(projectId, region, jobId);
63-
switch (jobInfo.getStatus().getState()) {
64-
case DONE:
65-
case CANCELLED:
66-
case ERROR:
67-
return jobInfo;
68-
default:
69-
try {
70-
// Wait a second in between polling attempts.
71-
TimeUnit.SECONDS.sleep(1);
72-
} catch (InterruptedException e) {
73-
throw new RuntimeException(e);
74-
}
75-
}
76-
}
77-
}
78-
7958
public static void quickstart(
8059
String projectId, String region, String clusterName, String jobFilePath)
8160
throws IOException, InterruptedException {
@@ -130,16 +109,8 @@ public static void quickstart(
130109
Job job = Job.newBuilder().setPlacement(jobPlacement).setPysparkJob(pySparkJob).build();
131110

132111
// Submit an asynchronous request to execute the job.
133-
Job request = jobControllerClient.submitJob(projectId, region, job);
134-
String jobId = request.getReference().getJobId();
135-
System.out.println(String.format("Submitting job \"%s\"", jobId));
136-
137-
// Wait for the job to finish.
138-
System.out.println(String.format("Job %s finished successfully.", jobId));
139-
140112
OperationFuture<Job, JobMetadata> submitJobAsOperationAsyncRequest =
141113
jobControllerClient.submitJobAsOperationAsync(projectId, region, job);
142-
143114
Job jobResponse = submitJobAsOperationAsyncRequest.get();
144115

145116
// Print output from Google Cloud Storage.

dataproc/snippets/src/main/java/SubmitJob.java

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -17,7 +17,6 @@
1717
// [START dataproc_submit_job]
1818

1919
import com.google.api.gax.longrunning.OperationFuture;
20-
import com.google.cloud.dataproc.v1.HadoopJob;
2120
import com.google.cloud.dataproc.v1.Job;
2221
import com.google.cloud.dataproc.v1.JobControllerClient;
2322
import com.google.cloud.dataproc.v1.JobControllerSettings;
@@ -28,8 +27,6 @@
2827
import com.google.cloud.storage.Storage;
2928
import com.google.cloud.storage.StorageOptions;
3029
import java.io.IOException;
31-
import java.util.ArrayList;
32-
import java.util.Arrays;
3330
import java.util.concurrent.ExecutionException;
3431
import java.util.regex.Matcher;
3532
import java.util.regex.Pattern;

dataproc/snippets/src/test/java/QuickstartTest.java

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -92,7 +92,6 @@ public void quickstartTest() throws IOException, InterruptedException {
9292
String output = bout.toString();
9393

9494
assertThat(output, CoreMatchers.containsString("Cluster created successfully"));
95-
assertThat(output, CoreMatchers.containsString("Submitting job"));
9695
assertThat(output, CoreMatchers.containsString("Job finished successfully:"));
9796
assertThat(output, CoreMatchers.containsString("successfully deleted"));
9897
}

0 commit comments

Comments
 (0)