Skip to content

Commit 46af62f

Browse files
kryzthovlesv
authored andcommitted
Use long-flags everywhere, for readability. (#970)
Prevents common mistake between -p and -P.
1 parent 7ce7079 commit 46af62f

File tree

4 files changed

+21
-19
lines changed

4 files changed

+21
-19
lines changed

endpoints/getting-started-grpc/README.md

Lines changed: 9 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -78,20 +78,22 @@ and [SDK](https://cloud.google.com/sdk/) configured.
7878
7979
```bash
8080
/usr/share/google/dockercfg_update.sh
81-
docker run -d --name=grpc-hello gcr.io/${GCLOUD_PROJECT}/java-grpc-hello:1.0
81+
docker run --detach --name=grpc-hello gcr.io/${GCLOUD_PROJECT}/java-grpc-hello:1.0
8282
```
8383
8484
1. Run the Endpoints proxy
8585
8686
```bash
87-
docker run --detach --name=esp \
88-
-p 80:9000 \
87+
docker run \
88+
--detach \
89+
--name=esp \
90+
--publish 80:9000 \
8991
--link=grpc-hello:grpc-hello \
9092
gcr.io/endpoints-release/endpoints-runtime:1 \
91-
-s ${SERVICE_NAME} \
92-
-v ${SERVICE_CONFIG_ID} \
93-
-P 9000 \
94-
-a grpc://grpc-hello:50051
93+
--service=${SERVICE_NAME} \
94+
--version=${SERVICE_CONFIG_ID} \
95+
--http2_port=9000 \
96+
--backend=grpc://grpc-hello:50051
9597
```
9698
9799
1. Back on your local machine, get the external IP of your GCE instance.

endpoints/getting-started-grpc/deployment.yaml

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -41,10 +41,10 @@ spec:
4141
- name: esp
4242
image: gcr.io/endpoints-release/endpoints-runtime:1
4343
args: [
44-
"-P", "9000",
45-
"-a", "grpc://127.0.0.1:50051",
46-
"-s", "SERVICE_NAME",
47-
"-v", "SERVICE_CONFIG_ID",
44+
"--http2_port=9000",
45+
"--backend=grpc://127.0.0.1:50051",
46+
"--service=SERVICE_NAME",
47+
"--version=SERVICE_CONFIG_ID",
4848
]
4949
ports:
5050
- containerPort: 9000

endpoints/getting-started/deployment.yaml

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -42,10 +42,10 @@ spec:
4242
- name: esp
4343
image: gcr.io/endpoints-release/endpoints-runtime:1
4444
args: [
45-
"--http_port", "8081",
46-
"--backend", "127.0.0.1:8080",
47-
"--service", "SERVICE_NAME",
48-
"--version", "SERVICE_CONFIG_ID",
45+
"--http_port=8081",
46+
"--backend=127.0.0.1:8080",
47+
"--service=SERVICE_NAME",
48+
"--version=SERVICE_CONFIG_ID",
4949
]
5050
# [END esp]
5151
ports:

endpoints/multiple-versions/container-engine.yaml

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -42,10 +42,10 @@ spec:
4242
- name: esp
4343
image: gcr.io/endpoints-release/endpoints-runtime:1
4444
args: [
45-
"-p", "8081",
46-
"-a", "127.0.0.1:8080",
47-
"-s", "SERVICE_NAME",
48-
"-v", "SERVICE_CONFIG_ID",
45+
"--http_port=8081",
46+
"--backend=127.0.0.1:8080",
47+
"--service=SERVICE_NAME",
48+
"--version=SERVICE_CONFIG_ID",
4949
]
5050
# [END esp]
5151
ports:

0 commit comments

Comments
 (0)