Fix lint errors (#3440)

Author: davidcavazos

dataflow/encryption-keys/pom.xml

@@ -19,6 +19,12 @@
          xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 http://maven.apache.org/xsd/maven-4.0.0.xsd">
   <modelVersion>4.0.0</modelVersion>
 
+  <parent>
+    <groupId>com.google.cloud.samples</groupId>
+    <artifactId>shared-configuration</artifactId>
+    <version>1.0.17</version>
+  </parent>
+
   <groupId>com.example</groupId>
   <artifactId>dataflow-bigquery-kms-key</artifactId>
   <version>1.0</version>

dataflow/encryption-keys/src/main/java/com/example/dataflow/cmek/BigQueryKmsKey.java

@@ -18,8 +18,8 @@
 import com.google.api.services.bigquery.model.TableSchema;
 import java.util.Arrays;
 import org.apache.beam.sdk.Pipeline;
-import org.apache.beam.sdk.io.gcp.bigquery.BigQueryIO.Write.WriteDisposition;
 import org.apache.beam.sdk.io.gcp.bigquery.BigQueryIO;
+import org.apache.beam.sdk.io.gcp.bigquery.BigQueryIO.Write.WriteDisposition;
 import org.apache.beam.sdk.options.Description;
 import org.apache.beam.sdk.options.PipelineOptions;
 import org.apache.beam.sdk.options.PipelineOptionsFactory;
@@ -29,10 +29,12 @@ public class BigQueryKmsKey {
   public interface BigQueryKmsKeyOptions extends PipelineOptions {
     @Description("Cloud Key Management Service key name")
     String getKmsKey();
+
     void setKmsKey(String value);
 
     @Description("Output BigQuery table spec in the format 'PROJECT:DATASET.TABLE'")
     String getOutputBigQueryTable();
+
     void setOutputBigQueryTable(String value);
   }
 
@@ -41,9 +43,9 @@ public static void main(String[] args) {
     // Query from the NASA wildfires public dataset:
     // https://console.cloud.google.com/bigquery?p=bigquery-public-data&d=nasa_wildfire&t=past_week&page=table
     String query =
-        "SELECT latitude,longitude,acq_date,acq_time,bright_ti4,confidence " +
-        "FROM `bigquery-public-data.nasa_wildfire.past_week` " +
-        "LIMIT 10";
+        "SELECT latitude,longitude,acq_date,acq_time,bright_ti4,confidence "
+        + "FROM `bigquery-public-data.nasa_wildfire.past_week` "
+        + "LIMIT 10";
 
     // Schema for the output BigQuery table.
     final TableSchema outputSchema = new TableSchema().setFields(Arrays.asList(
@@ -61,7 +63,8 @@ public static void main(String[] args) {
     // String outputBigQueryTable = "<project>:<dataset>.<table>";
     String outputBigQueryTable = options.getOutputBigQueryTable();
 
-    // String kmsKey = "projects/<project>/locations/<kms-location>/keyRings/<kms-keyring>/cryptoKeys/<kms-key>";
+    // String kmsKey =
+    //    "projects/<project>/locations/<kms-location>/keyRings/<kms-keyring>/cryptoKeys/<kms-key>";
     String kmsKey = options.getKmsKey();
 
     // Create and run an Apache Beam pipeline.

dataflow/flex-templates/kafka_to_bigquery/pom.xml

@@ -19,6 +19,12 @@
   xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance" xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 http://maven.apache.org/xsd/maven-4.0.0.xsd">
   <modelVersion>4.0.0</modelVersion>
 
+  <parent>
+    <groupId>com.google.cloud.samples</groupId>
+    <artifactId>shared-configuration</artifactId>
+    <version>1.0.17</version>
+  </parent>
+
   <groupId>org.apache.beam.samples</groupId>
   <artifactId>kafka-to-bigquery</artifactId>
   <version>1.0</version>

dataflow/flex-templates/kafka_to_bigquery/src/main/java/org/apache/beam/samples/KafkaToBigQuery.java

@@ -1,29 +1,24 @@
-/*
- * Licensed to the Apache Software Foundation (ASF) under one
- * or more contributor license agreements.  See the NOTICE file
- * distributed with this work for additional information
- * regarding copyright ownership.  The ASF licenses this file
- * to you under the Apache License, Version 2.0 (the
- * "License"); you may not use this file except in compliance
- * with the License.  You may obtain a copy of the License at
- *
- *     http://www.apache.org/licenses/LICENSE-2.0
- *
- * Unless required by applicable law or agreed to in writing, software
- * distributed under the License is distributed on an "AS IS" BASIS,
- * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
- * See the License for the specific language governing permissions and
- * limitations under the License.
- */
-package org.apache.beam.samples;
+// Copyright 2019 Google Inc.
+//
+// Licensed under the Apache License, Version 2.0 (the "License");
+// you may not use this file except in compliance with the License.
+// You may obtain a copy of the License at
+//
+//      http://www.apache.org/licenses/LICENSE-2.0
+//
+// Unless required by applicable law or agreed to in writing, software
+// distributed under the License is distributed on an "AS IS" BASIS,
+// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+// See the License for the specific language governing permissions and
+// limitations under the License.
 
-import java.util.Arrays;
+package org.apache.beam.samples;
 
 import com.google.api.services.bigquery.model.TableFieldSchema;
 import com.google.api.services.bigquery.model.TableRow;
 import com.google.api.services.bigquery.model.TableSchema;
 import com.google.gson.Gson;
-
+import java.util.Arrays;
 import org.apache.avro.reflect.Nullable;
 import org.apache.beam.sdk.Pipeline;
 import org.apache.beam.sdk.coders.AvroCoder;
@@ -61,16 +56,20 @@ public interface Options extends StreamingOptions {
     @Description("Apache Kafka topic to read from.")
     @Validation.Required
     String getInputTopic();
+
     void setInputTopic(String value);
 
-    @Description("BigQuery table to write to, in the form 'project:dataset.table' or 'dataset.table'.")
+    @Description(
+        "BigQuery table to write to, in the form 'project:dataset.table' or 'dataset.table'.")
     @Default.String("beam_samples.streaming_beam_sql")
     String getOutputTable();
+
     void setOutputTable(String value);
 
     @Description("Apache Kafka bootstrap servers in the form 'hostname:port'.")
     @Default.String("localhost:9092")
     String getBootstrapServer();
+
     void setBootstrapServer(String value);
   }
 
@@ -103,7 +102,8 @@ public static void main(final String[] args) {
         .apply("Parse JSON", MapElements.into(TypeDescriptor.of(PageRating.class))
             .via(message -> GSON.fromJson(message, PageRating.class)))
 
-        .apply("Add processing time", WithTimestamps.of((pageRating) -> new Instant(pageRating.processingTime)))
+        .apply("Add processing time", WithTimestamps
+            .of((pageRating) -> new Instant(pageRating.processingTime)))
         .apply("Fixed-size windows", Window.into(FixedWindows.of(Duration.standardMinutes(1))))
 
         .apply("Convert to BigQuery TableRow", MapElements.into(TypeDescriptor.of(TableRow.class))

dataflow/templates/pom.xml

@@ -19,6 +19,12 @@
          xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 http://maven.apache.org/xsd/maven-4.0.0.xsd">
   <modelVersion>4.0.0</modelVersion>
 
+  <parent>
+    <groupId>com.google.cloud.samples</groupId>
+    <artifactId>shared-configuration</artifactId>
+    <version>1.0.17</version>
+  </parent>
+
   <groupId>com.example</groupId>
   <artifactId>dataflow-templates</artifactId>
   <version>1.0</version>

dataflow/templates/src/main/java/com/example/dataflow/templates/WordCount.java

@@ -14,9 +14,14 @@
 
 package com.example.dataflow.templates;
 
+import java.util.Arrays;
 import org.apache.beam.sdk.Pipeline;
 import org.apache.beam.sdk.io.TextIO;
-import org.apache.beam.sdk.options.*;
+import org.apache.beam.sdk.options.Default;
+import org.apache.beam.sdk.options.Description;
+import org.apache.beam.sdk.options.PipelineOptions;
+import org.apache.beam.sdk.options.PipelineOptionsFactory;
+import org.apache.beam.sdk.options.ValueProvider;
 import org.apache.beam.sdk.options.ValueProvider.NestedValueProvider;
 import org.apache.beam.sdk.options.ValueProvider.StaticValueProvider;
 import org.apache.beam.sdk.transforms.Count;
@@ -28,8 +33,6 @@
 import org.apache.beam.sdk.values.KV;
 import org.apache.beam.sdk.values.TypeDescriptors;
 
-import java.util.Arrays;
-
 
 public class WordCount {
   // [START word_count_options]
@@ -38,23 +41,27 @@ public interface WordCountOptions extends PipelineOptions {
     @Description("Google Cloud Storage file pattern glob of the file(s) to read from")
     @Default.String("gs://apache-beam-samples/shakespeare/kinglear.txt")
     ValueProvider<String> getInputFile();
+
     void setInputFile(ValueProvider<String> value);
 
     // Required argument (made required via the metadata file).
     @Description("Google Cloud Storage bucket to store the outputs")
     ValueProvider<String> getOutputBucket();
+
     void setOutputBucket(ValueProvider<String> value);
 
     // Optional argument.
     @Description("Filter only words containing the specified substring")
     @Default.String("")
     ValueProvider<String> getWithSubstring();
+
     void setWithSubstring(ValueProvider<String> value);
 
     // Template option available only at template creation.
     @Description("Whether to make it case sensitive or not")
     @Default.Boolean(true)
     Boolean getIsCaseSensitive();
+
     void setIsCaseSensitive(Boolean value);
   }
   // [END word_count_options]
@@ -112,7 +119,7 @@ public static void main(String[] args) {
             options.getOutputBucket(),
             (String bucket) -> String.format("gs://%s/samples/dataflow/wordcount/outputs", bucket)
         )));
-        // [END nested_value_provider]
+    // [END nested_value_provider]
     pipeline.run();
   }
 }