Skip to content

Commit 9557577

Browse files
authored
chore: replaced hard-coded values with env vars (#185)
1 parent d69e490 commit 9557577

10 files changed

+20
-10
lines changed

aiplatform/snippets/src/test/java/aiplatform/CreateDatasetSampleTest.java

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -35,7 +35,7 @@
3535
@RunWith(JUnit4.class)
3636
public class CreateDatasetSampleTest {
3737

38-
private static final String PROJECT_ID = "ucaip-sample-tests";
38+
private static final String PROJECT_ID = System.getenv("UCAIP_PROJECT_ID");
3939
private static final String METADATA_SCHEMA_URI =
4040
"gs://google-cloud-aiplatform/schema/dataset/metadata/image_1.0.0.yaml";
4141
private ByteArrayOutputStream bout;
@@ -52,6 +52,7 @@ private static void requireEnvVar(String varName) {
5252
@BeforeClass
5353
public static void checkRequirements() {
5454
requireEnvVar("GOOGLE_APPLICATION_CREDENTIALS");
55+
requireEnvVar("UCAIP_PROJECT_ID");
5556
}
5657

5758
@Before

aiplatform/snippets/src/test/java/aiplatform/CreateEndpointSampleTest.java

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -35,7 +35,7 @@
3535
@RunWith(JUnit4.class)
3636
public class CreateEndpointSampleTest {
3737

38-
private static final String PROJECT_ID = "ucaip-sample-tests";
38+
private static final String PROJECT_ID = System.getenv("UCAIP_PROJECT_ID");
3939
private ByteArrayOutputStream bout;
4040
private PrintStream out;
4141
private PrintStream originalPrintStream;
@@ -50,6 +50,7 @@ private static void requireEnvVar(String varName) {
5050
@BeforeClass
5151
public static void checkRequirements() {
5252
requireEnvVar("GOOGLE_APPLICATION_CREDENTIALS");
53+
requireEnvVar("UCAIP_PROJECT_ID");
5354
}
5455

5556
@Before

aiplatform/snippets/src/test/java/aiplatform/CreateTrainingPipelineSampleTest.java

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -36,7 +36,7 @@
3636
@RunWith(JUnit4.class)
3737
public class CreateTrainingPipelineSampleTest {
3838

39-
private static final String PROJECT_ID = "ucaip-sample-tests";
39+
private static final String PROJECT_ID = System.getenv("UCAIP_PROJECT_ID");
4040
private static final String DATASET_ID = "1084241610289446912";
4141
private static final String TRAINING_TASK_DEFINITION =
4242
"gs://google-cloud-aiplatform/schema/trainingjob/definition/"
@@ -55,6 +55,7 @@ private static void requireEnvVar(String varName) {
5555
@BeforeClass
5656
public static void checkRequirements() {
5757
requireEnvVar("GOOGLE_APPLICATION_CREDENTIALS");
58+
requireEnvVar("UCAIP_PROJECT_ID");
5859
}
5960

6061
@Before

aiplatform/snippets/src/test/java/aiplatform/DeployModelCustomTrainedModelSampleTest.java

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -34,7 +34,7 @@
3434

3535
public class DeployModelCustomTrainedModelSampleTest {
3636

37-
private static final String PROJECT_ID = "ucaip-sample-tests";
37+
private static final String PROJECT_ID = System.getenv("UCAIP_PROJECT_ID");
3838
private static final String MODEL_ID = "4992732768149438464";
3939
private static final String ENDPOINT_ID = "4366591682456584192";
4040
private ByteArrayOutputStream bout;
@@ -50,6 +50,7 @@ private static void requireEnvVar(String varName) {
5050
@BeforeClass
5151
public static void checkRequirements() {
5252
requireEnvVar("GOOGLE_APPLICATION_CREDENTIALS");
53+
requireEnvVar("UCAIP_PROJECT_ID");
5354
}
5455

5556
@Before

aiplatform/snippets/src/test/java/aiplatform/DeployModelSampleTest.java

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -33,7 +33,7 @@
3333

3434
public class DeployModelSampleTest {
3535

36-
private static final String PROJECT_ID = "ucaip-sample-tests";
36+
private static final String PROJECT_ID = System.getenv("UCAIP_PROJECT_ID");
3737
private static final String MODEL_ID = "00000000000000000";
3838
private ByteArrayOutputStream bout;
3939
private PrintStream out;
@@ -48,6 +48,7 @@ private static void requireEnvVar(String varName) {
4848
@BeforeClass
4949
public static void checkRequirements() {
5050
requireEnvVar("GOOGLE_APPLICATION_CREDENTIALS");
51+
requireEnvVar("UCAIP_PROJECT_ID");
5152
}
5253

5354
@Before

aiplatform/snippets/src/test/java/aiplatform/ExportModelSampleTest.java

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -34,7 +34,7 @@
3434
@RunWith(JUnit4.class)
3535
public class ExportModelSampleTest {
3636

37-
private static final String PROJECT_ID = "ucaip-sample-tests";
37+
private static final String PROJECT_ID = System.getenv("UCAIP_PROJECT_ID");
3838
private static final String MODEL_ID = "3422489426196955136";
3939
private static final String GCS_DESTINATION_URI_PREFIX =
4040
"gs://ucaip-samples-test-output/tmp/export_model_test";
@@ -52,6 +52,7 @@ private static void requireEnvVar(String varName) {
5252
@BeforeClass
5353
public static void checkRequirements() {
5454
requireEnvVar("GOOGLE_APPLICATION_CREDENTIALS");
55+
requireEnvVar("UCAIP_PROJECT_ID");
5556
}
5657

5758
@Before

aiplatform/snippets/src/test/java/aiplatform/GetModelEvaluationSampleTest.java

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -32,7 +32,7 @@
3232
@RunWith(JUnit4.class)
3333
public class GetModelEvaluationSampleTest {
3434

35-
private static final String PROJECT_ID = "ucaip-sample-tests";
35+
private static final String PROJECT_ID = System.getenv("UCAIP_PROJECT_ID");
3636
private static final String MODEL_ID = "3512561418744365056";
3737
private static final String EVALUATION_ID = "9035588644970168320";
3838
private ByteArrayOutputStream bout;
@@ -48,6 +48,7 @@ private static void requireEnvVar(String varName) {
4848
@BeforeClass
4949
public static void checkRequirements() {
5050
requireEnvVar("GOOGLE_APPLICATION_CREDENTIALS");
51+
requireEnvVar("UCAIP_PROJECT_ID");
5152
}
5253

5354
@Before

aiplatform/snippets/src/test/java/aiplatform/GetModelEvaluationSliceSampleTest.java

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -32,7 +32,7 @@
3232
@RunWith(JUnit4.class)
3333
public class GetModelEvaluationSliceSampleTest {
3434

35-
private static final String PROJECT_ID = "ucaip-sample-tests";
35+
private static final String PROJECT_ID = System.getenv("UCAIP_PROJECT_ID");
3636
private static final String MODEL_ID = "3512561418744365056";
3737
private static final String EVALUATION_ID = "9035588644970168320";
3838
private static final String SLICE_ID = "6481571820677004173";
@@ -49,6 +49,7 @@ private static void requireEnvVar(String varName) {
4949
@BeforeClass
5050
public static void checkRequirements() {
5151
requireEnvVar("GOOGLE_APPLICATION_CREDENTIALS");
52+
requireEnvVar("UCAIP_PROJECT_ID");
5253
}
5354

5455
@Before

aiplatform/snippets/src/test/java/aiplatform/GetModelSampleTest.java

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -32,7 +32,7 @@
3232
@RunWith(JUnit4.class)
3333
public class GetModelSampleTest {
3434

35-
private static final String PROJECT_ID = "ucaip-sample-tests";
35+
private static final String PROJECT_ID = System.getenv("UCAIP_PROJECT_ID");
3636
private static final String MODEL_ID = "3512561418744365056";
3737
private ByteArrayOutputStream bout;
3838
private PrintStream out;
@@ -47,6 +47,7 @@ private static void requireEnvVar(String varName) {
4747
@BeforeClass
4848
public static void checkRequirements() {
4949
requireEnvVar("GOOGLE_APPLICATION_CREDENTIALS");
50+
requireEnvVar("UCAIP_PROJECT_ID");
5051
}
5152

5253
@Before

aiplatform/snippets/src/test/java/aiplatform/ListModelEvaluationSliceSampleTest.java

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -32,7 +32,7 @@
3232
@RunWith(JUnit4.class)
3333
public class ListModelEvaluationSliceSampleTest {
3434

35-
private static final String PROJECT_ID = "ucaip-sample-tests";
35+
private static final String PROJECT_ID = System.getenv("UCAIP_PROJECT_ID");
3636
private static final String MODEL_ID = "3512561418744365056";
3737
private static final String EVALUATION_ID = "9035588644970168320";
3838
private ByteArrayOutputStream bout;
@@ -48,6 +48,7 @@ private static void requireEnvVar(String varName) {
4848
@BeforeClass
4949
public static void checkRequirements() {
5050
requireEnvVar("GOOGLE_APPLICATION_CREDENTIALS");
51+
requireEnvVar("UCAIP_PROJECT_ID");
5152
}
5253

5354
@Before

0 commit comments

Comments
 (0)