Skip to content

Device sample updates #1035

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Feb 20, 2018
Merged

Device sample updates #1035

merged 3 commits into from
Feb 20, 2018

Conversation

gguuss
Copy link
Contributor

@gguuss gguuss commented Feb 20, 2018

  • Updates HTTP sample to use v1 instead of beta path
  • Updates MQTT sample to use TLS v1.2 as it's the only supported version on the device bridge.

@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Feb 20, 2018
@gguuss gguuss requested a review from lesv February 20, 2018 22:18
lesv
lesv approved these changes Feb 20, 2018
View reviewed changes
Copy link
Contributor

@lesv lesv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  1. Probably TLSv1.3 isn't rolled out to Java yet, but it should be soon ??
  2. Shouldn't a v1 (GA'd) service be using the One Platform API's?

If you are ok with this, then LGTM.

@gguuss
Copy link
Contributor Author

gguuss commented Feb 20, 2018 •
edited
Loading

Probably TLSv1.3 isn't rolled out to Java yet, but it should be soon ??

Good point! The bridge (as opposed to "server" as it's not a full server) currently is best supported by TLS-v1.2 and MQTT 3.1.1 with QoS 1.

Shouldn't a v1 (GA'd) service be using the One Platform API's?

Great point, the HTTP Device side works with its own identity which makes it difficult to work as a 1P-API.

@gguuss gguuss merged commit 1a8fdc6 into master Feb 20, 2018
@gguuss gguuss deleted the iot-http-uri branch February 20, 2018 23:27
kurtisvg pushed a commit that referenced this pull request Mar 16, 2018
@gguuss @kurtisvg
Device sample updates (#1035)
6c8af87 
* Adds exponential backoff to MQTT

* Updates to v1 base URI and ensures TLSv1.2 is used.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lesv lesv lesv approved these changes

Assignees
No one assigned
Labels
cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@gguuss @lesv @googlebot