Skip to content

Change to endpoints managed rollout #1054

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 10 commits into from
Apr 4, 2018
Merged

Change to endpoints managed rollout #1054

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
df78dfa
[DO NOT MERGE] Change to endpoints managed rollout
Mar 8, 2018
3201a8f
Fixing lint issues\
Mar 28, 2018
e66cdd9
Merge branch 'master' into introduce_managedrollout
Mar 28, 2018
3ea510e
fixing copyright in endpoints
Mar 28, 2018
e2441cf
Merge remote-tracking branch 'origin/master' into introduce_managedro…
Mar 28, 2018
89c9ae8
fix copyright on endpoints
Mar 28, 2018
d2ffe3b
CR comments
Apr 3, 2018
7ce4dbc
Merge branch 'master' into introduce_managedrollout
Apr 3, 2018
163ea31
Merge branch 'introduce_managedrollout' into introduce_managedrollout
Apr 4, 2018
5834368
Merge pull request #2 from GoogleCloudPlatform/introduce_managedrollout
Apr 4, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 2 additions & 3 deletions endpoints/getting-started-grpc/README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -71,7 +71,6 @@ and [SDK](https://cloud.google.com/sdk/) configured.
```bash
GCLOUD_PROJECT=$(curl -s "http://metadata.google.internal/computeMetadata/v1/project/project-id" -H "Metadata-Flavor: Google")
SERVICE_NAME=hellogrpc.endpoints.${GCLOUD_PROJECT}.cloud.goog
SERVICE_CONFIG_ID=<Your Config ID>
```

1. Pull your credentials to access Container Registry, and run your gRPC server container
Expand All @@ -91,7 +90,7 @@ and [SDK](https://cloud.google.com/sdk/) configured.
--link=grpc-hello:grpc-hello \
gcr.io/endpoints-release/endpoints-runtime:1 \
--service=${SERVICE_NAME} \
--version=${SERVICE_CONFIG_ID} \
--rollout_strategy=managed \
--http2_port=9000 \
--backend=grpc://grpc-hello:50051
```
Expand All @@ -116,7 +115,7 @@ and [SDK](https://cloud.google.com/sdk/) configured.
gcloud container clusters create my-cluster
```

1. Edit `deployment.yaml`. Replace `SERVICE_NAME`, `SERVICE_CONFIG_ID`, and `GCLOUD_PROJECT` with your values.
1. Edit `deployment.yaml`. Replace `SERVICE_NAME` and `GCLOUD_PROJECT` with your values.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd prefer to see GOOGLE_CLOUD_PROJECT, but I won't block on it.


1. Deploy to GKE

Expand Down
2 changes: 1 addition & 1 deletion endpoints/getting-started-grpc/deployment.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -44,7 +44,7 @@ spec:
"--http2_port=9000",
"--backend=grpc://127.0.0.1:50051",
"--service=SERVICE_NAME",
"--version=SERVICE_CONFIG_ID",
"--rollout_strategy=managed",
]
ports:
- containerPort: 9000
Expand Down
2 changes: 1 addition & 1 deletion endpoints/getting-started/deployment.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -45,7 +45,7 @@ spec:
"--http_port=8081",
"--backend=127.0.0.1:8080",
"--service=SERVICE_NAME",
"--version=SERVICE_CONFIG_ID",
"--rollout_strategy=managed",
]
# [END esp]
ports:
Expand Down
2 changes: 1 addition & 1 deletion endpoints/getting-started/src/main/appengine/app.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,5 +24,5 @@ endpoints_api_service:
# The following values are to be replaced by information from the output of
# 'gcloud endpoints services deploy openapi-appengine.yaml' command.
name: ENDPOINTS-SERVICE-NAME
config_id: ENDPOINTS-CONFIG-ID
rollout_strategy: managed
# [END configuration]
6 changes: 3 additions & 3 deletions endpoints/getting-started/src/main/java/com/example/endpoints/AuthInfoServlet.java
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
/*
* Copyright 2015 Google Inc.
*
* Copyright 2017 Google Inc.
*
* Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License.
* You may obtain a copy of the License at
Expand All @@ -12,7 +12,7 @@
* WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
* See the License for the specific language governing permissions and
* limitations under the License.
*/
*/


package com.example.endpoints;
Expand Down
4 changes: 2 additions & 2 deletions endpoints/multiple-versions/src/main/appengine/app.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,7 @@ handlers:
secure: always

endpoints_api_service:
# The following values are to be replaced by information from the output of
# The following value is to be replaced by information from the output of
# 'gcloud endpoints services deploy openapi-v1.yaml openapi-v2.yaml' command.
name: ENDPOINTS-SERVICE-NAME
config_id: ENDPOINTS-CONFIG-ID
rollout_strategy: managed