Adding Spanner STRUCT param samples #1128
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jabubake
added
the
do not merge
googlebot
added
the
cla: yes
kurtisvg
approved these changes
Jun 12, 2018
kurtisvg
previously requested changes
Jun 12, 2018
|
|
||
| runSample("writestructdata"); | ||
| out = runSample("querywithstruct"); | ||
| assertThat(out).contains("6"); |
There was a problem hiding this comment.
These "contains" asserts should considered switching to "equals" since if the input contains a 6 in the stack trace they may still pass.
There was a problem hiding this comment.
Ack, will confirm changes work once the library is released.
jabubake
removed
the
do not merge
|
@kurtisvg @jsimonweb FYI : would be great if you could review + merge. |
jsimonweb
approved these changes
Jun 15, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.