Skip to content

run/broken: exclude "improved" route from run_broken_service #1640

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Oct 24, 2019

Conversation

grayside
Copy link
Contributor

Need to exclude the "fixed" version of the code from the run_broken_service region tag.

@grayside grayside requested review from averikitsch and a team October 23, 2019 22:06
@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Oct 23, 2019
@@ -63,6 +64,7 @@ public static void main(String[] args) {
res.status(200);
return String.format("Hello %s!", name);
});
// [START run_broken_service]
Copy link
Contributor

@averikitsch averikitsch Oct 23, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[ERROR] src/main/java/com/example/cloudrun/App.java:[67] (indentation) CommentsIndentation: Comment has incorrect indentation level 2, expected is 4, indentation should be the same level as line 52.

Copy link
Contributor

@kurtisvg kurtisvg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM once checkstyle passes

@averikitsch averikitsch merged commit 8752293 into master Oct 24, 2019
@averikitsch averikitsch deleted the run-broken-exclude-fix branch October 24, 2019 19:38
bradmiro pushed a commit that referenced this pull request Dec 2, 2019
* run/broken: exclude "improved" route from run_broken_service

* Whitespace checkstyle blind fix.

* fix styling
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants